From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23954 invoked by alias); 20 Dec 2013 14:47:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23945 invoked by uid 89); 20 Dec 2013 14:47:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga02.intel.com Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Dec 2013 14:47:21 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 20 Dec 2013 06:47:18 -0800 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga001.jf.intel.com with ESMTP; 20 Dec 2013 06:47:17 -0800 Received: from irsmsx152.ger.corp.intel.com (163.33.192.66) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.123.3; Fri, 20 Dec 2013 14:47:16 +0000 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.135]) by IRSMSX152.ger.corp.intel.com ([169.254.6.169]) with mapi id 14.03.0123.003; Fri, 20 Dec 2013 14:47:16 +0000 From: "Metzger, Markus T" To: Pedro Alves CC: "jan.kratochvil@redhat.com" , "gdb-patches@sourceware.org" , Eli Zaretskii Subject: RE: [PATCH v9 29/29] record-btrace: add (reverse-)stepping support Date: Fri, 20 Dec 2013 14:47:00 -0000 Message-ID: References: <1387471499-29444-1-git-send-email-markus.t.metzger@intel.com> <1387471499-29444-30-git-send-email-markus.t.metzger@intel.com> <52B3529E.70407@redhat.com> In-Reply-To: Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00836.txt.bz2 > -----Original Message----- > From: Metzger, Markus T > Sent: Friday, December 20, 2013 3:37 PM > To: Pedro Alves > > This really shouldn't be necessary, given target_resume does > > it for you. If you still needed, you're papering over some > > problem. >=20 > If we start replaying in to_wait, we'll call get_current_frame > to fix up some stepping related frames. This will be done on > the current PC. >=20 > When we step later on in record_btrace_step_thread, we change > the replay position but not the PC. >=20 > I guess it will be more clear when I move this into > record_btrace_step_thread and change the comment. I moved it to record_btrace_start_replaying: @@ -1406,15 +1405,15 @@ record_btrace_start_replaying (struct thread_info *= tp) /* Restore the previous execution state. */ set_executing (tp->ptid, executing); =20 + /* Invalidate registers again. If this is called on the to_wait path, + we expect registers still invalid from to_resume. */ + registers_changed_ptid (tp->ptid); + if (except.reason < 0) { xfree (btinfo->replay); btinfo->replay =3D NULL; =20 - /* Avoid stale frames based on branch trace unwinding. */ - registers_changed_ptid (tp->ptid); - get_current_frame (); - throw_exception (except); } Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052