From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: Tom Tromey <tromey@redhat.com>
Cc: "jan.kratochvil@redhat.com" <jan.kratochvil@redhat.com>,
"palves@redhat.com" <palves@redhat.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH v10 25/28] btrace, gdbserver: read branch trace incrementally
Date: Fri, 17 Jan 2014 08:28:00 -0000 [thread overview]
Message-ID: <A78C989F6D9628469189715575E55B230AA450BD@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <87r487n724.fsf@fleche.redhat.com>
> -----Original Message-----
> From: Tom Tromey [mailto:tromey@redhat.com]
> Sent: Thursday, January 16, 2014 6:57 PM
> Markus> -VEC (btrace_block_s) *
> Markus> -target_read_btrace (struct btrace_target_info *btinfo,
> Markus> +enum btrace_error
> Markus> +target_read_btrace (VEC (btrace_block_s) **btrace,
> Markus> + struct btrace_target_info *btinfo,
> Markus> enum btrace_read_type type)
> Markus> {
> Markus> struct target_ops *t;
>
> Markus> for (t = current_target.beneath; t != NULL; t = t->beneath)
> Markus> if (t->to_read_btrace != NULL)
> Markus> - return t->to_read_btrace (btinfo, type);
> Markus> + return t->to_read_btrace (btrace, btinfo, type);
>
> Markus> tcomplain ();
> Markus> - return NULL;
> Markus> + return BTRACE_ERR_NOT_SUPPORTED;
> Markus> }
>
> While rebasing my branch I noticed this code.
>
> tcomplain doesn't return, so the final "return" here will never be
> executed.
>
> Given the function's history I assume this is no big deal -- just a
> small oversight, compounded by the compiler not bothering to tell us
> that it knows about this :)
>
> However I wanted to point it out in case you were expecting an error
> return here.
I am expecting the exception from tcomplain ().
The return BTRACE_ERR_NOT_SUPPORTED is to avoid warnings from
compilers that can't figure out that tcomplain () does not return.
I used to return NULL before and I'm using the same pattern in
target_enable_btrace. There's another instance in dummy_get_bookmark.
If this turns out to be unnecessary, I can send a patch to remove
those extra returns.
Regards,
Markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052
next prev parent reply other threads:[~2014-01-17 8:28 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 8:05 [PATCH v10 00/28] record-btrace: reverse Markus Metzger
2014-01-14 8:04 ` [PATCH v10 03/28] btrace: uppercase btrace_read_type Markus Metzger
2014-01-14 8:04 ` [PATCH v10 10/28] record-btrace: optionally indent function call history Markus Metzger
2014-01-14 16:07 ` Eli Zaretskii
2014-01-14 8:04 ` [PATCH v10 05/28] frame: add frame_id_build_unavailable_stack_special Markus Metzger
2014-01-14 8:04 ` [PATCH v10 26/28] record-btrace: show trace from enable location Markus Metzger
2014-01-14 8:04 ` [PATCH v10 20/28] record-btrace: provide xfer_partial target method Markus Metzger
2014-01-15 15:51 ` Pedro Alves
2014-01-14 8:04 ` [PATCH v10 18/28] record-btrace, frame: supply target-specific unwinder Markus Metzger
2014-01-14 8:04 ` [PATCH v10 01/28] btrace, test: fix multi-line btrace tests Markus Metzger
2014-01-14 8:04 ` [PATCH v10 14/28] record-btrace: supply register target methods Markus Metzger
2014-01-14 8:05 ` [PATCH v10 22/28] record-btrace: provide target_find_new_threads method Markus Metzger
2014-01-14 8:05 ` [PATCH v10 07/28] record-btrace: fix insn range in function call history Markus Metzger
2014-01-14 8:05 ` [PATCH v10 15/28] frame, backtrace: allow targets to supply a frame unwinder Markus Metzger
2014-01-14 8:05 ` [PATCH v10 28/28] record-btrace: add (reverse-)stepping support Markus Metzger
2014-01-14 8:05 ` [PATCH v10 27/28] target: allow decr_pc_after_break to be defined by the target Markus Metzger
2014-01-14 8:05 ` [PATCH v10 13/28] Add target_ops argument to to_prepare_to_store Markus Metzger
2014-01-14 8:05 ` [PATCH v10 24/28] record-btrace: extend unwinder Markus Metzger
2014-01-14 8:05 ` [PATCH v10 06/28] btrace: change branch trace data structure Markus Metzger
2015-01-08 20:49 ` x86_64-m32 internal error for multi-thread-step.exp [Re: [PATCH v10 06/28] btrace: change branch trace data structure] Jan Kratochvil
2015-01-20 15:19 ` Metzger, Markus T
2015-01-22 12:30 ` Metzger, Markus T
2015-01-22 13:36 ` Pedro Alves
2015-01-22 17:37 ` Linux: make target_is_async_p return false when async is off Pedro Alves
2015-01-23 10:39 ` Metzger, Markus T
2015-01-23 12:34 ` Pedro Alves
2015-01-22 16:37 ` x86_64-m32 internal error for multi-thread-step.exp [Re: [PATCH v10 06/28] btrace: change branch trace data structure] Jan Kratochvil
2015-01-23 7:56 ` Metzger, Markus T
2015-01-23 16:01 ` Metzger, Markus T
2015-01-23 16:33 ` Metzger, Markus T
2015-01-27 18:05 ` Pedro Alves
2015-01-29 16:28 ` Metzger, Markus T
2015-01-25 19:56 ` record btrace experience [Re: x86_64-m32 internal error for multi-thread-step.exp [Re: [PATCH v10 06/28] btrace: change branch trace data structure]] Jan Kratochvil
2015-01-26 12:41 ` Metzger, Markus T
2015-01-27 8:07 ` Jan Kratochvil
2015-01-27 15:52 ` Pedro Alves
2015-01-29 19:28 ` Metzger, Markus T
2015-01-23 12:55 ` x86_64-m32 internal error for multi-thread-step.exp [Re: [PATCH v10 06/28] btrace: change branch trace data structure] Patrick Palka
2014-01-14 8:05 ` [PATCH v10 09/28] btrace: increase buffer size Markus Metzger
2014-01-14 8:05 ` [PATCH v10 21/28] record-btrace: add to_wait and to_resume target methods Markus Metzger
2014-01-14 8:05 ` [PATCH v10 12/28] btrace: add replay position to btrace thread info Markus Metzger
2014-01-14 8:05 ` [PATCH v10 04/28] gdbarch: add instruction predicate methods Markus Metzger
2014-01-14 8:05 ` [PATCH v10 11/28] record-btrace: make ranges include begin and end Markus Metzger
2014-01-14 8:05 ` [PATCH v10 23/28] record-btrace: add record goto target methods Markus Metzger
2014-01-14 8:05 ` [PATCH v10 17/28] frame: do not assume unwinding will succeed Markus Metzger
2014-01-14 8:05 ` [PATCH v10 19/28] target, breakpoint: allow insert/remove breakpoint to be forwarded Markus Metzger
2014-01-15 15:52 ` Pedro Alves
2014-01-14 8:05 ` [PATCH v10 02/28] btrace, linux: fix memory leak when reading branch trace Markus Metzger
2014-01-14 8:05 ` [PATCH v10 08/28] record-btrace: start counting at one Markus Metzger
2014-01-14 8:05 ` [PATCH v10 25/28] btrace, gdbserver: read branch trace incrementally Markus Metzger
2014-01-16 17:57 ` Tom Tromey
2014-01-17 8:28 ` Metzger, Markus T [this message]
2014-01-20 5:44 ` Tom Tromey
2014-01-14 8:05 ` [PATCH v10 16/28] frame, cfa: check unwind stop reason first Markus Metzger
2014-01-15 15:54 ` [PATCH v10 00/28] record-btrace: reverse Pedro Alves
2014-01-16 12:01 ` Metzger, Markus T
2014-01-16 12:37 ` Pedro Alves
2014-01-16 14:35 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A78C989F6D9628469189715575E55B230AA450BD@IRSMSX104.ger.corp.intel.com \
--to=markus.t.metzger@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=palves@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).