From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14136 invoked by alias); 14 Nov 2014 12:36:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14126 invoked by uid 89); 14 Nov 2014 12:36:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mga01.intel.com Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Nov 2014 12:36:32 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 14 Nov 2014 04:36:24 -0800 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga001.fm.intel.com with ESMTP; 14 Nov 2014 04:36:19 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.116]) by IRSMSX103.ger.corp.intel.com ([169.254.3.134]) with mapi id 14.03.0195.001; Fri, 14 Nov 2014 12:36:19 +0000 From: "Metzger, Markus T" To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 02/12] btrace: add format argument to supports_btrace Date: Fri, 14 Nov 2014 12:36:00 -0000 Message-ID: References: <1405346196-1804-1-git-send-email-markus.t.metzger@intel.com> <1405346196-1804-3-git-send-email-markus.t.metzger@intel.com> <545A8C5B.3040504@redhat.com> In-Reply-To: <545A8C5B.3040504@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00299.txt.bz2 > -----Original Message----- > From: Pedro Alves [mailto:palves@redhat.com] > Sent: Wednesday, November 5, 2014 9:45 PM > > Moved declarations in btrace-common.h around to break a cyclic > dependency > > with gdbserver/server.h. >=20 > This should no longer be necessary since > 462f517e5020a464e84d2b8535b1b68d39329dc2. Good. It indeed is no longer necessary. > > +/* Target specific branch trace information. */ > > +struct btrace_target_info; > > + > > +/* Enumeration of btrace read types. */ > > + > > +enum btrace_read_type > > +{ > > + /* Send all available trace. */ > > + BTRACE_READ_ALL, > > + > > + /* Send all available trace, if it changed. */ > > + BTRACE_READ_NEW, > > + > > + /* Send the trace since the last request. This will fail if the tra= ce > > + buffer overflowed. */ > > + BTRACE_READ_DELTA > > +}; >=20 > What does "Send" mean here? It means as much as "read". It determines what trace you'll get when reading btrace. I realize it's the producer's view; it should rather be the consumer's view. Do you want me to change it in a separate patch? Regards, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052