From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: Pedro Alves <palves@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH v2 2/2] ari, btrace: avoid unsigned long long
Date: Fri, 10 Jul 2015 07:17:00 -0000 [thread overview]
Message-ID: <A78C989F6D9628469189715575E55B233316B632@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <559E57C0.90006@redhat.com>
> -----Original Message-----
> From: Pedro Alves [mailto:palves@redhat.com]
> Sent: Thursday, July 9, 2015 1:15 PM
> To: Metzger, Markus T
> Cc: gdb-patches@sourceware.org
> Subject: Re: [PATCH v2 2/2] ari, btrace: avoid unsigned long long
>
> On 07/09/2015 07:08 AM, Markus Metzger wrote:
> > Fix the ARI warning about the use of unsigned long long. We can't use
> ULONGEST
> > as this is defined unsigned long on 64-bit systems.
>
> But, what exactly would break?
I changed the commit message to this:
Fix the ARI warning about the use of unsigned long long. We can't use
ULONGEST as this is defined unsigned long on 64-bit systems. This will
result in a compile error when storing a pointer to an unsigned long long
structure field (declared in perf_evene.h as __u64) in a ULONGEST * variable.
Use unsigned long to hold the buffer size inside GDB and __u64 when
interfacing the kernel.
Is that OK?
> > Use unsigned long to hold
> > the buffer size inside GDB
>
> Why not use size_t instead then?
It's another typedef. And without a clearly defined size.
Regards,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Prof. Dr. Hermann Eul
Chairperson of the Supervisory Board: Tiffany Doon Silva
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2015-07-10 7:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 6:09 [PATCH v2 1/2] record: set stop_pc in "record goto" command Markus Metzger
2015-07-09 6:08 ` [PATCH v2 2/2] ari, btrace: avoid unsigned long long Markus Metzger
2015-07-09 11:15 ` Pedro Alves
2015-07-10 7:17 ` Metzger, Markus T [this message]
2015-07-10 14:05 ` Pedro Alves
2015-07-13 7:20 ` Metzger, Markus T
2015-07-13 9:35 ` Pedro Alves
2015-07-09 10:38 ` [PATCH v2 1/2] record: set stop_pc in "record goto" command Pedro Alves
2015-07-13 7:39 ` Metzger, Markus T
2015-07-13 9:36 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A78C989F6D9628469189715575E55B233316B632@IRSMSX104.ger.corp.intel.com \
--to=markus.t.metzger@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).