public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	"palves@redhat.com" <palves@redhat.com>
Subject: RE: [PATCH 0/5] improve trace gap handling
Date: Thu, 27 Oct 2016 12:39:00 -0000	[thread overview]
Message-ID: <A78C989F6D9628469189715575E55B233FFFBBE5@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <8637ji83dd.fsf@gmail.com>

> -----Original Message-----
> From: Yao Qi [mailto:qiyaoltc@gmail.com]
> Sent: Thursday, October 27, 2016 12:59 PM
> To: Metzger, Markus T <markus.t.metzger@intel.com>
> Cc: gdb-patches@sourceware.org; palves@redhat.com
> Subject: Re: [PATCH 0/5] improve trace gap handling

Hello Yao,

> > A small patch series that improves dealing with gaps in recorded trace.
> 
> I think you can self approve these btrace patches, unless this patch
> series address Pedro or other people's review comments.  The cover
> letter is too simple to link this patch series to previous reviews.

The series has not been reviewed, yet.  It does not refer to any previous
review comment.

Don't we want patches to be peer reviewed in general?  Or are you
saying that I can and should make changes to record-btrace without
review?

thanks,
markus.

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

  reply	other threads:[~2016-10-27 12:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-22  8:12 Markus Metzger
2016-07-22  8:12 ` [PATCH 1/5] btrace: fix gap indication Markus Metzger
2016-07-22  8:12 ` [PATCH 5/5] btrace: bridge gaps Markus Metzger
2016-07-22  8:12 ` [PATCH 4/5] btrace: preserve function level for unexpected returns Markus Metzger
2016-07-22  8:12 ` [PATCH 3/5] btrace: update tail call heuristic Markus Metzger
2016-07-22  8:12 ` [PATCH 2/5] btrace: allow leading trace gaps Markus Metzger
2016-10-27 10:59 ` [PATCH 0/5] improve trace gap handling Yao Qi
2016-10-27 12:39   ` Metzger, Markus T [this message]
2016-10-27 15:04     ` Yao Qi
2016-10-27 15:11       ` Pedro Alves
2016-10-28  7:11         ` Metzger, Markus T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A78C989F6D9628469189715575E55B233FFFBBE5@IRSMSX104.ger.corp.intel.com \
    --to=markus.t.metzger@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).