From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94650 invoked by alias); 5 Apr 2017 07:13:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94635 invoked by uid 89); 5 Apr 2017 07:13:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=supervisory, Supervisory, Chairperson, chairperson X-HELO: mga09.intel.com Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Apr 2017 07:13:45 +0000 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2017 00:13:44 -0700 X-ExtLoop1: 1 Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by FMSMGA003.fm.intel.com with ESMTP; 05 Apr 2017 00:13:43 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.170]) by IRSMSX152.ger.corp.intel.com ([169.254.6.231]) with mapi id 14.03.0319.002; Wed, 5 Apr 2017 08:13:43 +0100 From: "Metzger, Markus T" To: Pedro Alves , "gdb-patches@sourceware.org" Subject: RE: [PATCH 15/18] -Wwrite-strings: execute_command calls with string literals Date: Wed, 05 Apr 2017 07:13:00 -0000 Message-ID: References: <1491326751-16180-1-git-send-email-palves@redhat.com> <1491326751-16180-16-git-send-email-palves@redhat.com> In-Reply-To: <1491326751-16180-16-git-send-email-palves@redhat.com> dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00079.txt.bz2 Hello Pedro, > All these places would better be calling some API function directly > instead of going through execute_command & friends... Ah, and I thought this is the preferred way. The patch looks good to me. But I'm wondering if we should instead change execute_command to take a const char *. Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928