RE: [PATCH] Replace VEC(gdb_xml_value_s) with std::vector

["Metzger, Markus T" <markus.t.metzger@intel.com>]

> -----Original Message-----
> From: Simon Marchi [mailto:simon.marchi@ericsson.com]
> Sent: 07 December 2017 19:50
> To: Metzger, Markus T <markus.t.metzger@intel.com>; Simon Marchi
> <simon.marchi@polymtl.ca>; gdb-patches@sourceware.org
> Subject: Re: [PATCH] Replace VEC(gdb_xml_value_s) with std::vector

Hello Simon,

> In your quote, there appears to be two added lines (two +):
> 
> > -    = (const char *) xml_find_attribute (attributes, "version")->value;
> > +    = (const char *) xml_find_attribute (attributes,
> > + "version")->value.get ();
> 
> But in my patch it's all on the same line.  I am confused.

That's what I meant with odd.  Looks like some extra line breaks.

> 
> > @@ -2040,8 +2042,8 @@ parse_xml_btrace_block (struct gdb_xml_parser
> *parser,
> >        gdb_xml_error (parser, _("Btrace format error."));
> >      }
> >
> > -  begin = (ULONGEST *) xml_find_attribute (attributes,
> > "begin")->value;
> > -  end = (ULONGEST *) xml_find_attribute (attributes, "end")->value;
> > +  begin = (ULONGEST *) xml_find_attribute (attributes,
> > + "begin")->value.get ();  end = (ULONGEST *) xml_find_attribute
> > + (attributes, "end")->value.get ();

And here, the line break after ';' seems to have been removed.

Thanks,
Markus.

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928