From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114911 invoked by alias); 27 Feb 2018 11:41:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114897 invoked by uid 89); 27 Feb 2018 11:41:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Tel, tel X-HELO: mga12.intel.com Received: from mga12.intel.com (HELO mga12.intel.com) (192.55.52.136) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Feb 2018 11:41:47 +0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2018 03:41:45 -0800 X-ExtLoop1: 1 Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by orsmga006.jf.intel.com with ESMTP; 27 Feb 2018 03:41:44 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.101]) by IRSMSX108.ger.corp.intel.com ([169.254.11.9]) with mapi id 14.03.0319.002; Tue, 27 Feb 2018 11:41:44 +0000 From: "Metzger, Markus T" To: Eli Zaretskii CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 2/2] btrace: set/show record btrace cpu Date: Tue, 27 Feb 2018 11:41:00 -0000 Message-ID: References: <1519379570-16643-1-git-send-email-markus.t.metzger@intel.com> <1519379570-16643-2-git-send-email-markus.t.metzger@intel.com> <83woz34xuj.fsf@gnu.org> <83lgff1s4n.fsf@gnu.org> In-Reply-To: <83lgff1s4n.fsf@gnu.org> x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjIzMDZiZDQtZjg2NS00MDY0LWJlYWUtMzA4Y2NkM2Q5OTQwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJRQkZGZThjblkxZ0hqVUxtN1l3SzVVblB1Q0tLOTZpbnd4Vjg0c2JDXC9JeGk5dkJDSmxMZ3VIVXNra1piZnJrWiJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00423.txt.bz2 Hello Eli, > > > I think we need to say something about just what those "errata > workarounds" > > > are, and what are they used for. > > > > I rephrased this to "... for enabling workarounds for processor errata > > when decoding the trace". >=20 > It's better, but still not clear enough. What kind of "errata" are we ta= lking about? > The kind described in https://community.amd.com/thread/186609, for exampl= e? > And what do the workarounds do? >=20 > If you can explain that to me or give an example, I will try to propose s= ome text to > describe that in the manual. Processor errata are bugs that, in our case, may cause the trace to not mat= ch the spec. This typically causes unaware decoders to fail with some error. An erratum workaround will try to detect an erroneous trace packet sequence= and correct it. In our case, each workaround needs to be enabled separately. The decoder d= etermines the workarounds to be enabled based on the processor on which the trace was= recorded. > > > > + add_prefix_cmd ("cpu", class_support, cmd_set_record_btrace_cpu, > > > > + _("\ > > > > +Set the cpu to be used for trace decode.\n\n\ The format is > > > > +\": \" or \"none\" or \"auto\" (default). > > > ^^ > > > So should there be a blank after the colon, or shouldn't there be? > > > The example in the manual says no blank. > > > > White space is ignored. Do we write this explicitly? >=20 > Not necessarily. But I'd prefer us to consistently use one of the forms. I removed the optional space here and in the commit-message. Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928