From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51920 invoked by alias); 1 Mar 2018 16:24:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51609 invoked by uid 89); 1 Mar 2018 16:24:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mga01.intel.com Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Mar 2018 16:24:19 +0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Mar 2018 08:24:03 -0800 X-ExtLoop1: 1 Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga008.jf.intel.com with ESMTP; 01 Mar 2018 08:24:02 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.101]) by IRSMSX151.ger.corp.intel.com ([169.254.4.16]) with mapi id 14.03.0319.002; Thu, 1 Mar 2018 16:24:00 +0000 From: "Metzger, Markus T" To: Eli Zaretskii CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 2/2] btrace: set/show record btrace cpu Date: Thu, 01 Mar 2018 16:24:00 -0000 Message-ID: References: <1519379570-16643-1-git-send-email-markus.t.metzger@intel.com> <1519379570-16643-2-git-send-email-markus.t.metzger@intel.com> <83woz34xuj.fsf@gnu.org> <83lgff1s4n.fsf@gnu.org> <83y3jez3yw.fsf@gnu.org> <83po4pyvji.fsf@gnu.org> <83muzryhql.fsf@gnu.org> In-Reply-To: <83muzryhql.fsf@gnu.org> x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmQzY2RhOTMtMDgwMC00M2QxLTk2NjctODJhZjY2ZDg1NDBiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJ4emprOFhiZXp5OFYyaSt4R253XC9GYXl1Umx3REtHWitwdFRvd1pZa1c0UTlIWW51SWhHWmtzc3NRTW5vMTllKyJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00027.txt.bz2 Hello Eli, > > > > > @cindex processor errata > > > > > @dfn{Processor errata} are bugs in processor firmware that can = cause > > > > > a trace not to match the specification. Trace decoders that are > > > > > unaware of these errata might fail to decode such a trace. > > > > > @value{GDBN} can detect erroneous trace packets and correct the= m, > > > > > thus avoiding the decoding failures. These corrections are kno= wn as > > > > > @dfn{errata workarounds}, and are enabled based on the processo= r on > > > > > which the trace was recorded. > > > > > > > But that completely loses the explanation of what the errata are. > > > If my explanation is not accurate, let's correct it, rather than dele= ting it. > > > > I didn't mean to delete your explanation. I only removed the 'firmware= ' part. >=20 > The text I proposed is above. It begins with an explanation of what thos= e errata > are, and why they are detrimental to btrace. The text you proposed inste= ad is > this: >=20 > Errata may cause the recorded trace to not match the specification. > This, in turn, may cause trace decode to fail. @value{GDBN} can > detect erroneous trace packets and correct them, thus avoiding the > decoding failures. These corrections are known as @dfn{errata > workarounds}, and are enabled based on the processor on which the > trace was recorded. >=20 > This just says that trace decode can fail, but tells nothing about the ph= enomenon > itself. Thus my "completely loses" reaction. >=20 > But I don't want to argue. If you feel that the text you wrote is good e= nough, go > ahead and push it, even though I'm unhappy. I'd rather we find a wording we can all agree on. I added that errata cause the trace to not match the spec and that this wou= ld cause decode to fail. I removed the bit about errata being in the firmware since that is not corr= ect. And I replaced "unaware decoders might fail to decode such a trace" with "T= his, in turn, may cause trace decode to fail". The rest I took as you suggested. Where do you think we need to improve the wording? Thanks, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928