RE: [PATCH 01/10] btrace: Introduce auxiliary instructions.

["Metzger, Markus T" <markus.t.metzger@intel.com>]

Hello Felix,

> Auxiliary instructions are pseudo instructions pointing to auxiliary data.
> This auxiliary data can be printed in all commands displaying (record
> function-call-history, record instruction-history) or stepping through
> (stepi etc.) the execution history, which will be introduced in the next
> commits.
> 
> This patch is in preparation for the ptwrite feature, which is based on
> auxiliary instructions.
> 
> 2019-05-29  Felix Willgerodt  <felix.willgerodt@intel.com>
> 
> gdb/ChangeLog:
> 	* btrace.c (btrace_clear_history): Clear aux_data.
> 	* btrace.h (btrace_insn_class): Add BTRACE_INSN_AUX.
> 	(btrace_insn): New union.
> 	(btrace_thread_info): New member aux_data.
> 
> gdb/doc/ChangeLog:
> 	* gdb.texinfo (Process Record and Replay): Document printing of auxiliary
> 	information.
> 
> ---
>  gdb/btrace.c        |  2 ++
>  gdb/btrace.h        | 25 +++++++++++++++++++++----
>  gdb/doc/gdb.texinfo |  3 +++
>  3 files changed, 26 insertions(+), 4 deletions(-)

LGTM.

Markus.

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928