From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: "andrew.burgess@embecosm.com" <andrew.burgess@embecosm.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [review] gdb/testsuite: Fix minor bug in skip_btrace*tests procs
Date: Tue, 19 Nov 2019 08:04:00 -0000 [thread overview]
Message-ID: <A78C989F6D9628469189715575E55B236B5022AB@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <gerrit.1574100765000.I6dfc04b4adcf5b9424fb542ece7ddbe751bee301@gnutoolchain-gerrit.osci.io>
Hello Andrew,
> gdb/testsuite: Fix minor bug in skip_btrace*tests procs
>
> The two guard functions skip_btrace_tests and skip_btrace_pt_tests have a minor
> bug, if the check function fails to compile then surely we should skip the btrace tests
> - currently we return 0 to indicate don't skip.
>
> gdb/testsuite/ChangeLog:
>
> * lib/gdb.exp (skip_btrace_tests): Return 1 if the test fails to
> compile.
> (skip_btrace_pt_tests): Likewise.
>
> Change-Id: I6dfc04b4adcf5b9424fb542ece7ddbe751bee301
> ---
> M gdb/testsuite/ChangeLog
> M gdb/testsuite/lib/gdb.exp
> 2 files changed, 8 insertions(+), 2 deletions(-)
LGTM.
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2019-11-19 8:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 18:12 Andrew Burgess (Code Review)
2019-11-19 8:04 ` Metzger, Markus T [this message]
2019-11-28 0:44 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-28 0:44 ` [review] " Andrew Burgess (Code Review)
2019-11-28 0:44 ` [pushed] " Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A78C989F6D9628469189715575E55B236B5022AB@IRSMSX104.ger.corp.intel.com \
--to=markus.t.metzger@intel.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).