[commit] increase timeout for "maint print statistics" test

[commit] increase timeout for "maint print statistics" test

[Doug Evans]

Hi.

fyi, I checked this in.
I happened to see a timeout on a linux machine I was testing on
so I just increased the timeout for all targets.
Plus the test wasn't restoring the timeout afterwards.

2010-11-15  Doug Evans  <dje@google.com>

	* gdb.base/maint.exp (maint print statistics): Increase timeout for
	all targets.  Restore old timeout afterwards.

Index: gdb.base/maint.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/maint.exp,v
retrieving revision 1.49
diff -u -p -r1.49 maint.exp
--- gdb.base/maint.exp	9 Nov 2010 04:44:17 -0000	1.49
+++ gdb.base/maint.exp	15 Nov 2010 17:14:06 -0000
@@ -143,11 +143,10 @@ gdb_test "maint demangle main" "Can't de
 
 # The timeout value is raised, because printing all the symbols and
 # statistical information about Cygwin and Windows libraries takes a lot
-# of time.
-if [istarget "*-*-cygwin*"] {
-	set oldtimeout $timeout
-	set timeout [expr $timeout + 500]
-}
+# of time.  This has been noticed on some linux systems too, so just raise
+# the timeout globally.
+set oldtimeout $timeout
+set timeout [expr $timeout + 500]
 
 send_gdb "maint print statistics\n"
 gdb_expect  {
@@ -163,6 +162,8 @@ gdb_expect  {
     timeout         { fail "(timeout) maint print statistics" }
 }
 
+set timeout $oldtimeout
+
 # There aren't any ...
 gdb_test_no_output "maint print dummy-frames"
 

Re: [commit] increase timeout for "maint print statistics" test

[Doug Evans]

On Mon, Nov 15, 2010 at 9:20 AM, Doug Evans <dje@google.com> wrote:
> Hi.
>
> fyi, I checked this in.
> I happened to see a timeout on a linux machine I was testing on
> so I just increased the timeout for all targets.
> Plus the test wasn't restoring the timeout afterwards.
>
> 2010-11-15  Doug Evans  <dje@google.com>
>
>        * gdb.base/maint.exp (maint print statistics): Increase timeout for
>        all targets.  Restore old timeout afterwards.

Heh, except that was in a 7.2 tree, and porting the patch over I see
Ulrich already fixed it (in a better way).
Reverted.