From: Doug Evans <dje@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org,
Joel Brobecker <brobecker@adacore.com>,
Ken Werner <ken@linux.vnet.ibm.com>,
Tom Tromey <tromey@redhat.com>,
Pedro Alves <pedro@codesourcery.com>
Subject: Re: [doc RFA] Switch to GCC coding style [Re: [patch] initial OpenCL C language support]
Date: Tue, 02 Nov 2010 17:29:00 -0000 [thread overview]
Message-ID: <AANLkTi=VV4oxQBdUk0ckA4jfL0Z9z9otfh1bnstFc2Q_@mail.gmail.com> (raw)
In-Reply-To: <20101102172246.GA22137@host0.dyn.jankratochvil.net>
On Tue, Nov 2, 2010 at 10:22 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> On Tue, 02 Nov 2010 18:04:39 +0100, Doug Evans wrote:
>> There are lots of things on the gcc codingconventions page that need
>> to be converted (e.g., gcc_assert),
>
> Done.
>
>> or revised (e.g., prototypes for _initialize_foo fns can appear in .c files
>> (and should *only* appear in .c files)).
>
> I do not see a current GDB doc problem with this (+it may be offtopic for this
> patch).
For reference sake I was referring to this text:
"Function prototypes for extern functions should only occur in header files."
But I see that gdbint.texinfo already does mention this exception.
My reason for mentioning it is that I suspect there are more.
Could be wrong of course.
[For reference sake, don't wait for my approval.
I'm just making suggestions (in this particular case :-)).]
next prev parent reply other threads:[~2010-11-02 17:29 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 17:21 [patch] initial OpenCL C language support Ken Werner
2010-10-25 22:41 ` Tom Tromey
2010-10-26 13:05 ` Ken Werner
2010-10-26 13:44 ` Tom Tromey
2010-10-26 16:02 ` Ken Werner
2010-10-26 17:49 ` Eli Zaretskii
2010-10-26 19:58 ` Joel Brobecker
2010-10-26 20:03 ` Joel Brobecker
2010-10-27 13:36 ` Ken Werner
2010-11-02 19:23 ` Joel Brobecker
2010-11-03 13:03 ` Ken Werner
2010-11-03 15:27 ` Joel Brobecker
2010-11-04 15:39 ` Ken Werner
2010-11-04 17:48 ` Eli Zaretskii
2010-11-05 14:21 ` Ken Werner
2010-11-05 14:39 ` Ken Werner
2010-10-27 19:04 ` Jan Kratochvil
2010-10-27 19:21 ` Pedro Alves
2010-10-27 21:01 ` Ken Werner
2010-11-02 16:52 ` [doc RFA] Switch to GCC coding style [Re: [patch] initial OpenCL C language support] Jan Kratochvil
2010-11-02 17:04 ` Doug Evans
2010-11-02 17:23 ` Jan Kratochvil
2010-11-02 17:29 ` Doug Evans [this message]
2010-11-02 19:21 ` Eli Zaretskii
2010-11-02 19:29 ` Joel Brobecker
2010-11-08 12:50 ` Jan Kratochvil
2010-11-08 16:11 ` Joel Brobecker
2010-11-08 16:38 ` Mark Kettenis
2010-11-08 16:43 ` Joel Brobecker
2010-11-08 16:54 ` Pedro Alves
2010-11-08 18:36 ` Joel Brobecker
2010-11-02 18:01 ` Joel Brobecker
2010-11-02 18:10 ` [doc RFA] Switch to GCC coding style Jan Kratochvil
2010-11-02 18:20 ` Doug Evans
2010-11-02 18:58 ` Joel Brobecker
2010-11-02 19:19 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=VV4oxQBdUk0ckA4jfL0Z9z9otfh1bnstFc2Q_@mail.gmail.com' \
--to=dje@google.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=ken@linux.vnet.ibm.com \
--cc=pedro@codesourcery.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).