From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30382 invoked by alias); 2 Nov 2010 17:29:41 -0000 Received: (qmail 30374 invoked by uid 22791); 2 Nov 2010 17:29:40 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_FN,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.35) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 02 Nov 2010 17:29:35 +0000 Received: from kpbe12.cbf.corp.google.com (kpbe12.cbf.corp.google.com [172.25.105.76]) by smtp-out.google.com with ESMTP id oA2HTWrR000844 for ; Tue, 2 Nov 2010 10:29:32 -0700 Received: from iwn39 (iwn39.prod.google.com [10.241.68.103]) by kpbe12.cbf.corp.google.com with ESMTP id oA2HSIcB018397 for ; Tue, 2 Nov 2010 10:29:31 -0700 Received: by iwn39 with SMTP id 39so10094612iwn.41 for ; Tue, 02 Nov 2010 10:29:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.13.201 with SMTP id d9mr7977069iba.152.1288718970789; Tue, 02 Nov 2010 10:29:30 -0700 (PDT) Received: by 10.220.192.73 with HTTP; Tue, 2 Nov 2010 10:29:30 -0700 (PDT) In-Reply-To: <20101102172246.GA22137@host0.dyn.jankratochvil.net> References: <201010221920.30046.ken@linux.vnet.ibm.com> <20101026195747.GE2847@adacore.com> <20101027190417.GA19067@host1.dyn.jankratochvil.net> <201010272020.51386.pedro@codesourcery.com> <20101102165134.GA19296@host0.dyn.jankratochvil.net> <20101102172246.GA22137@host0.dyn.jankratochvil.net> Date: Tue, 02 Nov 2010 17:29:00 -0000 Message-ID: Subject: Re: [doc RFA] Switch to GCC coding style [Re: [patch] initial OpenCL C language support] From: Doug Evans To: Jan Kratochvil Cc: gdb-patches@sourceware.org, Joel Brobecker , Ken Werner , Tom Tromey , Pedro Alves Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00026.txt.bz2 On Tue, Nov 2, 2010 at 10:22 AM, Jan Kratochvil wrote: > On Tue, 02 Nov 2010 18:04:39 +0100, Doug Evans wrote: >> There are lots of things on the gcc codingconventions page that need >> to be converted (e.g., gcc_assert), > > Done. > >> or revised (e.g., prototypes for _initialize_foo fns can appear in .c files >> (and should *only* appear in .c files)). > > I do not see a current GDB doc problem with this (+it may be offtopic for this > patch). For reference sake I was referring to this text: "Function prototypes for extern functions should only occur in header files." But I see that gdbint.texinfo already does mention this exception. My reason for mentioning it is that I suspect there are more. Could be wrong of course. [For reference sake, don't wait for my approval. I'm just making suggestions (in this particular case :-)).]