From: Doug Evans <dje@google.com>
To: sami wagiaalla <swagiaal@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] PR 12028 "GDB crashes on a double free during overload resolution"
Date: Sun, 19 Sep 2010 17:39:00 -0000 [thread overview]
Message-ID: <AANLkTi=t9g2vsAii9OB1YM1=rUMiE6wb1kT0N-GZVjgx@mail.gmail.com> (raw)
In-Reply-To: <4C937E2D.80500@redhat.com>
On Fri, Sep 17, 2010 at 7:41 AM, sami wagiaalla <swagiaal@redhat.com> wrote:
> old_cleanups was being set twice making the later call to discard_cleanups
> ignore the first 'make_cleanup' request.
>
> The patch is proposed for both head and the 7.2 branch.
>
> This has been regression tested on x8664 with gcc-4.4.4-10.fc13
>
> Sami
>
Hi. This patch is ok.
Looking at the function though, is this a memory leak?
i.e. you want to do_cleanups here, not discard them (right?).
else
{
*oload_syms = new_oload_syms;
*oload_champ = new_oload_champ;
*oload_champ_bv = new_oload_champ_bv;
discard_cleanups (old_cleanups);
return 0;
}
next prev parent reply other threads:[~2010-09-18 16:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-18 9:25 sami wagiaalla
2010-09-19 17:39 ` Doug Evans [this message]
2010-09-22 18:12 ` sami wagiaalla
2010-09-22 19:36 ` Tom Tromey
2010-09-23 18:46 ` sami wagiaalla
2010-09-27 18:02 ` Tom Tromey
2010-09-28 16:32 ` sami wagiaalla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=t9g2vsAii9OB1YM1=rUMiE6wb1kT0N-GZVjgx@mail.gmail.com' \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=swagiaal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).