From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3206 invoked by alias); 3 Sep 2010 15:59:26 -0000 Received: (qmail 3191 invoked by uid 22791); 3 Sep 2010 15:59:24 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 03 Sep 2010 15:59:19 +0000 Received: from wpaz24.hot.corp.google.com (wpaz24.hot.corp.google.com [172.24.198.88]) by smtp-out.google.com with ESMTP id o83FxHkW008712 for ; Fri, 3 Sep 2010 08:59:17 -0700 Received: from vws9 (vws9.prod.google.com [10.241.21.137]) by wpaz24.hot.corp.google.com with ESMTP id o83Fx92S029720 for ; Fri, 3 Sep 2010 08:59:16 -0700 Received: by vws9 with SMTP id 9so1690925vws.34 for ; Fri, 03 Sep 2010 08:59:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.75.200 with SMTP id z8mr719979vcj.197.1283529556193; Fri, 03 Sep 2010 08:59:16 -0700 (PDT) Received: by 10.220.200.73 with HTTP; Fri, 3 Sep 2010 08:59:16 -0700 (PDT) In-Reply-To: <20100903153955.GA3236@host1.dyn.jankratochvil.net> References: <20100823185008.GA2926@host1.dyn.jankratochvil.net> <20100902160216.GA10848@host1.dyn.jankratochvil.net> <20100903153955.GA3236@host1.dyn.jankratochvil.net> Date: Fri, 03 Sep 2010 18:06:00 -0000 Message-ID: Subject: Re: [patch] Fix DW_OP_call2 and DW_OP_call4 for max-cache-age 0 From: Doug Evans To: Jan Kratochvil Cc: Tom Tromey , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00131.txt.bz2 On Fri, Sep 3, 2010 at 8:39 AM, Jan Kratochvil wrote: > On Fri, 03 Sep 2010 17:35:50 +0200, Tom Tromey wrote: >> I don't get the rationale for putting it in prepare_execute_command. >> If we are flushing the cache based on memory use, then we only need to >> consider flushing it just before we read a CU. > > There is currently no way of "locking" CUs. =A0Some processing may arbitr= arily > access more and more CUs, and even the previous ones. =A0Processing may n= eed > generally unlimited number of CUs, therefore it can reach the limit and f= lush > still referenced CU. Unless code that needs a CU reads it in as necessary, and the API into the dwarf reader only ages the cache at well defined points that no longer need CUs (e.g. when we're done psymtab->symtab expansion). (right?) > Therefore I find prepare_execute_command as the only safe place to flush = any > CU. OOC, If we did move cache aging to a higher level, is there a reason it can't be done at cleanup time? [For reference sake, it's actually done today for free_stack_comp_unit.] > (I may miss there exist some more strict rules than I am aware of.)