From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26531 invoked by alias); 28 Jul 2010 07:24:26 -0000 Received: (qmail 26518 invoked by uid 22791); 28 Jul 2010 07:24:25 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM X-Spam-Check-By: sourceware.org Received: from mail-bw0-f41.google.com (HELO mail-bw0-f41.google.com) (209.85.214.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Jul 2010 07:24:18 +0000 Received: by bwz9 with SMTP id 9so4561546bwz.0 for ; Wed, 28 Jul 2010 00:24:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.178.67 with SMTP id bl3mr7167499bkb.161.1280301856004; Wed, 28 Jul 2010 00:24:16 -0700 (PDT) Received: by 10.204.18.144 with HTTP; Wed, 28 Jul 2010 00:24:15 -0700 (PDT) In-Reply-To: <201007272346.46299.pedro@codesourcery.com> References: <201007271543.13838.pedro@codesourcery.com> <201007272346.46299.pedro@codesourcery.com> Date: Wed, 28 Jul 2010 07:24:00 -0000 Message-ID: Subject: Re: [patch] Correct origin calculation of command line window in TUI mode From: Balazs Kezes To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00468.txt.bz2 > These three patches now put you at borderline of > what we can accept without copyright assignment to the FSF. Do > you have that taken care of? If not, let us know, and we'll start > you on the process. I'm not sure what you are talking about. I don't think I'll be doing a lot more work on this so it might be superfluous if this means what I think. On 7/28/10, Pedro Alves wrote: > On Tuesday 27 July 2010 23:38:02, Balazs Kezes wrote: >> > Hmmm, I've tried all three patches together, and I still get a messed >> > up cmd window after a couple of resizes (e.g., start >> > maxized/unmaximize/maximize). >> >> Yeah, these 3 patches are not enough. There are two remaining >> modifications >> which need to be done: > > Ah. > >> 1) HAVE_RESIZE_TERM - to make sure ncurses knows about the terminal size. >> Somehow this needs to be added to the configuration. I'm not sure how >> to do >> this. Maybe I'll look into this sometime. > > I'll do this. These three patches now put you at borderline of > what we can accept without copyright assignment to the FSF. Do > you have that taken care of? If not, let us know, and we'll start > you on the process. > >> 2) The readline modification in order to have correct sizes. I've already >> contacted the readline guys and they told me that this bug will be >> fixed in >> readline 6.2. > > That's good news. In that case, I don't think there's a problem in > backporting the fix to our local copy. Distros can do the same to > their system readline's if they care too. > >> Even after this there is a little annoyance that you need to press a >> key to actually resize and redraw everything, but this could be fixed >> by ungetc or with a similar hack. >> >> Here are the changelogs: > > Thanks. I'll take another look at this soon. > > -- > Pedro Alves >