From: Doug Evans <dje@google.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix regression in -file-list-exec-source-files command.
Date: Thu, 19 Aug 2010 16:35:00 -0000 [thread overview]
Message-ID: <AANLkTikfpNUUJhbC01NH+yK3Xcwbsuc3=XHJ=xjVfkYb@mail.gmail.com> (raw)
In-Reply-To: <20100819100121.GA32167@adacore.com>
On Thu, Aug 19, 2010 at 3:01 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>> This was tested on x86_64-linux in HEAD. I'll see whether it's possible
>> to create a regression test or not, next.
>
> The problem that I am seeing is that, in the testsuite, we compile the
> examples using the source full filenames. For instance, using
> gdb.base/arrayidx.exp, we do:
>
> % gcc /[...]/gdb.base/arrayidx.c -g -lm -o [...]
>
> As a result, the filename field ends up containing the fullname:
>
> (gdb) interpreter-exec mi -file-list-exec-source-files
> ^done,files=[{file="/[...]/gdb.base/arrayidx.c",fullname="/[...]/gdb.base/arrayidx.c"}, [...]
>
> Because of that, we cannot use one of our source files to demonstrate
> the problem.
>
> The only thing I can think of that we could use to demonstrate the problem
> is to check for empty filenames. Before the patch was applied, one of
> the entries looked like this:
>
> {file="",fullname="init.c"}
>
> There is no guaranty that this is going to happen on all platforms,
> or even appear consistently on a given platform. This is probably
> dependent on the compiler as well as the way system libraries such
> as the C library have been built. But I suppose that is better than
> nothing.
While not ideal, could you create a test in assembler/dwarf?
next prev parent reply other threads:[~2010-08-19 16:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-19 9:18 Joel Brobecker
2010-08-19 10:01 ` Joel Brobecker
2010-08-19 16:35 ` Doug Evans [this message]
2010-08-19 18:35 ` [RFA/commit/testsuite] Add test for -file-list-exec-source-files Joel Brobecker
2010-08-19 18:55 ` Jan Kratochvil
2010-09-02 15:37 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTikfpNUUJhbC01NH+yK3Xcwbsuc3=XHJ=xjVfkYb@mail.gmail.com' \
--to=dje@google.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).