* MAINTAINERS: Add myself for write after approval privileges.
@ 2010-07-27 20:56 Cheng Renquan
2010-07-28 4:17 ` Joel Brobecker
2010-07-31 1:47 ` [commit] " Cheng Renquan
0 siblings, 2 replies; 3+ messages in thread
From: Cheng Renquan @ 2010-07-27 20:56 UTC (permalink / raw)
To: gdb-patches; +Cc: Joel Brobecker
[-- Attachment #1: Type: text/plain, Size: 113 bytes --]
add-myself-for-write-after-approval-privileges.patch
To Joel, sorry to mess things up again,
--
CHENG Renquan,
[-- Attachment #2: add-myself-for-write-after-approval-privileges.patch --]
[-- Type: text/x-patch, Size: 1052 bytes --]
Index: gdb/MAINTAINERS
===================================================================
RCS file: /cvs/src/src/gdb/MAINTAINERS,v
retrieving revision 1.439
diff -u -p -r1.439 MAINTAINERS
--- gdb/MAINTAINERS 14 Jul 2010 14:30:35 -0000 1.439
+++ gdb/MAINTAINERS 27 Jul 2010 20:52:05 -0000
@@ -626,6 +626,7 @@ Yoshinori Sato ysato@users.sourcefor
Hui Zhu teawater@gmail.com
Sergio Durigan Junior sergiodj@linux.vnet.ibm.com
Masaki Muranaka monaka@monami-software.com
+CHENG Renquan rqcheng@smu.edu.sg
Past Maintainers
Index: gdb/ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.12025
diff -u -p -r1.12025 ChangeLog
--- gdb/ChangeLog 27 Jul 2010 20:44:30 -0000 1.12025
+++ gdb/ChangeLog 27 Jul 2010 20:52:19 -0000
@@ -1,3 +1,7 @@
+2010-07-28 CHENG Renquan <rqcheng@smu.edu.sg>
+
+ * MAINTAINERS: Add myself for write after approval privileges.
+
2010-07-27 Tom Tromey <tromey@redhat.com>
* NEWS: Mention labels, .gdb_index.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: MAINTAINERS: Add myself for write after approval privileges.
2010-07-27 20:56 MAINTAINERS: Add myself for write after approval privileges Cheng Renquan
@ 2010-07-28 4:17 ` Joel Brobecker
2010-07-31 1:47 ` [commit] " Cheng Renquan
1 sibling, 0 replies; 3+ messages in thread
From: Joel Brobecker @ 2010-07-28 4:17 UTC (permalink / raw)
To: Cheng Renquan; +Cc: gdb-patches
> add-myself-for-write-after-approval-privileges.patch
>
> To Joel, sorry to mess things up again,
Not to worry. Welcome to the project.
I don't remember if I said this explicitly in my other email, but obvious
patches do not require approval before being checked in. I invite you
to have a look at the MAINTAINERS file again, if you are not familiar
with the "Obvious Fix Rule" and what constitutes an obvious fix and what
doesn't. It is always fine to err on the side of caution :).
That being said, you patch revealed that alphabetical order for
the write-after-approval list has been broken by the last couple of
entries. I fixed that, but you will need to redo your patch to insert
your name at the correct location. (no need to wait for approval, just
post the patch as usual, saying that you checked it in).
One last thing: Once you have checked in a patch that was approved,
can you send a followup email confirming the commit? It is customary
to do so and helps keeping track of which patches have been checked in
and which ones haven't.
--
Joel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [commit] MAINTAINERS: Add myself for write after approval privileges.
2010-07-27 20:56 MAINTAINERS: Add myself for write after approval privileges Cheng Renquan
2010-07-28 4:17 ` Joel Brobecker
@ 2010-07-31 1:47 ` Cheng Renquan
1 sibling, 0 replies; 3+ messages in thread
From: Cheng Renquan @ 2010-07-31 1:47 UTC (permalink / raw)
To: gdb-patches; +Cc: Joel Brobecker
[-- Attachment #1: Type: text/plain, Size: 281 bytes --]
On Wed, Jul 28, 2010 at 4:56 AM, Cheng Renquan <crquan@gmail.com> wrote:
> add-myself-for-write-after-approval-privileges.patch
committed, into head and gdb_7_2-branch,
http://sourceware.org/ml/gdb-cvs/2010-07/msg00216.html
http://sourceware.org/ml/gdb-cvs/2010-07/msg00222.html
[-- Attachment #2: add-myself-for-write-approval.patch --]
[-- Type: text/x-patch, Size: 1212 bytes --]
Index: gdb/ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.12048
retrieving revision 1.12049
diff -u -p -u -p -r1.12048 -r1.12049
--- gdb/ChangeLog 30 Jul 2010 16:04:28 -0000 1.12048
+++ gdb/ChangeLog 30 Jul 2010 19:11:26 -0000 1.12049
@@ -1,3 +1,7 @@
+2010-07-31 Renquan Cheng <crq@gcc.gnu.org>
+
+ * MAINTAINERS: Add myself for write after approval privileges.
+
2010-07-30 Jan Kratochvil <jan.kratochvil@redhat.com>
* symfile.c (addr_section_name): New function.
Index: gdb/MAINTAINERS
===================================================================
RCS file: /cvs/src/src/gdb/MAINTAINERS,v
retrieving revision 1.440
retrieving revision 1.441
diff -u -p -u -p -r1.440 -r1.441
--- gdb/MAINTAINERS 28 Jul 2010 04:09:04 -0000 1.440
+++ gdb/MAINTAINERS 30 Jul 2010 19:11:27 -0000 1.441
@@ -482,6 +482,7 @@ Andrew Cagney cagney@gnu.org
David Carlton carlton@bactrian.org
Stephane Carrez stcarrez@nerim.fr
Michael Chastain mec.gnu@mindspring.com
+Renquan Cheng crq@gcc.gnu.org
Eric Christopher echristo@apple.com
Randolph Chung tausq@debian.org
Nick Clifton nickc@redhat.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-31 1:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-27 20:56 MAINTAINERS: Add myself for write after approval privileges Cheng Renquan
2010-07-28 4:17 ` Joel Brobecker
2010-07-31 1:47 ` [commit] " Cheng Renquan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).