From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2180 invoked by alias); 16 Jul 2010 20:10:29 -0000 Received: (qmail 2164 invoked by uid 22791); 16 Jul 2010 20:10:28 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mail-ew0-f41.google.com (HELO mail-ew0-f41.google.com) (209.85.215.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Jul 2010 20:10:23 +0000 Received: by mail-ew0-f41.google.com with SMTP id 28so1000499ewy.0 for ; Fri, 16 Jul 2010 13:10:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.213.27.195 with SMTP id j3mr4759387ebc.18.1279311023164; Fri, 16 Jul 2010 13:10:23 -0700 (PDT) Received: by 10.213.11.1 with HTTP; Fri, 16 Jul 2010 13:10:23 -0700 (PDT) Date: Fri, 16 Jul 2010 20:10:00 -0000 Message-ID: Subject: [PATCH] [Windows] fix format string for 64 bit var in gdbserver From: Ozkan Sezer To: gdb-patches@sourceware.org Cc: Tom Tromey Content-Type: multipart/mixed; boundary=0015174c0ddc17ce02048b86cf32 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00253.txt.bz2 --0015174c0ddc17ce02048b86cf32 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 813 Hi! For windows targets, (x86_64-w64-mingw32, i686-w64-mingw32) gcc complains: ../../../gdb-cvs/gdb/gdbserver/server.c: In function 'handle_query': ../../../gdb-cvs/gdb/gdbserver/server.c:1542: warning: unknown conversion type character 'l' in format ../../../gdb-cvs/gdb/gdbserver/server.c:1542: warning: too many arguments for format ../../../gdb-cvs/gdb/gdbserver/server.c:1566: warning: unknown conversion type character 'l' in format ../../../gdb-cvs/gdb/gdbserver/server.c:1566: warning: too many arguments for format This is due to the fact that MS printf doesn't support %lld, it uses its own %I64d which gcc already knows about. The attached patch changes that. OK for apply? gdb/gdbserver/ * server.c (handle_query): For windows, use %I64d instead of %lld in the sprintf format string. -- Ozkan --0015174c0ddc17ce02048b86cf32 Content-Type: application/octet-stream; name="g2.diff" Content-Disposition: attachment; filename="g2.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gbpgrzko0 Content-length: 1298 Z2RiL2dkYnNlcnZlci8KCgkqIHNlcnZlci5jIChoYW5kbGVfcXVlcnkpOiBG b3Igd2luZG93cywgdXNlICVJNjRkIGluc3RlYWQgb2YgJWxsZCBpbgoJdGhl IHNwcmludGYgZm9ybWF0IHN0cmluZy4KCkluZGV4OiBnZGIvZ2Ric2VydmVy L3NlcnZlci5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9j dnMvc3JjL3NyYy9nZGIvZ2Ric2VydmVyL3NlcnZlci5jLHYKcmV0cmlldmlu ZyByZXZpc2lvbiAxLjEyNQpkaWZmIC11IC1wIC1yMS4xMjUgc2VydmVyLmMK LS0tIGdkYi9nZGJzZXJ2ZXIvc2VydmVyLmMJNyBKdWwgMjAxMCAxNjoxNDow NCAtMDAwMAkxLjEyNQorKysgZ2RiL2dkYnNlcnZlci9zZXJ2ZXIuYwkxNiBK dWwgMjAxMCAyMDowNTo1MSAtMDAwMApAQCAtMTUzOSw3ICsxNTM5LDExIEBA IGhhbmRsZV9xdWVyeSAoY2hhciAqb3duX2J1ZiwgaW50IHBhY2tldF8KIAog ICAgICAgaWYgKGVyciA9PSAwKQogCXsKKyNpZmRlZiBfV0lOMzIKKwkgIHNw cmludGYgKG93bl9idWYsICIlSTY0ZCIsIGFkZHJlc3MpOworI2Vsc2UKIAkg IHNwcmludGYgKG93bl9idWYsICIlbGx4IiwgYWRkcmVzcyk7CisjZW5kaWYK IAkgIHJldHVybjsKIAl9CiAgICAgICBlbHNlIGlmIChlcnIgPiAwKQpAQCAt MTU2Myw3ICsxNTY3LDExIEBAIGhhbmRsZV9xdWVyeSAoY2hhciAqb3duX2J1 ZiwgaW50IHBhY2tldF8KICAgICAgIG4gPSAoKnRoZV90YXJnZXQtPmdldF90 aWJfYWRkcmVzcykgKHB0aWQsICZ0bGIpOwogICAgICAgaWYgKG4gPT0gMSkK IAl7CisjaWZkZWYgX1dJTjMyCisJICBzcHJpbnRmIChvd25fYnVmLCAiJUk2 NGQiLCB0bGIpOworI2Vsc2UKIAkgIHNwcmludGYgKG93bl9idWYsICIlbGx4 IiwgdGxiKTsKKyNlbmRpZgogCSAgcmV0dXJuOwogCX0KICAgICAgIGVsc2Ug aWYgKG4gPT0gMCkK --0015174c0ddc17ce02048b86cf32--