From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-74376-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26034 invoked by alias); 17 Jul 2010 21:05:42 -0000
Received: (qmail 26021 invoked by uid 22791); 17 Jul 2010 21:05:41 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,TW_CP
X-Spam-Check-By: sourceware.org
Received: from mail-ew0-f41.google.com (HELO mail-ew0-f41.google.com) (209.85.215.41)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 17 Jul 2010 21:05:37 +0000
Received: by ewy28 with SMTP id 28so1182366ewy.0        for <gdb-patches@sourceware.org>; Sat, 17 Jul 2010 14:05:35 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.213.28.141 with SMTP id m13mr2684902ebc.25.1279400734928; Sat, 	17 Jul 2010 14:05:34 -0700 (PDT)
Received: by 10.213.11.1 with HTTP; Sat, 17 Jul 2010 14:05:34 -0700 (PDT)
In-Reply-To: <m2mxtpyga7.fsf@igel.home>
References: <AANLkTilqLsYAUtXVYK-DL-uDFyKVbsxEz2CmJyJoese7@mail.gmail.com>	<AANLkTin3ZPiABX38XiwWx4c88Uj8usAv28IwUHChYLJI@mail.gmail.com>	<AANLkTilx-ZW3cEZEbBn__kZDTHxk3IWEBPFoooGtRBy_@mail.gmail.com>	<201007171447.38746.vapier@gentoo.org>	<AANLkTilD-biSeZN783Wo8IOiim2d1cb35Mbi4s5v8LiX@mail.gmail.com>	<m2mxtpyga7.fsf@igel.home>
Date: Sat, 17 Jul 2010 21:05:00 -0000
Message-ID: <AANLkTilw5fcwt_oNtMkxYz0rip0_s11fceKjx1WJNvwO@mail.gmail.com>
Subject: Re: [PATCH] [Windows] fix format string for 64 bit var in gdbserver
From: Ozkan Sezer <sezeroz@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Mike Frysinger <vapier@gentoo.org>, gdb-patches@sourceware.org, 	Tom Tromey <tromey@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-07/txt/msg00267.txt.bz2

On Sun, Jul 18, 2010 at 12:01 AM, Andreas Schwab <schwab@linux-m68k.org> wr=
ote:
> Ozkan Sezer <sezeroz@gmail.com> writes:
>
>> Index: server.c
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> RCS file: /cvs/src/src/gdb/gdbserver/server.c,v
>> retrieving revision 1.125
>> diff -u -p -r1.125 server.c
>> --- server.c =A07 Jul 2010 16:14:04 -0000 =A0 =A0 =A0 1.125
>> +++ server.c =A017 Jul 2010 18:54:41 -0000
>> @@ -1539,7 +1539,7 @@ handle_query (char *own_buf, int packet_
>>
>> =A0 =A0 =A0 =A0if (err =3D=3D 0)
>> =A0 =A0 =A0 {
>> - =A0 =A0 =A0 sprintf (own_buf, "%llx", address);
>> + =A0 =A0 =A0 sprintf (own_buf, "%s", paddress(address));
>
> s/sprintf/strcpy/
>

Thanks for catching it, changing immediately to
strcpy (own_buf, paddress(address))

Still waiting for a review/comment on the fix for paddress() posted at
http://sourceware.org/ml/gdb-patches/2010-07/msg00254.html

> Andreas.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint =3D 58CA 54C7 6D53 942B 1756 =A001D3 44D5 214B 8276 4=
ED5
> "And now for something completely different."
>

--
Ozkan