From: "H.J. Lu" <hjl.tools@gmail.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>,
jan.kratochvil@redhat.com, Jon.Zhou@jdsu.com,
gdb-patches@sourceware.org
Subject: Re: [rfc] skip_ilp32_tests / skip_lp64_tests predicates (was: Re: support biarch gcore?)
Date: Fri, 09 Jul 2010 21:43:00 -0000 [thread overview]
Message-ID: <AANLkTimXTyNJEGFMmHNwa3vayD5TQej8TOY_gpal5ewX@mail.gmail.com> (raw)
In-Reply-To: <201007091548.o69FmNlk015436@d12av02.megacenter.de.ibm.com>
On Fri, Jul 9, 2010 at 8:48 AM, Ulrich Weigand <uweigand@de.ibm.com> wrote:
> H.J. Lu wrote:
>
>> Very good point. There are some arch specific tests which are either
>> 32bit or 64bit. Currently, we check target. It doesn't work -m32. We
>> need something like
>>
>> /* { dg-require-effective-target lp64 } */
>> /* { dg-require-effective-target ilp32 } */
>
> Right; I noticed this problem with one ppc64 test case as well.
>
> I've tried to add testsuite predicates skip_ilp32_tests and skip_lp64_tests
> modeled along the lines of the above GCC effective-target flags, and this
> helps with this ppc64 test case.
>
> Could you try whether you can use this to fix the i386/x86_64 tests?
>
> I'd appreciate any comments on the approach below!
>
> Bye,
> Ulrich
>
>
> ChangeLog:
>
> * lib/gdb.exp (skip_ilp32_tests): New procedure.
> (skip_lp64_tests): New procedure.
> * gdb.arch/ppc64-atomic-inst.exp: Use skip_lp64_tests to execute test
> only when building 64-bit executables. Do not hard-code -m64 option.
>
This syntax is strange. There are
--
if { ![istarget i?86-*-*] && ![istarget x86_64-*-* ] } {
verbose "Skipping x86 AVX tests."
return
}
...
if [istarget i?86-*-*] {
set nr_regs 8
} else {
set nr_regs 16
}
...
I am looking for something like is_ilp32/is_lp64.
--
H.J.
next prev parent reply other threads:[~2010-07-09 21:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201007062128.o66LSkNC032580@glazunov.sibelius.xs4all.nl>
2010-07-07 12:30 ` support biarch gcore? Ulrich Weigand
2010-07-08 2:35 ` Jon Zhou
2010-07-08 11:17 ` Ulrich Weigand
2010-07-08 4:47 ` H.J. Lu
2010-07-08 5:05 ` H.J. Lu
2010-07-08 11:15 ` Ulrich Weigand
2010-07-08 13:52 ` H.J. Lu
2010-07-09 15:48 ` [rfc] skip_ilp32_tests / skip_lp64_tests predicates (was: Re: support biarch gcore?) Ulrich Weigand
2010-07-09 15:56 ` H.J. Lu
2010-07-09 21:43 ` H.J. Lu [this message]
2010-07-09 22:33 ` H.J. Lu
2010-07-12 14:49 ` Ulrich Weigand
2010-07-21 22:45 ` support biarch gcore? Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimXTyNJEGFMmHNwa3vayD5TQej8TOY_gpal5ewX@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=Jon.Zhou@jdsu.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=mark.kettenis@xs4all.nl \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).