From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-74300-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2609 invoked by alias); 9 Jul 2010 21:43:18 -0000
Received: (qmail 2600 invoked by uid 22791); 9 Jul 2010 21:43:17 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE
X-Spam-Check-By: sourceware.org
Received: from mail-px0-f169.google.com (HELO mail-px0-f169.google.com) (209.85.212.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Jul 2010 21:43:13 +0000
Received: by pxi7 with SMTP id 7so284pxi.0        for <gdb-patches@sourceware.org>; Fri, 09 Jul 2010 14:43:11 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.142.125.20 with SMTP id x20mr299562wfc.9.1278711790924; Fri, 	09 Jul 2010 14:43:10 -0700 (PDT)
Received: by 10.142.226.18 with HTTP; Fri, 9 Jul 2010 14:43:10 -0700 (PDT)
In-Reply-To: <201007091548.o69FmNlk015436@d12av02.megacenter.de.ibm.com>
References: <AANLkTimQRQeRUPtRFiXuU7Z2RWfYItt07gOcZBeAYj9R@mail.gmail.com>	<201007091548.o69FmNlk015436@d12av02.megacenter.de.ibm.com>
Date: Fri, 09 Jul 2010 21:43:00 -0000
Message-ID: <AANLkTimXTyNJEGFMmHNwa3vayD5TQej8TOY_gpal5ewX@mail.gmail.com>
Subject: Re: [rfc] skip_ilp32_tests / skip_lp64_tests predicates (was: Re: 	support biarch gcore?)
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>, jan.kratochvil@redhat.com, Jon.Zhou@jdsu.com, 	gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-07/txt/msg00191.txt.bz2

On Fri, Jul 9, 2010 at 8:48 AM, Ulrich Weigand <uweigand@de.ibm.com> wrote:
> H.J. Lu wrote:
>
>> Very good point. There are some arch specific tests which are either
>> 32bit or 64bit. Currently, we check target. It doesn't work -m32. We
>> need something like
>>
>> /* { dg-require-effective-target lp64 } */
>> /* { dg-require-effective-target ilp32 } */
>
> Right; I noticed this problem with one ppc64 test case as well.
>
> I've tried to add testsuite predicates skip_ilp32_tests and skip_lp64_tes=
ts
> modeled along the lines of the above GCC effective-target flags, and this
> helps with this ppc64 test case.
>
> Could you try whether you can use this to fix the i386/x86_64 tests?
>
> I'd appreciate any comments on the approach below!
>
> Bye,
> Ulrich
>
>
> ChangeLog:
>
> =A0 =A0 =A0 =A0* lib/gdb.exp (skip_ilp32_tests): New procedure.
> =A0 =A0 =A0 =A0(skip_lp64_tests): New procedure.
> =A0 =A0 =A0 =A0* gdb.arch/ppc64-atomic-inst.exp: Use skip_lp64_tests to e=
xecute test
> =A0 =A0 =A0 =A0only when building 64-bit executables. =A0Do not hard-code=
 -m64 option.
>

This syntax is strange. There are

--
if { ![istarget i?86-*-*] && ![istarget x86_64-*-* ] } {
    verbose "Skipping x86 AVX tests."
    return
}
...
if [istarget i?86-*-*] {
    set nr_regs 8
} else {
    set nr_regs 16
}
...

I am looking for something like is_ilp32/is_lp64.


--=20
H.J.