From: Doug Evans <dje@google.com>
To: Kazu Hirata <kazu@codesourcery.com>
Cc: gdb-patches@sourceware.org, dan@codesourcery.com
Subject: Re: [patch] Add support for ARMv7M devices.
Date: Wed, 09 Jun 2010 22:29:00 -0000 [thread overview]
Message-ID: <AANLkTimhMcBRp7J6UGZEK9DCo03Ve3ECyZVoDVRj7Jy2@mail.gmail.com> (raw)
In-Reply-To: <20100609140312.291855664EF@henry1.codesourcery.com>
On Wed, Jun 9, 2010 at 7:03 AM, Kazu Hirata <kazu@codesourcery.com> wrote:
> Hi,
>
> Attached is a patch to add support for ARMv7M devices.
>
> The patch is bigger than it really is due to the signature change to
> arm_pc_is_thumb.
>
> Here are some highlights:
>
> - arm_pc_is_thumb always returns 1 if the target is an ARMv7M device.
> [...]
No objections for my part, but a nit, and not one that you necessarily
have to address.
Options "arm fallback-mode" and "arm force-mode" are confusing, at
least if you read their help string without digging into the
implementation.
IWBN if the help text specified that they do not apply if the mode can
be discerned from the h/w, and list the ways in which that is done.
In some sense it could be thought of as being obvious (why want
something different from what the h/w says?).
Maybe I'm being excessively pedantic on the use of the word "force".
next prev parent reply other threads:[~2010-06-09 22:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 14:03 Kazu Hirata
2010-06-09 22:29 ` Doug Evans [this message]
2010-06-09 23:04 ` Richard Earnshaw
2010-06-24 16:42 ` Daniel Jacobowitz
2010-06-24 20:04 ` Richard Earnshaw
2010-08-16 18:06 ` Daniel Jacobowitz
2010-08-17 9:00 ` Matthew Gretton-Dann
2010-08-24 15:56 ` Daniel Jacobowitz
2010-10-29 23:47 ` Jonathan Larmour
2010-11-01 3:40 ` Daniel Jacobowitz
2010-11-03 3:21 ` Jonathan Larmour
2010-11-03 13:17 ` Daniel Jacobowitz
2010-11-10 2:21 ` Jonathan Larmour
2010-06-10 8:56 ` Matthew Gretton-Dann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimhMcBRp7J6UGZEK9DCo03Ve3ECyZVoDVRj7Jy2@mail.gmail.com \
--to=dje@google.com \
--cc=dan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=kazu@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).