From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27607 invoked by alias); 9 Jun 2010 22:29:18 -0000 Received: (qmail 27598 invoked by uid 22791); 9 Jun 2010 22:29:18 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.35) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Jun 2010 22:29:13 +0000 Received: from kpbe16.cbf.corp.google.com (kpbe16.cbf.corp.google.com [172.25.105.80]) by smtp-out.google.com with ESMTP id o59MTANt028470 for ; Wed, 9 Jun 2010 15:29:10 -0700 Received: from pzk9 (pzk9.prod.google.com [10.243.19.137]) by kpbe16.cbf.corp.google.com with ESMTP id o59MT9O0002736 for ; Wed, 9 Jun 2010 15:29:09 -0700 Received: by pzk9 with SMTP id 9so85557pzk.3 for ; Wed, 09 Jun 2010 15:29:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.55.4 with SMTP id d4mr532237rva.243.1276122548787; Wed, 09 Jun 2010 15:29:08 -0700 (PDT) Received: by 10.141.125.8 with HTTP; Wed, 9 Jun 2010 15:29:08 -0700 (PDT) In-Reply-To: <20100609140312.291855664EF@henry1.codesourcery.com> References: <20100609140312.291855664EF@henry1.codesourcery.com> Date: Wed, 09 Jun 2010 22:29:00 -0000 Message-ID: Subject: Re: [patch] Add support for ARMv7M devices. From: Doug Evans To: Kazu Hirata Cc: gdb-patches@sourceware.org, dan@codesourcery.com Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00239.txt.bz2 On Wed, Jun 9, 2010 at 7:03 AM, Kazu Hirata wrote: > Hi, > > Attached is a patch to add support for ARMv7M devices. > > The patch is bigger than it really is due to the signature change to > arm_pc_is_thumb. > > Here are some highlights: > > - arm_pc_is_thumb always returns 1 if the target is an ARMv7M device. > [...] No objections for my part, but a nit, and not one that you necessarily have to address. Options "arm fallback-mode" and "arm force-mode" are confusing, at least if you read their help string without digging into the implementation. IWBN if the help text specified that they do not apply if the mode can be discerned from the h/w, and list the ways in which that is done. In some sense it could be thought of as being obvious (why want something different from what the h/w says?). Maybe I'm being excessively pedantic on the use of the word "force".