[patch] Call tui_resize_all() after a resize

[patch] Call tui_resize_all() after a resize

[Balazs Kezes]

Currently tui_resize_all is never called. This could be called from the
SIGWINCH handler but because the resize logic is a bit complex it is safer
to mark a global variable and call this function later. The marking in the
handler is already in the code.
The global variable is currently also marked in this tui_resize_all so this
patch removes it from there.

--
Balazs

Index: tui-io.c
===================================================================
RCS file: /cvs/src/src/gdb/tui/tui-io.c,v
retrieving revision 1.23
diff -c -p -r1.23 tui-io.c
*** tui-io.c	25 May 2010 15:48:44 -0000	1.23
--- tui-io.c	21 Jul 2010 20:34:54 -0000
*************** tui_handle_resize_during_io (unsigned in
*** 711,716 ****
--- 711,717 ----
  {
    if (tui_win_resized ())
      {
+       tui_resize_all ();
        tui_refresh_all_win ();
        dont_repeat ();
        tui_set_win_resized_to (FALSE);
Index: tui-win.c
===================================================================
RCS file: /cvs/src/src/gdb/tui/tui-win.c,v
retrieving revision 1.47
diff -c -p -r1.47 tui-win.c
*** tui-win.c	17 May 2010 22:21:43 -0000	1.47
--- tui-win.c	21 Jul 2010 20:43:22 -0000
*************** tui_resize_all (void)
*** 799,805 ****
  	      tui_win_list[win_type] = (struct tui_win_info *) NULL;
  	    }
  	}
-       tui_set_win_resized_to (TRUE);
        /* Turn keypad back on, unless focus is in the command
  	 window.  */
        if (win_with_focus != TUI_CMD_WIN)

Re: [patch] Call tui_resize_all() after a resize

[Pedro Alves]

On Wednesday 21 July 2010 21:53:01, Balazs Kezes wrote:
> Currently tui_resize_all is never called. This could be called from the
> SIGWINCH handler but because the resize logic is a bit complex it is safer
> to mark a global variable and call this function later. The marking in the
> handler is already in the code.
> The global variable is currently also marked in this tui_resize_all so this
> patch removes it from there.

Thanks, this version looks good.  I can apply it.  Can you write me a
change log entry for this?

> 
> --
> Balazs
> 
> Index: tui-io.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/tui/tui-io.c,v
> retrieving revision 1.23
> diff -c -p -r1.23 tui-io.c
> *** tui-io.c	25 May 2010 15:48:44 -0000	1.23
> --- tui-io.c	21 Jul 2010 20:34:54 -0000
> *************** tui_handle_resize_during_io (unsigned in
> *** 711,716 ****
> --- 711,717 ----
>   {
>     if (tui_win_resized ())
>       {
> +       tui_resize_all ();
>         tui_refresh_all_win ();
>         dont_repeat ();
>         tui_set_win_resized_to (FALSE);
> Index: tui-win.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/tui/tui-win.c,v
> retrieving revision 1.47
> diff -c -p -r1.47 tui-win.c
> *** tui-win.c	17 May 2010 22:21:43 -0000	1.47
> --- tui-win.c	21 Jul 2010 20:43:22 -0000
> *************** tui_resize_all (void)
> *** 799,805 ****
>   	      tui_win_list[win_type] = (struct tui_win_info *) NULL;
>   	    }
>   	}
> -       tui_set_win_resized_to (TRUE);
>         /* Turn keypad back on, unless focus is in the command
>   	 window.  */
>         if (win_with_focus != TUI_CMD_WIN)
> 

Re: [patch] Call tui_resize_all() after a resize

[Pedro Alves]

I've now applied this one.  Thanks.

-- 
Pedro Alves