From: Ozkan Sezer <sezeroz@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Mike Frysinger <vapier@gentoo.org>,
gdb-patches@sourceware.org, Tom Tromey <tromey@redhat.com>
Subject: Re: [PATCH] [Windows] fix format string for 64 bit var in gdbserver
Date: Tue, 20 Jul 2010 18:20:00 -0000 [thread overview]
Message-ID: <AANLkTinbqF6QWqIQztG1i11D2NQIyvyYOUSMHkjtpOlw@mail.gmail.com> (raw)
In-Reply-To: <AANLkTilw5fcwt_oNtMkxYz0rip0_s11fceKjx1WJNvwO@mail.gmail.com>
On Sun, Jul 18, 2010 at 12:05 AM, Ozkan Sezer <sezeroz@gmail.com> wrote:
> On Sun, Jul 18, 2010 at 12:01 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>> Ozkan Sezer <sezeroz@gmail.com> writes:
>>
>>> Index: server.c
>>> ===================================================================
>>> RCS file: /cvs/src/src/gdb/gdbserver/server.c,v
>>> retrieving revision 1.125
>>> diff -u -p -r1.125 server.c
>>> --- server.c 7 Jul 2010 16:14:04 -0000 1.125
>>> +++ server.c 17 Jul 2010 18:54:41 -0000
>>> @@ -1539,7 +1539,7 @@ handle_query (char *own_buf, int packet_
>>>
>>> if (err == 0)
>>> {
>>> - sprintf (own_buf, "%llx", address);
>>> + sprintf (own_buf, "%s", paddress(address));
>>
>> s/sprintf/strcpy/
>>
>
> Thanks for catching it, changing immediately to
> strcpy (own_buf, paddress(address))
>
> Still waiting for a review/comment on the fix for paddress() posted at
> http://sourceware.org/ml/gdb-patches/2010-07/msg00254.html
>
Applied with Andreas' suggestion integrated.
>> Andreas.
>>
>> --
>> Andreas Schwab, schwab@linux-m68k.org
>> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
>> "And now for something completely different."
>>
>
> --
> Ozkan
>
--
Ozkan
next prev parent reply other threads:[~2010-07-20 18:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-16 20:10 Ozkan Sezer
2010-07-17 9:40 ` Mike Frysinger
2010-07-17 9:42 ` Ozkan Sezer
2010-07-17 9:53 ` Ozkan Sezer
2010-07-17 18:50 ` Mike Frysinger
2010-07-17 18:59 ` Ozkan Sezer
2010-07-17 19:19 ` Mike Frysinger
2010-07-17 19:23 ` Ozkan Sezer
2010-07-17 21:01 ` Andreas Schwab
2010-07-17 21:05 ` Ozkan Sezer
2010-07-20 18:20 ` Ozkan Sezer [this message]
2010-07-17 12:29 ` Mark Kettenis
2010-07-17 18:49 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinbqF6QWqIQztG1i11D2NQIyvyYOUSMHkjtpOlw@mail.gmail.com \
--to=sezeroz@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=schwab@linux-m68k.org \
--cc=tromey@redhat.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).