public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: sami wagiaalla <swagiaal@redhat.com>
Cc: gdb-patches@sourceware.org,
	       Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Subject: Re: [patch] create and use symbol_set_language
Date: Wed, 04 Aug 2010 22:01:00 -0000	[thread overview]
Message-ID: <AANLkTinct9EMvw31f1dm9D2ZJWFHv3U=o288VLUV8bCk@mail.gmail.com> (raw)
In-Reply-To: <AANLkTimB2ME5zDOtHZzw0eRm+FX1KkQv6c3QiYE2oNqL@mail.gmail.com>

On Wed, Aug 4, 2010 at 2:56 PM, Doug Evans <dje@google.com> wrote:
> - after applying the patch, grepping for SYMBOL_INIT still has a few
> hits that need to be addressed:
>
> gdb$ grep SYMBOL_INIT *.[ch]
> buildsym.c:#include "demangle.h"                /* Needed by
> SYMBOL_INIT_DEMANGLED_NAME.  */
> symtab.h:   the SYMBOL_INIT_LANGUAGE_SPECIFIC, SYMBOL_DEMANGLED_NAME, etc.

Blech.  Removing SYMBOL_INIT_DEMANGLED_NAME reference is orthogonal to
this patch.

I was able to compile buildsym.o by removing the entire line.

  reply	other threads:[~2010-08-04 22:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-03 14:56 sami wagiaalla
2010-08-04  7:27 ` Pierre Muller
2010-08-05 15:36   ` sami wagiaalla
     [not found] ` <6308127460174723176@unknownmsgid>
2010-08-04 21:56   ` Doug Evans
2010-08-04 22:01     ` Doug Evans [this message]
2010-08-05 19:05     ` sami wagiaalla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTinct9EMvw31f1dm9D2ZJWFHv3U=o288VLUV8bCk@mail.gmail.com' \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pierre.muller@ics-cnrs.unistra.fr \
    --cc=swagiaal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).