From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24112 invoked by alias); 4 Aug 2010 22:01:48 -0000 Received: (qmail 24044 invoked by uid 22791); 4 Aug 2010 22:01:47 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KAM_STOCKGEN,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.35) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 04 Aug 2010 22:01:43 +0000 Received: from wpaz33.hot.corp.google.com (wpaz33.hot.corp.google.com [172.24.198.97]) by smtp-out.google.com with ESMTP id o74M1ePP015131 for ; Wed, 4 Aug 2010 15:01:40 -0700 Received: from vws13 (vws13.prod.google.com [10.241.21.141]) by wpaz33.hot.corp.google.com with ESMTP id o74M1ciI016953 for ; Wed, 4 Aug 2010 15:01:39 -0700 Received: by vws13 with SMTP id 13so4790490vws.20 for ; Wed, 04 Aug 2010 15:01:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.158.9 with SMTP id d9mr6597750vcx.173.1280959297213; Wed, 04 Aug 2010 15:01:37 -0700 (PDT) Received: by 10.220.176.2 with HTTP; Wed, 4 Aug 2010 15:01:37 -0700 (PDT) In-Reply-To: References: <4C582E25.1030505@redhat.com> <6308127460174723176@unknownmsgid> Date: Wed, 04 Aug 2010 22:01:00 -0000 Message-ID: Subject: Re: [patch] create and use symbol_set_language From: Doug Evans To: sami wagiaalla Cc: gdb-patches@sourceware.org, Pierre Muller Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00022.txt.bz2 On Wed, Aug 4, 2010 at 2:56 PM, Doug Evans wrote: > - after applying the patch, grepping for SYMBOL_INIT still has a few > hits that need to be addressed: > > gdb$ grep SYMBOL_INIT *.[ch] > buildsym.c:#include "demangle.h" =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0/* Needed= by > SYMBOL_INIT_DEMANGLED_NAME. =A0*/ > symtab.h: =A0 the SYMBOL_INIT_LANGUAGE_SPECIFIC, SYMBOL_DEMANGLED_NAME, e= tc. Blech. Removing SYMBOL_INIT_DEMANGLED_NAME reference is orthogonal to this patch. I was able to compile buildsym.o by removing the entire line.