From: Doug Evans <dje@google.com>
To: tromey@redhat.com
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Add support for gdb.PYTHONDIR as $gdb_datadir/python.
Date: Thu, 24 Jun 2010 19:06:00 -0000 [thread overview]
Message-ID: <AANLkTinoNSv5sdjlAGU7aa0wceEVIs9tma2TP9q7Pp2u@mail.gmail.com> (raw)
In-Reply-To: <m3ocf06ykd.fsf@fleche.redhat.com>
On Thu, Jun 24, 2010 at 12:05 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>
> Doug> The execfile of __init__.py feels odd. I haven't seen it done
> Doug> elsewhere and I wonder if it's needed.
> Doug> [I know python has __init__.py, I just don't know if we have to
> Doug> *explicitly* exec it.]
>
> Normally, no, but in this case we do because the "gdb" module is created
> in C code, not via an import.
If a comment to that effect is added to the code, then I'm happy with
the patch. :-)
next prev parent reply other threads:[~2010-06-24 19:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 18:19 Joel Brobecker
2010-06-24 18:39 ` Doug Evans
2010-06-24 19:06 ` Tom Tromey
2010-06-24 19:06 ` Doug Evans [this message]
2010-06-24 19:14 ` Tom Tromey
2010-06-24 22:53 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinoNSv5sdjlAGU7aa0wceEVIs9tma2TP9q7Pp2u@mail.gmail.com \
--to=dje@google.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).