From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12939 invoked by alias); 24 Jun 2010 19:06:59 -0000 Received: (qmail 12931 invoked by uid 22791); 24 Jun 2010 19:06:59 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Jun 2010 19:06:55 +0000 Received: from wpaz5.hot.corp.google.com (wpaz5.hot.corp.google.com [172.24.198.69]) by smtp-out.google.com with ESMTP id o5OJ6rAT004406 for ; Thu, 24 Jun 2010 12:06:53 -0700 Received: from vws19 (vws19.prod.google.com [10.241.21.147]) by wpaz5.hot.corp.google.com with ESMTP id o5OJ6jNU021150 for ; Thu, 24 Jun 2010 12:06:52 -0700 Received: by vws19 with SMTP id 19so2225338vws.34 for ; Thu, 24 Jun 2010 12:06:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.161.201 with SMTP id s9mr1073101vcx.137.1277406412106; Thu, 24 Jun 2010 12:06:52 -0700 (PDT) Received: by 10.220.201.66 with HTTP; Thu, 24 Jun 2010 12:06:51 -0700 (PDT) In-Reply-To: References: <1277403507-29213-1-git-send-email-brobecker@adacore.com> Date: Thu, 24 Jun 2010 19:06:00 -0000 Message-ID: Subject: Re: [PATCH] Add support for gdb.PYTHONDIR as $gdb_datadir/python. From: Doug Evans To: tromey@redhat.com Cc: Joel Brobecker , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00552.txt.bz2 On Thu, Jun 24, 2010 at 12:05 PM, Tom Tromey wrote: >>>>>> "Doug" =3D=3D Doug Evans writes: > > Doug> The execfile of __init__.py feels odd. =A0I haven't seen it done > Doug> elsewhere and I wonder if it's needed. > Doug> [I know python has __init__.py, I just don't know if we have to > Doug> *explicitly* exec it.] > > Normally, no, but in this case we do because the "gdb" module is created > in C code, not via an import. If a comment to that effect is added to the code, then I'm happy with the patch. :-)