From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23005 invoked by alias); 9 Jan 2011 20:32:01 -0000 Received: (qmail 22997 invoked by uid 22791); 9 Jan 2011 20:32:00 -0000 X-SWARE-Spam-Status: No, hits=-2.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 09 Jan 2011 20:31:52 +0000 Received: from wpaz21.hot.corp.google.com (wpaz21.hot.corp.google.com [172.24.198.85]) by smtp-out.google.com with ESMTP id p09KVnM4005261 for ; Sun, 9 Jan 2011 12:31:49 -0800 Received: from vws9 (vws9.prod.google.com [10.241.21.137]) by wpaz21.hot.corp.google.com with ESMTP id p09KVl18025126 for ; Sun, 9 Jan 2011 12:31:48 -0800 Received: by vws9 with SMTP id 9so7845879vws.27 for ; Sun, 09 Jan 2011 12:31:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.220.188.140 with SMTP id da12mr3367153vcb.151.1294605107480; Sun, 09 Jan 2011 12:31:47 -0800 (PST) Received: by 10.220.118.80 with HTTP; Sun, 9 Jan 2011 12:31:47 -0800 (PST) In-Reply-To: References: Date: Sun, 09 Jan 2011 20:32:00 -0000 Message-ID: Subject: Re: [patch] Add an evaluation function hook to Python breakpoints. From: Doug Evans To: pmuldoon@redhat.com Cc: Tom Tromey , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00180.txt.bz2 On Wed, Jan 5, 2011 at 12:23 PM, Phil Muldoon wrote: > Yeah ultimately this was going to be series of patches (the first being > this, the ability to write conditions entirely within Python), but the > whole-story (from these threads) has probably shown we need to think > about the solution in totality, not incrementally. I don't mind the incremental approach (fwiw). There is value in having the stop condition being computed in python. [As long as we have a clear approach to handling old-style condition (e.g. break foo if bar) vs new python-style condition.] It breaks down, I think, in using it for some of the things we've discussed, but that doesn't diminish the utility of stop_p (or however it's named). One thing that may require a non-incremental approach is what kind of class hierarchy (if any) we want for breakpoints.