From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 541 invoked by alias); 21 Feb 2011 08:18:25 -0000 Received: (qmail 533 invoked by uid 22791); 21 Feb 2011 08:18:24 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_RG X-Spam-Check-By: sourceware.org Received: from mail-gx0-f182.google.com (HELO mail-gx0-f182.google.com) (209.85.161.182) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Feb 2011 08:18:19 +0000 Received: by gxk7 with SMTP id 7so458039gxk.13 for ; Mon, 21 Feb 2011 00:18:18 -0800 (PST) Received: by 10.150.144.16 with SMTP id r16mr1371976ybd.14.1298276298084; Mon, 21 Feb 2011 00:18:18 -0800 (PST) MIME-Version: 1.0 Received: by 10.147.125.2 with HTTP; Mon, 21 Feb 2011 00:17:58 -0800 (PST) In-Reply-To: References: From: Hui Zhu Date: Mon, 21 Feb 2011 08:18:00 -0000 Message-ID: Subject: Re: [PATCH] tracepoint: add new trace command "printf"[1] gdbserver To: Tom Tromey Cc: gdb-patches Content-Type: multipart/mixed; boundary=000e0cd310aa9150d3049cc6811b X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00527.txt.bz2 --000e0cd310aa9150d3049cc6811b Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1278 On Thu, Feb 17, 2011 at 16:16, Hui Zhu wrote: > On Sat, Feb 12, 2011 at 05:31, Tom Tromey wrote: >>>>>>> ">" =3D=3D Hui Zhu writes: >> >>>> To make the gdbserver support %s. >> >> Oops, I missed this when reviewing your earlier patch. >> Sorry about that. >> >>>> +int >>>> +tp_printf(const char *format, ...) >> >> Space before open paren. >> >>>> + =A0va_end(ap); >> >> Likewise. >> >>>> + =A0 =A0 =A0 =A0argv =3D (void *)(unsigned long)top; >> >> Spacing. >> >> There are several more spacing bugs, please fix them all. >> >> I didn't go read the other patch to try to deduce the format of the >> printf opcode to see if it all makes sense. =A0Documentation would help. >> >> Tom >> > > Hi Tom, > > I make a new patch according to your comments. > > Thanks, > Hui > > 2011-02-17 =A0Hui Zhu =A0 > > =A0 =A0 =A0 =A0* tracepoint.c (gdb_agent_op): Add gdb_agent_op_printf. > =A0 =A0 =A0 =A0(gdb_agent_op_names): Add "printf". > =A0 =A0 =A0 =A0(tp_printf): New function. > =A0 =A0 =A0 =A0(eval_agent_expr): Handle gdb_agent_op_printf. > Checked in. Thanks, Hui 2011-02-21 Hui Zhu * tracepoint.c (tp_printf): New function. (eval_agent_expr): Handle gdb_agent_op_printf. --000e0cd310aa9150d3049cc6811b Content-Type: text/plain; charset=US-ASCII; name="tp_print_server.txt" Content-Disposition: attachment; filename="tp_print_server.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gkf45feu1 Content-length: 2095 LS0tCiBnZGJzZXJ2ZXIvdHJhY2Vwb2ludC5jIHwgICA0NCArKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNo YW5nZWQsIDQ0IGluc2VydGlvbnMoKykKCi0tLSBhL2dkYnNlcnZlci90cmFj ZXBvaW50LmMKKysrIGIvZ2Ric2VydmVyL3RyYWNlcG9pbnQuYwpAQCAtNDIx NCw2ICs0MjE0LDE2IEBAIGdkYl9hZ2VudF9vcF9uYW1lIChpbnQgb3ApCiAg IHJldHVybiBnZGJfYWdlbnRfb3BfbmFtZXNbb3BdOwogfQogCitpbnQKK3Rw X3ByaW50ZiAoY29uc3QgY2hhciAqZm9ybWF0LCAuLi4pCit7CisgIHZhX2xp c3QgYXA7CisgIHZhX3N0YXJ0IChhcCwgZm9ybWF0KTsKKyAgdnByaW50ZiAo Zm9ybWF0LCBhcCk7CisgIHZhX2VuZCAoYXApOworICByZXR1cm4gMDsKK30K KwogLyogVGhlIGFnZW50IGV4cHJlc3Npb24gZXZhbHVhdG9yLCBhcyBzcGVj aWZpZWQgYnkgdGhlIEdEQiBkb2NzLiBJdAogICAgcmV0dXJucyAwIGlmIGV2 ZXJ5dGhpbmcgd2VudCBPSywgYW5kIGEgbm9uemVybyBlcnJvciBjb2RlCiAg ICBvdGhlcndpc2UuICAqLwpAQCAtNDU3Myw2ICs0NTgzLDQwIEBAIGV2YWxf YWdlbnRfZXhwciAoc3RydWN0IHRyYWNlcG9pbnRfaGl0X2MKIAkgIGFnZW50 X3Rzdl9yZWFkICh0ZnJhbWUsIGFyZyk7CiAJICBicmVhazsKIAorCWNhc2Ug Z2RiX2FnZW50X29wX3ByaW50ZjoKKwkgIHsKKwkgICAgdm9pZCAqYXJndjsK KwkgICAgYXJnID0gYWV4cHItPmJ5dGVzW3BjKytdOworCSAgICBhcmd2ID0g KHZvaWQgKikgKHVuc2lnbmVkIGxvbmcpIHRvcDsKKwkgICAgaWYgKC0tc3Ag Pj0gMCkKKwkgICAgICB0b3AgPSBzdGFja1tzcF07CisKKwkgICAgaWYgKGFy ZykKKwkgICAgICB7CisJCWlmIChzdHJzdHIgKChjaGFyICopIChhZXhwci0+ Ynl0ZXMgKyBwYyksICIlcyIpKQorCQkgIHsKKwkJICAgIGludAkJCWk7CisJ CSAgICB1bnNpZ25lZCBjaGFyCWJ1ZlsxMDBdOworCisJCSAgICBmb3IgKGkg PSAwOyBpIDwgMTAwOyBpKyspCisJCSAgICAgIHsKKwkJCWFnZW50X21lbV9y ZWFkICh0ZnJhbWUsIGJ1ZiArIGksCisJCQkJCShDT1JFX0FERFIpICgodW5z aWduZWQgbG9uZylhcmd2ICsgaSksCisJCQkJCTEpOworCQkJaWYgKCFidWZb aV0pCisJCQkgIGJyZWFrOworCQkgICAgICB9CisJCSAgICB0cF9wcmludGYg KChjaGFyICopIChhZXhwci0+Ynl0ZXMgKyBwYyksIGJ1Zik7CisJCSAgfQor CQllbHNlCisJICAgICAgICAgIHRwX3ByaW50ZiAoKGNoYXIgKikgKGFleHBy LT5ieXRlcyArIHBjKSwgYXJndik7CisJICAgICAgfQorCSAgICBlbHNlCisJ ICAgICAgdHBfcHJpbnRmICgoY2hhciAqKSAoYWV4cHItPmJ5dGVzICsgcGMp KTsKKwkgICAgcGMgKz0gc3RybGVuICgoY2hhciAqKSBhZXhwci0+Ynl0ZXMg KyBwYykgKyAxOworCSAgfQorCSAgYnJlYWs7CisKIAkgIC8qIEdEQiBuZXZl ciAoY3VycmVudGx5KSBnZW5lcmF0ZXMgYW55IG9mIHRoZXNlIG9wcy4gICov CiAJY2FzZSBnZGJfYWdlbnRfb3BfZmxvYXQ6CiAJY2FzZSBnZGJfYWdlbnRf b3BfcmVmX2Zsb2F0Ogo= --000e0cd310aa9150d3049cc6811b--