From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9618 invoked by alias); 8 Dec 2014 17:50:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9578 invoked by uid 89); 8 Dec 2014 17:50:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail.datasphere.ch Received: from mail.datasphere.ch (HELO mail.datasphere.ch) (195.70.3.149) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 08 Dec 2014 17:50:09 +0000 Received: from dataspheresrv01.datasphere.ch (ForestDnsZones.datasphere.ch [195.70.3.151]) by mail.datasphere.ch (8.14.8/8.14.8) with ESMTP id sB8Hne2R032217; Mon, 8 Dec 2014 18:49:43 +0100 Content-class: urn:content-classes:message Subject: RE: [PATCH] Fix build with Python 3.4 (PR python/16784) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Date: Mon, 08 Dec 2014 17:50:00 -0000 Message-ID: In-Reply-To: <5485D02D.1050202@ericsson.com> References: <1417009634-2356-1-git-send-email-simon.marchi@ericsson.com> <5480A49F.1010904@redhat.com> <5482287D.9030500@ericsson.com> <87h9x9d7nf.fsf@redhat.com> <54823AA4.7080902@redhat.com> <5485D02D.1050202@ericsson.com> From: "Patrick Monnerat" To: "Simon Marchi" , "Keith Seitz" Cc: X-SW-Source: 2014-12/txt/msg00180.txt.bz2 Simon Marchi wrote: >>>>>> I changed the signature of deprecated_readline_hook. I would've=20 >>>>>> changed any user of it, but it seems like nothing is using it, >>>>> >>>>> You'd probably find it in the insight/gdbtk code. >>>> >>>> Is this something that I need to update, or insight is not maintained anymore? >>> >>> Insight is maintained by Keith Seitz (Cc'ed in this message). My=20 >>> first reaction is that it would be good if you updated it. >>=20 >> As reported elsewhere, Insight is a bit in limbo right now as I try to=20 >> figure out how to best deal with gdb moving to git (and start my own=20 >> migration). >>=20 >> There is a temporary repository set up by the Fedora packaging=20 >> maintainer, Patrick Monnerat. I believe this was also referenced earlier. >>=20 >> IMO, I would take that as the official repository for the time being. >>=20 >> You can update it, or I can. It's not a huge deal; just let me know. > (CCing Patrick Monnerat, see above for context) > Here is the corresponding change in Insight (as expected very simple): > https://github.com/simark/insight/commit/47810ab5fcbd528dc6b4422c93b5eca ccf2e4fe8 > Since binutils-gdb is used as a submodule in the insight repo, this change should only be merged when the submodule is updated and includes the patch that changes the signature. Thanks for the info and the patch. However I cannot find yet any commit "xyz" in the official repo where the deprecated_readline_hook signature is changed. I regularly check this kind of troubles against the master@official binutils-gdb repository (~twice a week: the last time was this morning) and I will react as soon as the compilation fails. Regards, Patrick