[PATCH v1 1/1] Fix pointer conversion.

[PATCH v1 1/1] Fix pointer conversion.

[Walfred Tedeschi]

Pointer conversion from and to "long" is not correct. Issue was
verified while building gdb for windows under MinGW.

2013-12-17  Walfred Tedeschi  <walfred.tedeschi@intel.com>

bfd/
	* peXXigen.c (pe_print_rsrc): Use bfd_hostptr_t instead of long.

---
 bfd/peXXigen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bfd/peXXigen.c b/bfd/peXXigen.c
index b720668..cca2b46 100644
--- a/bfd/peXXigen.c
+++ b/bfd/peXXigen.c
@@ -2182,7 +2182,7 @@ pe_print_rsrc (bfd * abfd, void * vfile)
 	{
 	  /* Align data before continuing.  */
 	  int align = (1 << section->alignment_power) - 1;
-	  data = (bfd_byte *) (((long) (data + align)) & ~ align);
+	  data = (bfd_byte *) (((bfd_hostptr_t) (data + align)) & ~ align);
 	  rva_bias += data - datastart;
 
 	  /* For reasons that are unclear .rsrc sections are sometimes created
-- 
1.8.3.2

Re: [PATCH v1 1/1] Fix pointer conversion.

[Pedro Alves]

Hi Walfred,

bfd is maintained by the binutils folks.  Please
send the patch their way.

Thanks.

-- 
Pedro Alves

RE: [PATCH v1 1/1] Fix pointer conversion.

[Tedeschi, Walfred]

Ok! Pedro sending to the other list.

Thanks a lot,

Regards,
-Fred
-----Original Message-----
From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Pedro Alves
Sent: Tuesday, December 17, 2013 4:23 PM
To: Tedeschi, Walfred
Cc: xdje42@gmail.com; gdb-patches@sourceware.org
Subject: Re: [PATCH v1 1/1] Fix pointer conversion.

Hi Walfred,

bfd is maintained by the binutils folks.  Please send the patch their way.

Thanks.

--
Pedro Alves
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052