From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112997 invoked by alias); 2 Mar 2016 10:03:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112975 invoked by uid 89); 2 Mar 2016 10:03:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_50,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=H*c:iso-8859-2, brobeckeradacorecom, brobecker@adacore.com, Advanced X-HELO: mga02.intel.com Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 02 Mar 2016 10:03:01 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 02 Mar 2016 02:02:59 -0800 X-ExtLoop1: 1 Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga001.fm.intel.com with ESMTP; 02 Mar 2016 02:02:58 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.87]) by irsmsx105.ger.corp.intel.com ([169.254.7.237]) with mapi id 14.03.0248.002; Wed, 2 Mar 2016 10:02:55 +0000 From: "Tedeschi, Walfred" To: Marcin Koscielnicki , "palves@redhat.com" , "eliz@gnu.org" , "brobecker@adacore.com" CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 0/2] Split tdesc_(amd64|i386)_mpx into tdesc(amd64|i386)_mpx_* and tdesc(amd64|i386)_avx_mpx_* Date: Wed, 02 Mar 2016 10:03:00 -0000 Message-ID: References: <1456130945-25045-1-git-send-email-walfred.tedeschi@intel.com> <56CF5430.2000502@0x04.net> In-Reply-To: <56CF5430.2000502@0x04.net> Content-Type: text/plain; charset="iso-8859-2" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00024.txt.bz2 -----Original Message----- From: Marcin Ko=B6cielnicki [mailto:koriakin@0x04.net]=20 Sent: Thursday, February 25, 2016 8:21 PM To: Tedeschi, Walfred; palves@redhat.com; eliz@gnu.org; brobecker@adacore.c= om Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/2] Split tdesc_(amd64|i386)_mpx into tdesc(amd64|i386= )_mpx_* and tdesc(amd64|i386)_avx_mpx_* On 22/02/16 09:49, Walfred Tedeschi wrote: > CPU features can occur in any combination. The current assumption that=20 > feature "A" implies in feature "B" does not necessarily hold. > > This patch series construct an additional combination of the Intel(R)=20 > Memory Protection Extensions (MPX) with Intel(R) Advanced Vector=20 > Extensions (AVX). > > Starting from the current implementation that has MPX combined with AVX. > A new target description having only MPX will be created using a two=20 > step approach as described below: > > First step: > Mirror (i386|amd64)mpx target descriptors onto (i386|amd64)-avx-mpx=20 > ones. > > Add a redundant target description for the MPX and AVX case using a=20 > combined feature name to reflect that, i.e. avx-mpx. A new flag 2is=20 > also added to address MPX case without AVX. > > > Second step: > Refactor (i386|amd64)-mpx target descriptors. > > AVX feature is removed from the set of files that described MPX alone=20 > feature. Present on GDB code previous to this patch. > > > Tests were done with hardware having MPX and AVX as is. > For MPX standing alone tests were done forcing the XCR0 bits. > > FYI, I've just refactored a few things in x86 tdescs, to properly pass them= into the IPA - you will have a conflict with my commit ae91f6253926e4dadeb= cae90772f4f5a5bd06056. You will have to add an X86_TDESC_AVX_MPX enum valu= e, emit it in gdbserver when you're using one of the new tdescs, and recogn= ize it in the IPAs. Sorry for the inconvenience. Marcin, Thanks a lot for the heads up! I looks like it is time to refactor the tdesc_selection, or? I suppose I ha= ve seen this code now 5 times. May I do it and send as a separated patch? Thanks and regards, -Fred Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928