* [pushed 8.0-branch] [Bug server/22137] gdbserver crashes on hosts with pkru register @ 2017-10-16 8:30 Tedeschi, Walfred 2017-10-16 12:49 ` Pedro Alves 0 siblings, 1 reply; 6+ messages in thread From: Tedeschi, Walfred @ 2017-10-16 8:30 UTC (permalink / raw) To: gdb-patches, Pedro Alves (palves@redhat.com) > -----Original Message----- > From: palves at redhat dot com [mailto:sourceware- > bugzilla@sourceware.org] > Sent: Friday, October 13, 2017 11:06 AM > To: Tedeschi, Walfred <walfred.tedeschi@intel.com> > Subject: [Bug server/22137] gdbserver crashes on hosts with pkru register > > https://sourceware.org/bugzilla/show_bug.cgi?id=22137 > > Pedro Alves <palves at redhat dot com> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > Status|UNCONFIRMED |NEW > Last reconfirmed| |2017-10-13 > Ever confirmed|0 |1 > > --- Comment #3 from Pedro Alves <palves at redhat dot com> --- > > Bug is confirmed. > > Updating status then. Waldfred, if your account doesn't let you do that > yourself, please let me know. > > And, I believe the bug is fixed in both master and 8.0 branch, right? > Hello Pedro, I have pushed this one to 8.0 branch. In Master it does not apply anymore. I also couldn't compile master: ../../../binutils-gdb/gdb/probe.c: In function \u2018void parse_probes_in_pspace(const probe_ops*, program_space*, const char*, const char*, const char*, std::vector<symtab_and_line>*)\u2019: ../../../binutils-gdb/gdb/probe.c:68:12: error: types may not be defined in a for-range-declaration [-Werror] for (struct probe *probe : probes) ^~~~~~ ../../../binutils-gdb/gdb/probe.c: In function \u2018VEC_probe_p* find_probes_in_objfile(objfile*, const char*, const char*)\u2019: ../../../binutils-gdb/gdb/probe.c:213:8: error: types may not be defined in a for-range-declaration [-Werror] for (struct probe *probe : probes) ^~~~~~ Are you aware of it? Thanks and regards, /Fred > -- > You are receiving this mail because: > You are on the CC list for the bug. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [pushed 8.0-branch] [Bug server/22137] gdbserver crashes on hosts with pkru register 2017-10-16 8:30 [pushed 8.0-branch] [Bug server/22137] gdbserver crashes on hosts with pkru register Tedeschi, Walfred @ 2017-10-16 12:49 ` Pedro Alves 2017-10-16 13:20 ` Tedeschi, Walfred 0 siblings, 1 reply; 6+ messages in thread From: Pedro Alves @ 2017-10-16 12:49 UTC (permalink / raw) To: Tedeschi, Walfred, gdb-patches On 10/16/2017 09:30 AM, Tedeschi, Walfred wrote: >> -----Original Message----- >> From: palves at redhat dot com [mailto:sourceware- >> bugzilla@sourceware.org] >> Sent: Friday, October 13, 2017 11:06 AM >> To: Tedeschi, Walfred <walfred.tedeschi@intel.com> >> Subject: [Bug server/22137] gdbserver crashes on hosts with pkru register >> >> https://sourceware.org/bugzilla/show_bug.cgi?id=22137 >> >> Pedro Alves <palves at redhat dot com> changed: >> >> What |Removed |Added >> ---------------------------------------------------------------------------- >> Status|UNCONFIRMED |NEW >> Last reconfirmed| |2017-10-13 >> Ever confirmed|0 |1 >> >> --- Comment #3 from Pedro Alves <palves at redhat dot com> --- >>> Bug is confirmed. >> >> Updating status then. Waldfred, if your account doesn't let you do that >> yourself, please let me know. >> >> And, I believe the bug is fixed in both master and 8.0 branch, right? >> > Hello Pedro, > > I have pushed this one to 8.0 branch. In Master it does not apply anymore. Yes, you had fixed it in commit 1b7fa39ed9678fded7264636c1e5cc14c6d6ebc6 Author: Walfred Tedeschi <walfred.tedeschi@intel.com> AuthorDate: Wed Sep 20 15:24:47 2017 +0200 [OBV] amd64-features-makefile: add missing backslash. In an old commit the backslash of was missing in the rule for creating the i386-avx-mpx-avx512-pku.dat file. No need to regenerate the files, this was done by another commit from Yao. Note that if you mention the PR number in the commit log (which happens if you put the PR number in the ChangeLog entry, given the ChangeLog is pasted in the commit log too), then the bug in bugzilla is automatically updated to refer to the commit. > I also couldn't compile master: > ../../../binutils-gdb/gdb/probe.c: In function \u2018void parse_probes_in_pspace(const probe_ops*, program_space*, const char*, const char*, const char*, std::vector<symtab_and_line>*)\u2019: > ../../../binutils-gdb/gdb/probe.c:68:12: error: types may not be defined in a for-range-declaration [-Werror] > for (struct probe *probe : probes) > ^~~~~~ > ../../../binutils-gdb/gdb/probe.c: In function \u2018VEC_probe_p* find_probes_in_objfile(objfile*, const char*, const char*)\u2019: > ../../../binutils-gdb/gdb/probe.c:213:8: error: types may not be defined in a for-range-declaration [-Werror] > for (struct probe *probe : probes) > ^~~~~~ > > Are you aware of it? Yes, it's a GCC bug: https://sourceware.org/ml/gdb-patches/2017-09/msg00270.html What is your gcc version? I don't see this myself, but I know that Keith also ran into this recently. If it's easy to work around it, I don't see why not. Does this work for you? From 9c7590f2ea94930fd9280a6d66610edd53c0bb16 Mon Sep 17 00:00:00 2001 From: Pedro Alves <palves@redhat.com> Date: Mon, 16 Oct 2017 13:39:12 +0100 Subject: [PATCH] fix --- gdb/probe.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/gdb/probe.c b/gdb/probe.c index b3dbf89..f657548 100644 --- a/gdb/probe.c +++ b/gdb/probe.c @@ -65,23 +65,23 @@ parse_probes_in_pspace (const struct probe_ops *probe_ops, const std::vector<probe *> &probes = objfile->sf->sym_probe_fns->sym_get_probes (objfile); - for (struct probe *probe : probes) + for (probe *pro : probes) { - if (probe_ops != &probe_ops_any && probe->pops != probe_ops) + if (probe_ops != &probe_ops_any && pro->pops != probe_ops) continue; - if (provider && strcmp (probe->provider, provider) != 0) + if (provider && strcmp (pro->provider, provider) != 0) continue; - if (strcmp (probe->name, name) != 0) + if (strcmp (pro->name, name) != 0) continue; symtab_and_line sal; - sal.pc = get_probe_address (probe, objfile); + sal.pc = get_probe_address (pro, objfile); sal.explicit_pc = 1; sal.section = find_pc_overlay (sal.pc); sal.pspace = search_pspace; - sal.probe = probe; + sal.probe = pro; sal.objfile = objfile; result->push_back (std::move (sal)); -- 2.5.5 ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [pushed 8.0-branch] [Bug server/22137] gdbserver crashes on hosts with pkru register 2017-10-16 12:49 ` Pedro Alves @ 2017-10-16 13:20 ` Tedeschi, Walfred 2017-10-16 13:44 ` Pedro Alves 0 siblings, 1 reply; 6+ messages in thread From: Tedeschi, Walfred @ 2017-10-16 13:20 UTC (permalink / raw) To: Pedro Alves, gdb-patches > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Pedro Alves > Sent: Monday, October 16, 2017 2:50 PM > To: Tedeschi, Walfred <walfred.tedeschi@intel.com>; gdb- > patches@sourceware.org > Subject: Re: [pushed 8.0-branch] [Bug server/22137] gdbserver crashes on > hosts with pkru register > > On 10/16/2017 09:30 AM, Tedeschi, Walfred wrote: > >> -----Original Message----- > >> From: palves at redhat dot com [mailto:sourceware- > >> bugzilla@sourceware.org] > >> Sent: Friday, October 13, 2017 11:06 AM > >> To: Tedeschi, Walfred <walfred.tedeschi@intel.com> > >> Subject: [Bug server/22137] gdbserver crashes on hosts with pkru > >> register > >> > >> https://sourceware.org/bugzilla/show_bug.cgi?id=22137 > >> > >> Pedro Alves <palves at redhat dot com> changed: > >> > >> What |Removed |Added > >> ---------------------------------------------------------------------------- > >> Status|UNCONFIRMED |NEW > >> Last reconfirmed| |2017-10-13 > >> Ever confirmed|0 |1 > >> > >> --- Comment #3 from Pedro Alves <palves at redhat dot com> --- > >>> Bug is confirmed. > >> > >> Updating status then. Waldfred, if your account doesn't let you do > >> that yourself, please let me know. > >> > >> And, I believe the bug is fixed in both master and 8.0 branch, right? > >> > > Hello Pedro, > > > > I have pushed this one to 8.0 branch. In Master it does not apply anymore. > > Yes, you had fixed it in After some exercises I could see that in master it is not reproducible. It is already fixed there. > > commit 1b7fa39ed9678fded7264636c1e5cc14c6d6ebc6 > Author: Walfred Tedeschi <walfred.tedeschi@intel.com> > AuthorDate: Wed Sep 20 15:24:47 2017 +0200 > > [OBV] amd64-features-makefile: add missing backslash. > > In an old commit the backslash of was missing in the rule for creating the > i386-avx-mpx-avx512-pku.dat file. No need to regenerate the files, this > was done by another commit from Yao. > > Note that if you mention the PR number in the commit log (which happens if > you put the PR number in the ChangeLog entry, given the ChangeLog is > pasted in the commit log too), then the bug in bugzilla is automatically > updated to refer to the commit. > Sorry! I missed there! > > I also couldn't compile master: > > ../../../binutils-gdb/gdb/probe.c: In function \u2018void > parse_probes_in_pspace(const probe_ops*, program_space*, const char*, > const char*, const char*, std::vector<symtab_and_line>*)\u2019: > > ../../../binutils-gdb/gdb/probe.c:68:12: error: types may not be defined in a > for-range-declaration [-Werror] > > for (struct probe *probe : probes) > > ^~~~~~ > > ../../../binutils-gdb/gdb/probe.c: In function \u2018VEC_probe_p* > find_probes_in_objfile(objfile*, const char*, const char*)\u2019: > > ../../../binutils-gdb/gdb/probe.c:213:8: error: types may not be defined in a > for-range-declaration [-Werror] > > for (struct probe *probe : probes) > > ^~~~~~ > > > > Are you aware of it? > > Yes, it's a GCC bug: > https://sourceware.org/ml/gdb-patches/2017-09/msg00270.html > > What is your gcc version? > > I don't see this myself, but I know that Keith also ran into this recently. If it's > easy to work around it, I don't see why not. > > Does this work for you? > It worked! Thanks! /Fred > From 9c7590f2ea94930fd9280a6d66610edd53c0bb16 Mon Sep 17 00:00:00 > 2001 > From: Pedro Alves <palves@redhat.com> > Date: Mon, 16 Oct 2017 13:39:12 +0100 > Subject: [PATCH] fix > > --- > gdb/probe.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/gdb/probe.c b/gdb/probe.c > index b3dbf89..f657548 100644 > --- a/gdb/probe.c > +++ b/gdb/probe.c > @@ -65,23 +65,23 @@ parse_probes_in_pspace (const struct probe_ops > *probe_ops, > const std::vector<probe *> &probes > = objfile->sf->sym_probe_fns->sym_get_probes (objfile); > > - for (struct probe *probe : probes) > + for (probe *pro : probes) > { > - if (probe_ops != &probe_ops_any && probe->pops != probe_ops) > + if (probe_ops != &probe_ops_any && pro->pops != probe_ops) > continue; > > - if (provider && strcmp (probe->provider, provider) != 0) > + if (provider && strcmp (pro->provider, provider) != 0) > continue; > > - if (strcmp (probe->name, name) != 0) > + if (strcmp (pro->name, name) != 0) > continue; > > symtab_and_line sal; > - sal.pc = get_probe_address (probe, objfile); > + sal.pc = get_probe_address (pro, objfile); > sal.explicit_pc = 1; > sal.section = find_pc_overlay (sal.pc); > sal.pspace = search_pspace; > - sal.probe = probe; > + sal.probe = pro; > sal.objfile = objfile; > > result->push_back (std::move (sal)); > -- > 2.5.5 Thanks and regards, /Fred Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [pushed 8.0-branch] [Bug server/22137] gdbserver crashes on hosts with pkru register 2017-10-16 13:20 ` Tedeschi, Walfred @ 2017-10-16 13:44 ` Pedro Alves 2017-10-16 14:04 ` Tedeschi, Walfred 0 siblings, 1 reply; 6+ messages in thread From: Pedro Alves @ 2017-10-16 13:44 UTC (permalink / raw) To: Tedeschi, Walfred, gdb-patches On 10/16/2017 02:20 PM, Tedeschi, Walfred wrote: > >>> > > I also couldn't compile master: >>> > > ../../../binutils-gdb/gdb/probe.c: In function \u2018void >> > parse_probes_in_pspace(const probe_ops*, program_space*, const char*, >> > const char*, const char*, std::vector<symtab_and_line>*)\u2019: >>> > > ../../../binutils-gdb/gdb/probe.c:68:12: error: types may not be defined in a >> > for-range-declaration [-Werror] >>> > > for (struct probe *probe : probes) >>> > > ^~~~~~ >>> > > ../../../binutils-gdb/gdb/probe.c: In function \u2018VEC_probe_p* >> > find_probes_in_objfile(objfile*, const char*, const char*)\u2019: >>> > > ../../../binutils-gdb/gdb/probe.c:213:8: error: types may not be defined in a >> > for-range-declaration [-Werror] >>> > > for (struct probe *probe : probes) >>> > > ^~~~~~ >>> > > >>> > > Are you aware of it? >> > >> > Yes, it's a GCC bug: >> > https://sourceware.org/ml/gdb-patches/2017-09/msg00270.html >> > >> > What is your gcc version? >> > >> > I don't see this myself, but I know that Keith also ran into this recently. If it's >> > easy to work around it, I don't see why not. >> > >> > Does this work for you? >> > > It worked! Thanks, I'll push in a bit. I'm still curious to know your gcc version though. Actually, I'm confused on how it worked for you, since I hadn't fixed the same problem around line "213" quoted above. Are you sure you tested with the same compiler? Thanks, Pedro Alves ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [pushed 8.0-branch] [Bug server/22137] gdbserver crashes on hosts with pkru register 2017-10-16 13:44 ` Pedro Alves @ 2017-10-16 14:04 ` Tedeschi, Walfred 2017-10-16 14:16 ` Pedro Alves 0 siblings, 1 reply; 6+ messages in thread From: Tedeschi, Walfred @ 2017-10-16 14:04 UTC (permalink / raw) To: Pedro Alves, gdb-patches > -----Original Message----- > From: Pedro Alves [mailto:palves@redhat.com] > Sent: Monday, October 16, 2017 3:44 PM > To: Tedeschi, Walfred <walfred.tedeschi@intel.com>; gdb- > patches@sourceware.org > Subject: Re: [pushed 8.0-branch] [Bug server/22137] gdbserver crashes on > hosts with pkru register > > On 10/16/2017 02:20 PM, Tedeschi, Walfred wrote: > > > >>> > > I also couldn't compile master: > >>> > > ../../../binutils-gdb/gdb/probe.c: In function \u2018void > >> > parse_probes_in_pspace(const probe_ops*, program_space*, const > >> > char*, const char*, const char*, > std::vector<symtab_and_line>*)\u2019: > >>> > > ../../../binutils-gdb/gdb/probe.c:68:12: error: types may not be > >>> > > defined in a > >> > for-range-declaration [-Werror] > >>> > > for (struct probe *probe : probes) > >>> > > ^~~~~~ > >>> > > ../../../binutils-gdb/gdb/probe.c: In function > >>> > > \u2018VEC_probe_p* > >> > find_probes_in_objfile(objfile*, const char*, const char*)\u2019: > >>> > > ../../../binutils-gdb/gdb/probe.c:213:8: error: types may not be > >>> > > defined in a > >> > for-range-declaration [-Werror] > >>> > > for (struct probe *probe : probes) > >>> > > ^~~~~~ > >>> > > > >>> > > Are you aware of it? > >> > > >> > Yes, it's a GCC bug: > >> > https://sourceware.org/ml/gdb-patches/2017-09/msg00270.html > >> > > >> > What is your gcc version? > >> > > >> > I don't see this myself, but I know that Keith also ran into this > >> > recently. If it's easy to work around it, I don't see why not. > >> > > >> > Does this work for you? > >> > > > It worked! > > Thanks, I'll push in a bit. I'm still curious to know your gcc version though. Version is 6.3.1 > > Actually, I'm confused on how it worked for you, since I hadn't fixed the > same problem around line "213" quoted above. > Yes there were more, I fixed in the same way, full patch is here: diff --git a/gdb/elfread.c b/gdb/elfread.c index 436d9b5..8a12b56 100644 --- a/gdb/elfread.c +++ b/gdb/elfread.c @@ -1340,8 +1340,8 @@ probe_key_free (bfd *abfd, void *d) { std::vector<probe *> *probes = (std::vector<probe *> *) d; - for (struct probe *probe : *probes) - probe->pops->destroy (probe); + for (probe *prob : *probes) + prob->pops->destroy (prob); delete probes; } diff --git a/gdb/probe.c b/gdb/probe.c index b3dbf89..487847c 100644 --- a/gdb/probe.c +++ b/gdb/probe.c @@ -65,23 +65,23 @@ parse_probes_in_pspace (const struct probe_ops *probe_ops, const std::vector<probe *> &probes = objfile->sf->sym_probe_fns->sym_get_probes (objfile); - for (struct probe *probe : probes) + for (probe *pro : probes) { - if (probe_ops != &probe_ops_any && probe->pops != probe_ops) + if (probe_ops != &probe_ops_any && pro->pops != probe_ops) continue; - if (provider && strcmp (probe->provider, provider) != 0) + if (provider && strcmp (pro->provider, provider) != 0) continue; - if (strcmp (probe->name, name) != 0) + if (strcmp (pro->name, name) != 0) continue; symtab_and_line sal; - sal.pc = get_probe_address (probe, objfile); + sal.pc = get_probe_address (pro, objfile); sal.explicit_pc = 1; sal.section = find_pc_overlay (sal.pc); sal.pspace = search_pspace; - sal.probe = probe; + sal.probe = pro; sal.objfile = objfile; result->push_back (std::move (sal)); @@ -210,15 +210,15 @@ find_probes_in_objfile (struct objfile *objfile, const char *provider, const std::vector<probe *> &probes = objfile->sf->sym_probe_fns->sym_get_probes (objfile); - for (struct probe *probe : probes) + for (probe *prob : probes) { - if (strcmp (probe->provider, provider) != 0) + if (strcmp (prob->provider, provider) != 0) continue; - if (strcmp (probe->name, name) != 0) + if (strcmp (prob->name, name) != 0) continue; - VEC_safe_push (probe_p, result, probe); + VEC_safe_push (probe_p, result, prob); } return result; @@ -244,11 +244,11 @@ find_probe_by_pc (CORE_ADDR pc) /* If this proves too inefficient, we can replace with a hash. */ const std::vector<probe *> &probes = objfile->sf->sym_probe_fns->sym_get_probes (objfile); - for (struct probe *probe : probes) - if (get_probe_address (probe, objfile) == pc) + for (probe *prob : probes) + if (get_probe_address (prob, objfile) == pc) { result.objfile = objfile; - result.probe = probe; + result.probe = prob; return result; } } @@ -294,20 +294,20 @@ collect_probes (const std::string &objname, const std::string &provider, const std::vector<probe *> &probes = objfile->sf->sym_probe_fns->sym_get_probes (objfile); - for (struct probe *probe : probes) + for (probe *prob : probes) { - if (pops != NULL && probe->pops != pops) + if (pops != NULL && prob->pops != pops) continue; if (prov_pat - && prov_pat->exec (probe->provider, 0, NULL, 0) != 0) + && prov_pat->exec (prob->provider, 0, NULL, 0) != 0) continue; if (probe_pat - && probe_pat->exec (probe->name, 0, NULL, 0) != 0) + && probe_pat->exec (prob->name, 0, NULL, 0) != 0) continue; - result.emplace_back (probe, objfile); + result.emplace_back (prob, objfile); } } > Are you sure you tested with the same compiler? > > Thanks, > Pedro Alves Thanks and regards, /Fred Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [pushed 8.0-branch] [Bug server/22137] gdbserver crashes on hosts with pkru register 2017-10-16 14:04 ` Tedeschi, Walfred @ 2017-10-16 14:16 ` Pedro Alves 0 siblings, 0 replies; 6+ messages in thread From: Pedro Alves @ 2017-10-16 14:16 UTC (permalink / raw) To: Tedeschi, Walfred, gdb-patches On 10/16/2017 03:04 PM, Tedeschi, Walfred wrote: >> From: Pedro Alves [mailto:palves@redhat.com] >>>>> Does this work for you? >>>>> >>> It worked! >> >> Thanks, I'll push in a bit. I'm still curious to know your gcc version though. > Version is 6.3.1 >> >> Actually, I'm confused on how it worked for you, since I hadn't fixed the >> same problem around line "213" quoted above. >> > Yes there were more, I fixed in the same way, full patch is here: OK, I've pushed it now: https://sourceware.org/ml/gdb-patches/2017-10/msg00442.html Thanks, Pedro Alves ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-16 14:16 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-10-16 8:30 [pushed 8.0-branch] [Bug server/22137] gdbserver crashes on hosts with pkru register Tedeschi, Walfred 2017-10-16 12:49 ` Pedro Alves 2017-10-16 13:20 ` Tedeschi, Walfred 2017-10-16 13:44 ` Pedro Alves 2017-10-16 14:04 ` Tedeschi, Walfred 2017-10-16 14:16 ` Pedro Alves
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).