From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-142632-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 123731 invoked by alias); 16 Oct 2017 13:23:45 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 123721 invoked by uid 89); 16 Oct 2017 13:23:45 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1414, Tel, tel, commercial
X-HELO: mga01.intel.com
Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Oct 2017 13:23:44 +0000
Received: from fmsmga002.fm.intel.com ([10.253.24.26])  by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Oct 2017 06:23:42 -0700
X-ExtLoop1: 1
Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99])  by fmsmga002.fm.intel.com with ESMTP; 16 Oct 2017 06:23:41 -0700
Received: from irsmsx104.ger.corp.intel.com ([169.254.5.248]) by IRSMSX107.ger.corp.intel.com ([169.254.10.239]) with mapi id 14.03.0319.002; Mon, 16 Oct 2017 14:23:41 +0100
From: "Tedeschi, Walfred" <walfred.tedeschi@intel.com>
To: "palves@redhat.com" <palves@redhat.com>, "simon.marchi@polymtl.ca"	<simon.marchi@polymtl.ca>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH v2] symlookup: improves symbol lookup when a file is specified.
Date: Mon, 16 Oct 2017 13:23:00 -0000
Message-ID: <AC542571535E904D8E8ADAE745D60B197A9A2DDC@IRSMSX104.ger.corp.intel.com>
References: <1507727728-30540-1-git-send-email-walfred.tedeschi@intel.com>
In-Reply-To: <1507727728-30540-1-git-send-email-walfred.tedeschi@intel.com>
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
X-SW-Source: 2017-10/txt/msg00439.txt.bz2

Hi all,

> +set lib_opts debug
> +set exec_opts [list debug shlib_load
> +additional_flags=3D-DSHLIB_NAME=3D\"${lib_dlopen1}\"
> +additional_flags=3D-DSHLIB_NAME2=3D\"${lib_dlopen2}\"]
> +
> +if { [gdb_compile_shlib $libsrc1 $libobj1 $lib_opts] !=3D ""
> +     || [gdb_compile_shlib $libsrc2 $libobj2 $lib_opts] !=3D ""
> +     || [gdb_compile $srcfile $binfile executable $exec_opts] !=3D ""} {
> +    untested "failed to compile"
> +    return -1
> +}

I have revmoved the code below from my sandbox.
Next review will not have that.

> +
> +if { [gdb_compile_shlib ${srcdir}/${subdir}/${lib1}.c \
> +                        ${libobj1} \
> +                        ${lib_opts} ] !=3D "" } {
> +    return -1
> +}
> +if { [gdb_compile_shlib ${srcdir}/${subdir}/${lib2}.c \
> +                        ${libobj2} \
> +                        ${lib_opts} ] !=3D "" } {
> +    return -1
> +}
> +if { [gdb_compile "${srcdir}/${subdir}/${executable}.c" \
> +                  [standard_output_file ${executable}] \
> +                  executable \
> +                  [list debug shlib=3D-ldl]]
> +     !=3D ""} {
> +    return -1
> +}
> +

Would it help to have a branch with those changes?

Thanks and regards,
/Fred

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928