From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106938 invoked by alias); 19 Jan 2018 17:01:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106929 invoked by uid 89); 19 Jan 2018 17:01:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*RU:209.85.128.196, Hx-spam-relays-external:209.85.128.196, rights, Every X-HELO: mail-wr0-f196.google.com Received: from mail-wr0-f196.google.com (HELO mail-wr0-f196.google.com) (209.85.128.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Jan 2018 17:01:41 +0000 Received: by mail-wr0-f196.google.com with SMTP id 100so2159938wrb.7 for ; Fri, 19 Jan 2018 09:01:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=UXobujaNYDOoa001XUtkt8X5TMJPt/MGzahC5H7yXcE=; b=p/hv/phWE8wJ/33Gnk0Kw+wA+r+MeTYRXNmnDTRTfvC4y4/jvYQtrCeZcYMhqFwFla eWpEgUXvW14vEWrtExOgJ+KfJCBrUcCv0kQvU0C9ZkYu1/+j6OCYJUP2Rdut1Ao0ZpZ+ i+urVbkEznyJqB3CyTCnCJWjzdcBI4iO5UQTOwBuyk+hhahnmyJGPq2GKAmcXeWKX6bn kp5m9oTcreVFn81fYwlRpUHbwDnFYcblfm1qcbkt0+BTEz/q4RI+ZWUXP7lk6W2RrbAo ep6w5pvFeCygC3pJGiGkFUKisR3Sdc4+/CgOH0C2/7l5Rh6qxdgoSHV4igu2J/XKWV6/ NUQw== X-Gm-Message-State: AKwxytdBIb0LRwY+Axftja8Qma2zN/W3Qg/HBdHvGTLkZaKUy/nrvKwV +HzlY2qre96TGKeDJFNqmRVKJw== X-Google-Smtp-Source: ACJfBouUAs7kfB+icQMzVlwRnjq1bCvqILp5j+hy5J604CoV335zCqzcBeASso6ChW8mpnnM+rxy/g== X-Received: by 10.223.130.194 with SMTP id 60mr9970592wrc.72.1516381299108; Fri, 19 Jan 2018 09:01:39 -0800 (PST) Received: from eduroam-jrtc4-35d43e-2.trin.private.cam.ac.uk (global-184-7.nat-1.net.cam.ac.uk. [131.111.184.7]) by smtp.gmail.com with ESMTPSA id i47sm10200487wrf.26.2018.01.19.09.01.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Jan 2018 09:01:37 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: Re: [PATCH 2/2] gdb: Add missing #ifdef USE_THREAD_DB to gdbserver From: James Clarke In-Reply-To: Date: Fri, 19 Jan 2018 17:01:00 -0000 Cc: gdb-patches@sourceware.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20171215000434.47315-1-jrtc27@jrtc27.com> <20171215000434.47315-2-jrtc27@jrtc27.com> <1BA91B1E-5E4A-4084-822C-3A35ADB4390C@jrtc27.com> To: Pedro Alves X-SW-Source: 2018-01/txt/msg00406.txt.bz2 On 19 Jan 2018, at 16:57, Pedro Alves wrote: > On 01/19/2018 04:55 PM, James Clarke wrote: >> On 19 Jan 2018, at 16:48, Pedro Alves wrote: >>> On 12/15/2017 12:04 AM, James Clarke wrote: >>>> gdb/ChangeLog: >>>> * gdbserver/linux-low.c (handle_extended_wait): Surround call to >>>> thread_db_notice_clone with #ifdef USE_THREAD_DB. >>>> --- >>>> [Originally erroneously sent to the binutils mailing list] >>>=20 >>> Looks OK, but could you remind me what goes wrong if we >>> don't do this? Does gdbserver fail to link? >>=20 >> Yes, with the expected: >>=20 >>> [...]/linux-low.c:664: undefined reference to `thread_db_notice_clone(t= hread_info*, ptid_t)' >>=20 >> Every other use of thread_db_* is guarded by USE_THREAD_DB, so I assume = it's >> fine to do here too. >=20 > Thanks for the clarification. Please add that to the commit log, > and push it in. I don't have push rights, so I'll email a v2 to be committed on my behalf. Regards, James