From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82770 invoked by alias); 15 Dec 2019 18:18:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82761 invoked by uid 89); 15 Dec 2019 18:18:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_STOCKGEN,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 spammy=pushing X-HELO: EUR03-DB5-obe.outbound.protection.outlook.com Received: from mail-oln040092071030.outbound.protection.outlook.com (HELO EUR03-DB5-obe.outbound.protection.outlook.com) (40.92.71.30) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 15 Dec 2019 18:18:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lbpOSZW4yUK5cu8tGCVLzsuvDDvyOOStaXCqt9Kgn9MaYuN4mD9A7834AIqp8XdTwfzGawYgCjwDbBltS2fgJ9l9pAR0QepdVZUYF8gO2rXwfZPmhEWhA4ELBzNeuDt4z2JF/AmiQ8eGUT1z/DJG4Bw+uudKzMMhRKvlvER5DgcOdbJLcb0AlcAe2iv8yruE1LNLi77VXPiDtNE05ILfH4ETh2cdgQou2VfqZpQvQg4Pp0afB1crQgdjk78eVW1R2Z7MXrdvhfDiCI3aLd0Ud5Px8rjfCflpHDw6AwqTzraOhFWlaSVzauLi5Lif2oCnJ0phIKw8OqU2oEoB5u12Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Zydghy6y2QOnuVIl2zRc/iGwsuP+DBjr3TvDLgF+Mo=; b=dR3iq6X3S+uoRUWtGrbBsH6rcU4d+mwWxYBLf2qO1YYgF6wV9QiUzrFlNefHeLekGz2BjumBPQIFxhgJQva5/qQQpPGy0xEasPjPDWpyu6yszrrkqzQJIbaBvgwGKjFtENudsjFtIgdPcNonTykdabcmbvhBrqYE0xvjp/FuI0G+ZvDsETXdBHtbPjAUTRTeBVAWzahYwE1vPDjhbqbcjvzmezpy/7D7oyN97JfSi4j1E/yGqes+5Ap8r86DkVHBj2yvzG8+I5EpFGW5oG3drovYr1/WE2hp523v7G8tPNr38mVflwlHIE8rkU9AI+n/BhHjBQ0TUyHR+3V/2vjIWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from AM5EUR03FT008.eop-EUR03.prod.protection.outlook.com (10.152.16.58) by AM5EUR03HT244.eop-EUR03.prod.protection.outlook.com (10.152.17.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.18; Sun, 15 Dec 2019 18:18:30 +0000 Received: from AM0PR08MB3714.eurprd08.prod.outlook.com (10.152.16.55) by AM5EUR03FT008.mail.protection.outlook.com (10.152.16.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.18 via Frontend Transport; Sun, 15 Dec 2019 18:18:30 +0000 Received: from AM0PR08MB3714.eurprd08.prod.outlook.com ([fe80::8dd1:fb18:6271:f769]) by AM0PR08MB3714.eurprd08.prod.outlook.com ([fe80::8dd1:fb18:6271:f769%7]) with mapi id 15.20.2538.019; Sun, 15 Dec 2019 18:18:30 +0000 From: Bernd Edlinger To: Simon Marchi , Pedro Alves , "gdb-patches@sourceware.org" Subject: Re: [PATCHv6] Make "skip" work on inline frames Date: Sun, 15 Dec 2019 18:18:00 -0000 Message-ID: References: <8fc93db4-8906-4f4e-53f4-225ebfa0115d@simark.ca> <215bbf9c-4c3c-5cd2-c657-51aa7262f234@simark.ca> <8d5b880e-12f2-11ac-1bfe-82941f64369b@simark.ca> <7cc09703-1d47-2598-05f1-57199289d31a@simark.ca> <6dfa48bd-26c1-e792-03e6-6bdb81d1b368@simark.ca> In-Reply-To: <6dfa48bd-26c1-e792-03e6-6bdb81d1b368@simark.ca> x-microsoft-original-message-id: <47e5c874-3578-e8df-4580-0713f8ea0d23@hotmail.de> x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="Windows-1252" Content-ID: <8C90EDC9BA056247B4A2AFD19A6CC277@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2019-12/txt/msg00693.txt.bz2 On 12/15/19 2:12 PM, Simon Marchi wrote: > On 2019-12-15 6:25 a.m., Bernd Edlinger wrote: >> On 12/15/19 1:46 AM, Simon Marchi wrote: >>> On 2019-12-02 11:47 a.m., Bernd Edlinger wrote: >>>> On 12/2/19 3:34 AM, Simon Marchi wrote: >>>>> On 2019-11-24 6:22 a.m., Bernd Edlinger wrote: >>>>>> This is just a minor update on the patch >>>>>> since the function SYMBOL_PRINT_NAME was removed with >>>>>> commit 987012b89bce7f6385ed88585547f852a8005a3f >>>>>> I replaced it with sym->print_name (), otherwise the >>>>>> patch is unchanged. >>>>> >>>>> Hi Bernd, >>>>> >>>>> Sorry, I had lost this in the mailing list noise. >>>>> >>>>> I played a bit with the patch and different cases of figure. I am no= t able to understand >>>>> the purpose of each of your changes (due to the complexity of that pa= rticular code), but >>>>> I didn't find anything that stood out as wrong to me. Pedro might be= able to do a more >>>>> in-depth review of the event handling code. >>>>> >>>>> If the test tests specifically skipping of inline functions, I'd name= it something more >>>>> descriptive than "skip2.exp", maybe "skip-inline.exp"? >>>>> >>>>> Unfortunately, your test doesn't pass on my computer (gcc 9.2.0), but= neither does the >>>>> gdb.base/skip.exp. I am attaching the gdb.log when running your test= , if it can help. >>>>> >>>>> Simon >>>>> >>>> >>>> Hi Simon, >>>> >>>> I only tested that with gcc-4.8, and both test cases worked with that = gcc version. >>>> >>>> I tried now with gcc-trunk version from a few days ago, and I think I = see >>>> what you mean. >>>> >>>> skip2.c (now skip-inline.c) can be fixed by removing the assignment >>>> to x in the first line, which is superfluous (and copied from skip.c). >>>> But skip.c cannot be fixed this way. I only see a chance to allow >>>> the stepping back to main and then to foo happen. >>>> >>>> Does this modified test case work for you? >>>> >>>> >>>> >>>> Thanks >>>> Bernd. >>>> >>> >>> Hi Bernd, >>> >>> Thanks for fixing the skip.exp test at the same time. I'd prefer if th= is was done as a >>> separate patch though, since it's an issue separate from the inline ste= pping issue you >>> were originally tackling. >> >> Okay, I split that out as a separate patch now. >> >>> >>> So the patch looks good to me if you remove those bits, and fix the fol= lowing nits: >>> >>> - Remove "load_lib completion-support.exp" from the test. >>> - The indentation in the .exp should use tabs for multiple of 8 columns= , instead of just spaces (like you did in the .c). >>> >> >> Done. Also added changelog text, which I forgot previously. >> >>> A comment I would have on the bits in skip.exp: >>> >>> # with recent gcc we jump once back to main before entering foo here >>> # if that happens try to step a second time >>> gdb_test "step" "foo \\(\\) at.*" "step 3" "main \\(\\) at .*" "ste= p" >>> >>> It's usually not helpful to say "with recent gcc", since it doesn't mea= n much, especially >>> when reading this 10 years from now. Instead, mention the specific gcc= version this was >>> observed with. Also, begin the sentence with a capital letter and fini= sh with a period. >>> >> >> Done. >> >> >> Is it OK for trunk? >=20 > That LGTM. I just remembered that your copyright assignment status was u= nclear, but I looked > up your name and saw that you filed one recently. >=20 > Would you like me to continue pushing your patches for you, or would you = prefer to get push > access, so you are able to do so when they are approved? >=20 Either way is fine for me. Thanks Bernd. > Simon >=20