From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2134.outbound.protection.outlook.com [40.107.104.134]) by sourceware.org (Postfix) with ESMTPS id 436CB3858D1E for ; Tue, 20 Jun 2023 14:21:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 436CB3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=Syrmia.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Syrmia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V67ClAIbBjWqYjSbg2Ay+jnW12kDy8ai80Kutmo7QxRCVEfrmvUqODP0quAE5eShf/jofCwKDFpMDWNoyn019dB1AtR4GvfDlR01r/vWe4Y7GyiuPSfdok1+WVUYdKoAJuTHKfxspavuALLfnjyX+o3y+Bz4jQNb3Oc5vqDIyQkrAvJhhvxI6ttGQjEq8DdJFgIsX8rjVrBNCUsSNW0TSwGjEde4ZRLvqPqoNk9vFCybb2wkmhtsnFRMEvydxzG+Svf3+ynEhr5xjvveAiVLG7amaOZwBtwo64i4pZAIS7KeEAcLV94fwSLP4itglgn8aDvIRe/TvFIF5J+kIWv8+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e7E5LdMPMA1ThbZMYm7ryxbPQH91ziLtA+Z0oLgEaos=; b=CMAT0C5SZqaRVrjE92Xtf/MfC/h7WOEEHKQV01MMX3JPccnkKAZdeWW55ydyjPyT++4QvxaEj/SQz6UUT/4tYpwEhhGwKvsROo5jEjaonNziLvC2Qm1pzdUu1/MuXFtRuyES6F81eGowCknDhnnYYRB4cV7zn5AdonL3Cjeka4uiLbPnwZHa6Zag7flRUOGcmDXALMiSiKlO6JmlPfs1DdgQa3iGPHRp/exB4vWCQMagQojwbN9YU9FFq+V9C7GeKYsUSTUIwi0H6WpS/0P7DL32YC5sjzl6VNEQLp2SNTrT/RuPfTe17jIn8fhxlK6MytFttxqQ+oEr9N+5ufiBWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=syrmia.com; dmarc=pass action=none header.from=syrmia.com; dkim=pass header.d=syrmia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=syrmia.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e7E5LdMPMA1ThbZMYm7ryxbPQH91ziLtA+Z0oLgEaos=; b=XGkSdT2bAQ/24JQZuQyRAU5W1E/7kX7igWlAzxLTB/OfgXjAvElWehPt3ek1pHl2GHpsm17rKbJ0H0fq5A4F/Rpywej4gz9jzrV6LdSwtEkQncPv4yUfZDGmsnguRdNPvUPC21yctoBrqWtPJgEvpGZGCya3la/gNfBgCb2rR9k= Received: from AM6PR03MB4984.eurprd03.prod.outlook.com (2603:10a6:20b:88::29) by AS8PR03MB9365.eurprd03.prod.outlook.com (2603:10a6:20b:57d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.36; Tue, 20 Jun 2023 14:21:24 +0000 Received: from AM6PR03MB4984.eurprd03.prod.outlook.com ([fe80::17fc:8700:8177:b3d7]) by AM6PR03MB4984.eurprd03.prod.outlook.com ([fe80::17fc:8700:8177:b3d7%4]) with mapi id 15.20.6500.029; Tue, 20 Jun 2023 14:21:24 +0000 From: Branislav Brzak To: Tom Tromey CC: "gdb-patches@sourceware.org" , Dragoslav Sicarov , Djordje Todorovic Subject: Re: [PATCH 0/1] riscv: Ensure LE instruction fetching Thread-Topic: [PATCH 0/1] riscv: Ensure LE instruction fetching Thread-Index: AQHZo2zDlWEG1D5yX0qP7FS0oK6Rsa+TkxwegAAndB2AAANv5g== Date: Tue, 20 Jun 2023 14:21:24 +0000 Message-ID: References: <87o7la2plr.fsf@tromey.com> In-Reply-To: <87o7la2plr.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=Syrmia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM6PR03MB4984:EE_|AS8PR03MB9365:EE_ x-ms-office365-filtering-correlation-id: 7f878600-b092-46ec-e32a-08db7199a0df x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2PdiJl3F+6/dCzZ9ZLxJcJWxJqX4CM304z3AsBmyqArioMcmRWrNHlVAsAYTYA8U6fVtwcETUVRzr3oxBDBHewwvWv1a+YHXb6zJsU4A28rP+icmofqC4tga0yEpLWq4e/6vAPx38DLjvBiLKYiP6wh4uhSAt9gZbOAS+nhJOewey+Un5cUFM2/wqtoAEyRL0/sttY+GUvoYhscRIIEHvUjee+IULsK+2e6HVsh4osVsZyy/OFd1se29Pklfpc0fqsQNLDTwcMjCxppUPEz6DW4HwSn82sRheI3P1o61WU69P998FPgF98NOhJTgkrqx0Cv/2fbvSxh4LGcHRCYBZNND6XzmkuOTEZI69OkYvz0hbNz2Z5JhvS/xOar6vS3d+jD4j/EbjdcJLjSMt1bRHuquzTSdVfm2UTyeYZqf7LZCE/kL7+8FZequhXRbAEvQ8SKyM2xZJ1vFwFKcN7lx1Z3NK7ksJaRzgQPMLVprN6lCr1rFwKIHie0hxR+VhOL5J0KV6UjqSc1D6OJ+2bC61NVinA1wyONMp63hjVf0owtsw1ys8A0s5l9zpiXqAzaBg+835yyf4TILZBu8W/VBsp3/8vZrYqlZENgpaB3LRupyTFcjPu9wszJB2CefDd98 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR03MB4984.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39840400004)(346002)(366004)(396003)(136003)(376002)(451199021)(71200400001)(478600001)(7696005)(83380400001)(86362001)(107886003)(38100700002)(316002)(99936003)(91956017)(64756008)(66446008)(122000001)(66556008)(66946007)(4326008)(66476007)(6916009)(76116006)(53546011)(6506007)(19627405001)(9686003)(186003)(26005)(54906003)(52536014)(41300700001)(5660300002)(8936002)(8676002)(38070700005)(2906002)(55016003)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GwpjzWodeaNGmz7tXLDLY3/9FVdYDSnwaUMmYpa/fh/qs8oOwGVncehu/U9J?= =?us-ascii?Q?x41pNQtpz53oOgQvVCY9MeqlgdT1nZJZ/Bo4ZIVBd58N36NTK1l9DegepS81?= =?us-ascii?Q?eGZ0OS5bXDczw7xQP2my0nRdjUSQwyJODG6BdNSTrVrAwMsHi5w1UM7ddOJU?= =?us-ascii?Q?UexWxeozJq4QsqkqRIOdK2rWiwNMMHW+C0VAQXa5PT9Xla433q9TR0h5SGWQ?= =?us-ascii?Q?kNJ3/wkhOs4IRZsAGP2tORixHnF3URLS/KYvwVCwiJZbI1s4XqMpYF6yoL2a?= =?us-ascii?Q?Jnq3TcdfKCt/fZXvisS9FCpcfwt0LOXwu5k8nJCwYX2UkzEmmvMFB3vGAfBO?= =?us-ascii?Q?HZDT/I7EM92OA8yXAiTs61LYYRuKnnw2p6h+4aHUKua/CLCFzNUb/WOxetqH?= =?us-ascii?Q?lDNA1lxEfmp5Ebjm0VF8fIJ3qVNsEpj8yu/CPTsYqmjYV6qkaFKUvoPF0Gwy?= =?us-ascii?Q?SCUMYwmmGkrzSWPPs74twXTgnU2JjbMlj48X3YlRHS15BwsvIrYlivaUGFxZ?= =?us-ascii?Q?mZWiOZO65gB0dzmYk3AyEZheSVJFPSdEkQl/IINFdUZZ8HSWNzmfnw7+ml/1?= =?us-ascii?Q?Tk/nciuc+ItPuV2iqBBaCjE+mb4Qu104geayKRCv1J7PGP+FleXnnR4L94J4?= =?us-ascii?Q?MQfbs0Zs4Qra2aneGC5eNhURPy1bEgSPkRTw0FZFm13O/wkI1Ni7qoHQEG+I?= =?us-ascii?Q?jVbgLm2gfz04jGy6sLOe8bTOyQcfj5NGYIZenZO5nhMI7BAvpQRg7o/MK3NA?= =?us-ascii?Q?vsyBwEGvbqTWPIP9TgQ5TXYenWLS/my+rAa1GjCmNOrdSN2tASOIXBv+NcYM?= =?us-ascii?Q?hsoGb3B0/+ghHczMEWXrKhqVqm6cQr5F5UhbRbFflwkaZn/5+MWFWF1vCQ8X?= =?us-ascii?Q?Avki9PKYmGMO8U2VwkmCEb07Sl5fbKKpUey4YUCIc1fQri1nLfgskb64dwdV?= =?us-ascii?Q?yiuM7UmYpESEguBIe8rRH+xGIHWcgaFg4URpYZuF7BKB16qwdhAXz+JCG/++?= =?us-ascii?Q?f1HJHrr9D52AeSp52dngoLGvWycQRPVl3AOGOReUUNdhVaOzG0Ly3FsBJQwb?= =?us-ascii?Q?zU1VI4+G3eXqnEtG+73V/jAqVq3xmAJHyp8Lnch+yKX3/FLK8zigJlsKu2Hq?= =?us-ascii?Q?Ewn7OR2lZ6uekfD+v+UNovA9K/cSF+Kihhk9GmSGCd3EEOc8FMQtCFcjZ6uq?= =?us-ascii?Q?kR5rgU0UKRnuYGBjdCW0t0VX4+OZLAqfScCKM0WjKFdfyaM8g7FkvsqzhdDr?= =?us-ascii?Q?1E7kTOtKWK38pvv/uJJzH92Y7bzJb2SkJrYoMBngWWIHXcIrBH2LfqPtxbG3?= =?us-ascii?Q?IE5lXNvWG3DcQj4ZlQH5CmZ8Cy3LR2x62zjDkxO0MeVznXFjQsqSJcgC8B8g?= =?us-ascii?Q?b9UNPYTivgLewPV1jgDjPFI9+Bmu9TkNsEWSOIXoiS+GyNYNR1VvKaNRWyrx?= =?us-ascii?Q?SPNOUpyuI9FBK2firBEfui19FvTp76LXrHHIkWM5As4rMDq8n9caYNbxVjkT?= =?us-ascii?Q?4Sc2EL2GAzNO1noIB9+cW/gdpYGK2RLB88HRUzeA6G39ndjqmvMznFjzQa9o?= =?us-ascii?Q?Y+fQuLlhIRHNxh1rV/6YOfgrl0GTmmNkB5+PDXfb?= Content-Type: multipart/mixed; boundary="_004_AM6PR03MB49841E8E3F391F342ED12B66985CAAM6PR03MB4984eurp_" MIME-Version: 1.0 X-OriginatorOrg: syrmia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR03MB4984.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f878600-b092-46ec-e32a-08db7199a0df X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2023 14:21:24.5774 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 19214a73-c1ab-4e19-8f59-14bdcb09a66e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Uj+9VK9Pnzw7iajtokk8t1w7kXX6CswdEqwh8oXZU6ZLbnUTcAJ/E+/4uE8OqR/Rwoeq4isjhUypevfg4srnP8eq4JXhT7okDvauq3rEZWU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB9365 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --_004_AM6PR03MB49841E8E3F391F342ED12B66985CAAM6PR03MB4984eurp_ Content-Type: multipart/alternative; boundary="_000_AM6PR03MB49841E8E3F391F342ED12B66985CAAM6PR03MB4984eurp_" --_000_AM6PR03MB49841E8E3F391F342ED12B66985CAAM6PR03MB4984eurp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Tom, Here is the patch with the changes you specified. Regards, Branislav ________________________________ From: Tom Tromey Sent: Tuesday, June 20, 2023 4:08 PM To: Branislav Brzak Cc: gdb-patches@sourceware.org ; Dragoslav Sica= rov ; Djordje Todorovic Subject: Re: [PATCH 0/1] riscv: Ensure LE instruction fetching > Currently riscv gdb code looks at arch byte order > when fetching instructions. This works when the > target is LE, but on BE arch it will byte swap the > instruction, while the riscv spec defines all > instructions are LE encoded regardless of > system memory endianess. Thank you for the patch. > @@ -1812,7 +1812,7 @@ ULONGEST > riscv_insn::fetch_instruction (struct gdbarch *gdbarch, > CORE_ADDR addr, int *len) > { > - enum bfd_endian byte_order =3D gdbarch_byte_order_for_code (gdbarch); > + enum bfd_endian byte_order =3D BFD_ENDIAN_LITTLE; The variable is only used once, so you might as well remove it entirely and replace it BFD_ENDIAN_LITTLE in the call. A comment saying that instructions are always little-endian might be nice. Tom --_000_AM6PR03MB49841E8E3F391F342ED12B66985CAAM6PR03MB4984eurp_-- --_004_AM6PR03MB49841E8E3F391F342ED12B66985CAAM6PR03MB4984eurp_ Content-Type: text/x-patch; name="0001-riscv-tdep.c-riscv_insn-fetch_instruction-Always-fet.patch" Content-Description: 0001-riscv-tdep.c-riscv_insn-fetch_instruction-Always-fet.patch Content-Disposition: attachment; filename="0001-riscv-tdep.c-riscv_insn-fetch_instruction-Always-fet.patch"; size=1168; creation-date="Tue, 20 Jun 2023 14:21:20 GMT"; modification-date="Tue, 20 Jun 2023 14:21:23 GMT" Content-Transfer-Encoding: base64 RnJvbSAzNjhmZDM0ZTQ3MzYxOTJmMDUzZGU3M2IwZjI0YTI4OGI0M2JmZDI5 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBCcmFuaXNsYXYgQnJ6 YWsgPGJyYW5pc2xhdi5icnpha0BzeXJtaWEuY29tPgpEYXRlOiBUdWUsIDIw IEp1biAyMDIzIDE2OjE5OjU1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gKiBy aXNjdi10ZGVwLmMgKHJpc2N2X2luc246OmZldGNoX2luc3RydWN0aW9uKTog QWx3YXlzIGZldGNoIAogaW5zdHJ1Y3Rpb25zIGFzIExFCgotLS0KIGdkYi9y aXNjdi10ZGVwLmMgfCA0ICsrLS0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2Vy dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZ2RiL3Jp c2N2LXRkZXAuYyBiL2dkYi9yaXNjdi10ZGVwLmMKaW5kZXggNTAwMjc5ZTFh ZTkuLmFlMThlYjY0NDUyIDEwMDY0NAotLS0gYS9nZGIvcmlzY3YtdGRlcC5j CisrKyBiL2dkYi9yaXNjdi10ZGVwLmMKQEAgLTE4MTIsNyArMTgxMiw2IEBA IFVMT05HRVNUCiByaXNjdl9pbnNuOjpmZXRjaF9pbnN0cnVjdGlvbiAoc3Ry dWN0IGdkYmFyY2ggKmdkYmFyY2gsCiAJCQkgICAgICAgQ09SRV9BRERSIGFk ZHIsIGludCAqbGVuKQogewotICBlbnVtIGJmZF9lbmRpYW4gYnl0ZV9vcmRl ciA9IGdkYmFyY2hfYnl0ZV9vcmRlcl9mb3JfY29kZSAoZ2RiYXJjaCk7CiAg IGdkYl9ieXRlIGJ1ZltSSVNDVl9NQVhfSU5TTl9MRU5dOwogICBpbnQgaW5z dGxlbiwgc3RhdHVzOwogCkBAIC0xODMzLDcgKzE4MzIsOCBAQCByaXNjdl9p bnNuOjpmZXRjaF9pbnN0cnVjdGlvbiAoc3RydWN0IGdkYmFyY2ggKmdkYmFy Y2gsCiAJbWVtb3J5X2Vycm9yIChUQVJHRVRfWEZFUl9FX0lPLCBhZGRyICsg Mik7CiAgICAgfQogCi0gIHJldHVybiBleHRyYWN0X3Vuc2lnbmVkX2ludGVn ZXIgKGJ1ZiwgaW5zdGxlbiwgYnl0ZV9vcmRlcik7CisgIC8qIFJJU0MtViBT cGVjaWZpY2F0aW9uIHN0YXRlcyBpbnN0cnVjdGlvbnMgYXJlIGFsd2F5cyBs aXR0bGUgZW5kaWFuICovCisgIHJldHVybiBleHRyYWN0X3Vuc2lnbmVkX2lu dGVnZXIgKGJ1ZiwgaW5zdGxlbiwgQkZEX0VORElBTl9MSVRUTEUpOwogfQog CiAvKiBGZXRjaCBmcm9tIHRhcmdldCBtZW1vcnkgYW4gaW5zdHJ1Y3Rpb24g YXQgUEMgYW5kIGRlY29kZSBpdC4gIFRoaXMgY2FuCi0tIAoyLjM0LjEKCg== --_004_AM6PR03MB49841E8E3F391F342ED12B66985CAAM6PR03MB4984eurp_--