public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Bernd Edlinger <bernd.edlinger@hotmail.de>
To: Tom Tromey <tom@tromey.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	Andrew Burgess <andrew.burgess@embecosm.com>
Subject: Re: [PATCH v3 2/2] Fix an undefined behavior in record_line
Date: Wed, 1 Apr 2020 18:52:36 +0200	[thread overview]
Message-ID: <AM6PR03MB517008ADB720DBE73A16ED88E4C90@AM6PR03MB5170.eurprd03.prod.outlook.com> (raw)
In-Reply-To: <87eet741k5.fsf@tromey.com>

On 4/1/20 6:23 PM, Tom Tromey wrote:
>>>>>> "Bernd" == Bernd Edlinger <bernd.edlinger@hotmail.de> writes:
> 
> Bernd> Additionally do not completely remove symbols
> Bernd> at the same PC than the end marker, instead
> Bernd> make them non-is-stmt breakpoints.
> 
> Bernd> 2020-03-27  Bernd Edlinger  <bernd.edlinger@hotmail.de>
> Bernd> 	* buildsym.c (record_line): Fix undefined behavior and preserve
> Bernd> 	lines at eof.
> 
> IIUC this fixes:
> 
> Bernd> +     give surprising results.  Expect gdb.cp/step-and-next-inline.exp
> Bernd> +     to fail if these lines are not modified here.  */
> 
> ... but doesn't regress anything else?
> 

I did my best to compare the test results with and without this
patch, but I have plenty of time, and can repeat that test before
I commit, just to make sure that it is still the case.

> In that case I think it's fine.  Thank you.
> 
> Tom
> 

Thanks
Bernd.

  reply	other threads:[~2020-04-01 16:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-27  3:50 Bernd Edlinger
2020-04-01 16:23 ` Tom Tromey
2020-04-01 16:52   ` Bernd Edlinger [this message]
2020-04-01 18:40     ` Bernd Edlinger
2020-04-01 18:53       ` Tom Tromey
2020-04-01 19:01         ` Bernd Edlinger
2020-04-03 22:53 ` Luis Machado
2020-04-04  4:21   ` Bernd Edlinger
2020-04-04  7:06     ` Bernd Edlinger
2020-04-04 13:56       ` Luis Machado
2020-04-04 16:06         ` Bernd Edlinger
2020-04-04 16:22           ` Luis Machado
2020-04-04 16:34             ` Bernd Edlinger
2020-04-04 22:55               ` Andrew Burgess
2020-04-05  0:12                 ` Bernd Edlinger
2020-04-04 23:03 ` Andrew Burgess
2020-04-06 17:44   ` Andrew Burgess
2020-04-06 18:48     ` Bernd Edlinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM6PR03MB517008ADB720DBE73A16ED88E4C90@AM6PR03MB5170.eurprd03.prod.outlook.com \
    --to=bernd.edlinger@hotmail.de \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).