From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073086.outbound.protection.outlook.com [40.92.73.86]) by sourceware.org (Postfix) with ESMTPS id 62776385DC02 for ; Wed, 1 Apr 2020 16:52:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 62776385DC02 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bernd.edlinger@hotmail.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G4Qz5SASCjI+du4Dtzs6CqjVShqBMQncssCQMO7jI4P+Ncu7YMWH19WFXI1r2RspdknKqchJbhisAkJKmfbLPHaWDR1Sgdn7GXGa/osCPWeQwsaf0AwWfg5ZZnfuMEpJf9xW63QkYYOkEB5QExeDMqNaCLTFXhWLeqMHJ8JJEaNhO0bXKs2ukU4lnhhU9EzDIlgwl9XoCS3KHPtP0BcfYYBtaxXpsZwv6Uo46dIgybuEqERfbnqTfZIHU4qMdzQR4q3Qp1VH0IqxMQBXyzSMUOI/k1zszlg/uRIADmkdXxU2Y+2vvrWP/4JVyiqhkYWKwXaQeOysDMYRyzAh3YMafA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GaFsF/CGEFruw9UvOyHGv68fVtU++y+KNrRdnq8hPbg=; b=JeEeBetIesNt8EQ+xnm7oIke4iWAxuvaQ8iLboZZfich/+VjNgmIoaR5pccKrEYtjuRUq9W9aEH+x0KpjYeqHQ6UFa5osyZQK5YdfSKmO6ILtgiFf5nlFE2sf7nIBg44gHvLM70K0oUGK2Xtqyhf0J58YanBpNQV4f7FKJy9rob5+5MklLVzH//HP09ate92J2FEsERYpXBf9hxemU2qJH5tIT7kYQoXu6Fww7phtSQT3LyReXKcStNKv/fx19iXOqeLJijM234DYAAMw7wvadsbBHaieZCxS+9RjHoI9ClAlOETYHoJZF4JLnbxJDmJBY1u5jwnGEHgpbbm98+GWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hotmail.de; dmarc=pass action=none header.from=hotmail.de; dkim=pass header.d=hotmail.de; arc=none Received: from VI1EUR04FT032.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0e::4e) by VI1EUR04HT186.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0e::178) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17; Wed, 1 Apr 2020 16:52:37 +0000 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com (2a01:111:e400:7e0e::41) by VI1EUR04FT032.mail.protection.outlook.com (2a01:111:e400:7e0e::123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.15 via Frontend Transport; Wed, 1 Apr 2020 16:52:37 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:05B97991A4ED44C99CD68CE1FF823B4FAE2CF7BAE649D1C3A0FFC220A4B340F4; UpperCasedChecksum:D9B0B1C1C74BB954B86A2E47E09108A1920E5906C0D080DC28A70D716CCB6DAA; SizeAsReceived:8058; Count:50 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::d57:5853:a396:969d]) by AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::d57:5853:a396:969d%7]) with mapi id 15.20.2856.019; Wed, 1 Apr 2020 16:52:37 +0000 Subject: Re: [PATCH v3 2/2] Fix an undefined behavior in record_line To: Tom Tromey Cc: "gdb-patches@sourceware.org" , Andrew Burgess References: <87eet741k5.fsf@tromey.com> From: Bernd Edlinger Message-ID: Date: Wed, 1 Apr 2020 18:52:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 In-Reply-To: <87eet741k5.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM4PR0202CA0020.eurprd02.prod.outlook.com (2603:10a6:200:89::30) To AM6PR03MB5170.eurprd03.prod.outlook.com (2603:10a6:20b:ca::23) X-Microsoft-Original-Message-ID: <94b6ab1c-bb2c-3c16-13e1-007bf399bf75@hotmail.de> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.101] (92.77.140.102) by AM4PR0202CA0020.eurprd02.prod.outlook.com (2603:10a6:200:89::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Wed, 1 Apr 2020 16:52:37 +0000 X-Microsoft-Original-Message-ID: <94b6ab1c-bb2c-3c16-13e1-007bf399bf75@hotmail.de> X-TMN: [lh7q7jzQ1H8A4OWV0nOdisFg1EJsBW+o] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 50 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 946a85a9-e3d8-4e54-f76c-08d7d65d1549 X-MS-TrafficTypeDiagnostic: VI1EUR04HT186: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: olzro2KORvzawPLNeHoh1NkI8Hrb82Qq01Wd5ZAMsLyux0PvJQu8PTM2hmL0ehPMb3SHybE6U3bU6RMJtPaGByqQ7DTp2sp7nBLhGLdeQMSLOFQQk/3r8XWufF66+v5sumqyHRnB64ht9XOT2d/OoGq4o9bfYqnhw7WzDLFCvzZV2aborKdaVTNUeFh3ZabQ X-MS-Exchange-AntiSpam-MessageData: //d7HbHHbnKRUTaY4JNRNj6XgoW0kOuyzIQy1bmOVhJcG/eRDrZbKmqCOVDYd5hJUKmQ8z2yb7FH6Pd3DDVGrasLrVL69ryktFWgWantg4XqYb8Zs/Bl3R1CqlO9cO1aBeZXmNl6XNAmaMuJhVAyvA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 946a85a9-e3d8-4e54-f76c-08d7d65d1549 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2020 16:52:37.6524 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1EUR04HT186 X-Spam-Status: No, score=0.9 required=5.0 tests=BAYES_00, FORGED_MUA_MOZILLA, FREEMAIL_FROM, KAM_DMARC_STATUS, MSGID_FROM_MTA_HEADER, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2020 16:52:40 -0000 On 4/1/20 6:23 PM, Tom Tromey wrote: >>>>>> "Bernd" == Bernd Edlinger writes: > > Bernd> Additionally do not completely remove symbols > Bernd> at the same PC than the end marker, instead > Bernd> make them non-is-stmt breakpoints. > > Bernd> 2020-03-27 Bernd Edlinger > Bernd> * buildsym.c (record_line): Fix undefined behavior and preserve > Bernd> lines at eof. > > IIUC this fixes: > > Bernd> + give surprising results. Expect gdb.cp/step-and-next-inline.exp > Bernd> + to fail if these lines are not modified here. */ > > ... but doesn't regress anything else? > I did my best to compare the test results with and without this patch, but I have plenty of time, and can repeat that test before I commit, just to make sure that it is still the case. > In that case I think it's fine. Thank you. > > Tom > Thanks Bernd.