From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-oln040092070087.outbound.protection.outlook.com [40.92.70.87]) by sourceware.org (Postfix) with ESMTPS id 3919238708CC for ; Wed, 16 Dec 2020 19:57:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3919238708CC Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bernd.edlinger@hotmail.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CzcfFNcfp2XjQRa0/q6dhWaGxu7avJ9mqeHp6D01olBubVfiBR8bLHDoWDo8kKMa+y1yQwzG4TqAd54QKhU2iPGFh1o1JaA0YQagI1GezbyEo/j7+i5wBiawvoJuK0WtExRamNkhTv+E2LPz6UPkjQ/CfQXXiQzxvUPk7XsaP3LUcvyO2UrJdyb8eFUDm7Ziz4hklDC4gSItD0KV/H8TLjgmm3E4thltw7S/38kSsDPCZZW4P9xXJOZQ15NGnAAxIoVykSBWto/OQdzyAwdS7pasU/oePKXU8O9IHN3CWn96vcgzn0Yjcjk1g/L2SnmX3JJaPJ0RPslbFmhztChXDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+TGb3Vg6DCnaqowdayWz6TRZgCtqmZ/ghPTmJZdkeT4=; b=jUzPU6ZeBfoQM0CWUY/Z2bi2A4o4C5qyz5iwow7lL904DtbVIZkJN5IwJ8IDuIRnA3yt4byQZmSKaXBQ3CC+nC7xR0TaZKDB4hRo+POUYvyX+uz2+r0uRAP1MZmiGes6w5AwG/TyYNttEBMBNWAso2Rmy8YiLLW6+VBK582vNZTca7lCf538CumZEPmaTl1PAdQCTxzte8PHYSlV1hlnKeK0ex4RZkIFACYyewNNHCLj5Nfh2+MB6a5jrrKTlvkCLrg+qs33lUdSLtPpF5bGMOaDfe+MUXEF2Ohp4FVdwOuVn2TawqMlGLwxp4pQZy9KX+Db6pA6KxHwrh7IRkIijw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com (2a01:111:e400:7e08::4d) by AM5EUR03HT163.eop-EUR03.prod.protection.outlook.com (2a01:111:e400:7e08::352) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.22; Wed, 16 Dec 2020 19:57:17 +0000 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com (2a01:111:e400:7e08::53) by AM5EUR03FT015.mail.protection.outlook.com (2a01:111:e400:7e08::132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.22 via Frontend Transport; Wed, 16 Dec 2020 19:57:17 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:64414C199EC9CC145D4B69A6884DA6E4F3DAA5C20332336AA544F34D322E58C0; UpperCasedChecksum:44B56FDA3D261C62406E216BC01DB8B74D5CCE143325BDA52A30B5C49D703738; SizeAsReceived:7704; Count:44 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::184e:5e8c:db8f:a596]) by AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::184e:5e8c:db8f:a596%5]) with mapi id 15.20.3654.025; Wed, 16 Dec 2020 19:57:17 +0000 From: Bernd Edlinger Subject: [PATCH] Warn about static libs vs. source-highlight only when necessary To: "gdb-patches@sourceware.org" , Tom Tromey Message-ID: Date: Wed, 16 Dec 2020 20:57:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Content-Type: multipart/mixed; boundary="------------56D680F6FDDC70C6D07D880A" Content-Language: en-US X-TMN: [2QHP0joykaf87uwnyez8//qm24wLREwa] X-ClientProxiedBy: AM9P192CA0022.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:21d::27) To AM6PR03MB5170.eurprd03.prod.outlook.com (2603:10a6:20b:ca::23) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.101] (88.68.3.2) by AM9P192CA0022.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:21d::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Wed, 16 Dec 2020 19:57:15 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 44 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: f7a2d791-9e6d-40e7-317c-08d8a1fcca49 X-MS-TrafficTypeDiagnostic: AM5EUR03HT163: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pKRf/bSQ3v/8KMbWbWC2R8F9Sm65SsbiJD00NmPcytY14Ka0+CmDMeGdaNUf34avvW7telyU+cslRnXQT1b3ncCJDSsWkLrWiQGgdZYnFbdrbeNJOQbT1mAv9CK/SgkN6Fk7Jp7kqv1bjNbXVLWZf++TsgAHRsEQzoWCbxntc04dVrG3zr0kPJI6gke5gOWXuZL8k7H3B7fWtB69mF21ASeE3KjqySSQM7/gUtnc1J017MDFOJNJAT4kOM6uWj7t X-MS-Exchange-AntiSpam-MessageData: aWa/gUgOb4BNmdpxqRVJKIThSwbstGe5BvnNnWCORcYwZBJQsoSu0JqJpCl3rZ6RQXF8V7SdYNtHPROPy5ptFv9snwzyWFvUu2lQUNk25gyT9BWrew0GhA6oO/1L4yBw70w7/IImCRdoravOL5pJXg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2020 19:57:16.9720 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-Network-Message-Id: f7a2d791-9e6d-40e7-317c-08d8a1fcca49 X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5EUR03HT163 X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00, FORGED_MUA_MOZILLA, FREEMAIL_FROM, GIT_PATCH_0, KAM_DMARC_STATUS, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Dec 2020 19:57:21 -0000 --------------56D680F6FDDC70C6D07D880A Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Hi, this is a small improvement regarding the error message when static system libraries are used, but source-highlight does not support that. I have however right now a question about our use of pkg-config. That is: what happens if I build gcc for build != host ? will pkg-config then find the build libraries, and we use them for host, where they might be unavailable? That is probably bound to fail, isn't it? Anyway, is this change OK for trunk? Thanks Bernd. --------------56D680F6FDDC70C6D07D880A Content-Type: text/x-patch; name="0001-Warn-about-static-libs-vs.-source-highlight-only-whe.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Warn-about-static-libs-vs.-source-highlight-only-whe.pa"; filename*1="tch" RnJvbSA0MDg2ZWE3NDRlNWVjYTUxZGIzMjk4YTczNjg0MDQ1YjA4ZTBiNTg4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZXJuZCBFZGxpbmdlciA8YmVybmQuZWRsaW5nZXJAaG90bWFp bC5kZT4KRGF0ZTogV2VkLCAxNiBEZWMgMjAyMCAxOTo0NzoxOCArMDEwMApTdWJqZWN0OiBbUEFU Q0hdIFdhcm4gYWJvdXQgc3RhdGljIGxpYnMgdnMuIHNvdXJjZS1oaWdobGlnaHQgb25seSB3aGVu CiBuZWNlc3NhcnkKClRoaXMgYXZvaWRzIHRoZSBlcnJvciBtZXNzYWdlIHdoZW4gcGtnLWNvbmZp ZyBpcyBhdmFpbGFibGUgYnV0CnNvdXJjZS1oaWdobGlnaHQgaXMgbm90IGluc3RhbGxlZC4KCjIw MjAtMTItMTYgIEJlcm5kIEVkbGluZ2VyICA8YmVybmQuZWRsaW5nZXJAaG90bWFpbC5kZT4KCgkq IGNvbmZpZ3VyZS5hYzogTW92ZSB0aGUgc3RhdGljIGxpYnMgdnMuIHNvdXJjZS1oaWdobGlnaHQK CWVycm9yIG1lc3NhZ2UgdG8gYSBiZXR0ZXIgcGxhY2UuCgkqIGNvbmZpZ3VyZTogUmVnZW5lcmF0 ZS4KLS0tCiBnZGIvY29uZmlndXJlICAgIHwgMTIgKysrKysrLS0tLS0tCiBnZGIvY29uZmlndXJl LmFjIHwgMTIgKysrKysrLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyks IDEyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2dkYi9jb25maWd1cmUgYi9nZGIvY29uZmln dXJlCmluZGV4IDJiZjgwMTQuLjU4MTkwMDIgMTAwNzU1Ci0tLSBhL2dkYi9jb25maWd1cmUKKysr IGIvZ2RiL2NvbmZpZ3VyZQpAQCAtMTIwODMsMTMgKzEyMDgzLDEzIEBAICRhc19lY2hvICJubyAt IHBrZy1jb25maWcgbm90IGZvdW5kIiA+JjY7IH0KICAgICAgIGFzX2ZuX2Vycm9yICQ/ICJwa2ct Y29uZmlnIHdhcyBub3QgZm91bmQgaW4geW91ciBzeXN0ZW0iICIkTElORU5PIiA1CiAgICAgZmkK ICAgZWxzZQotICAgIGNhc2UgIiRMREZMQUdTIiBpbgotICAgICAgKnN0YXRpYy1saWJzdGRjKikK LSAgICAgICAgYXNfZm5fZXJyb3IgJD8gInNvdXJjZSBoaWdobGlnaHQgaXMgaW5jb21wYXRpYmxl IHdpdGggLXN0YXRpYy1saWJzdGRjKys7IGVpdGhlciB1c2UgLS1kaXNhYmxlLXNvdXJjZS1oaWdo bGlnaHQgb3IgLS13aXRob3V0LXN0YXRpYy1zdGFuZGFyZC1saWJyYXJpZXMiICIkTElORU5PIiA1 Ci0gICAgICAgIDs7Ci0gICAgZXNhYwotCiAgICAgaWYgJHtwa2dfY29uZmlnX3Byb2dfcGF0aH0g LS1leGlzdHMgc291cmNlLWhpZ2hsaWdodDsgdGhlbgorICAgICAgY2FzZSAiJExERkxBR1MiIGlu CisgICAgICAgICpzdGF0aWMtbGlic3RkYyopCisgICAgICAgICAgYXNfZm5fZXJyb3IgJD8gInNv dXJjZSBoaWdobGlnaHQgaXMgaW5jb21wYXRpYmxlIHdpdGggLXN0YXRpYy1saWJzdGRjKys7IGVp dGhlciB1c2UgLS1kaXNhYmxlLXNvdXJjZS1oaWdobGlnaHQgb3IgLS13aXRob3V0LXN0YXRpYy1z dGFuZGFyZC1saWJyYXJpZXMiICIkTElORU5PIiA1CisgICAgICAgICAgOzsKKyAgICAgIGVzYWMK KwogICAgICAgU1JDSElHSF9DRkxBR1M9YCR7cGtnX2NvbmZpZ19wcm9nX3BhdGh9IC0tY2ZsYWdz IHNvdXJjZS1oaWdobGlnaHRgCiAgICAgICBTUkNISUdIX0xJQlM9YCR7cGtnX2NvbmZpZ19wcm9n X3BhdGh9IC0tbGlicyBzb3VyY2UtaGlnaGxpZ2h0YAogCmRpZmYgLS1naXQgYS9nZGIvY29uZmln dXJlLmFjIGIvZ2RiL2NvbmZpZ3VyZS5hYwppbmRleCAzNzY2NDNjLi5mMWMyMzNjIDEwMDY0NAot LS0gYS9nZGIvY29uZmlndXJlLmFjCisrKyBiL2dkYi9jb25maWd1cmUuYWMKQEAgLTEyNDgsMTUg KzEyNDgsMTUgQEAgaWYgdGVzdCAiJHtlbmFibGVfc291cmNlX2hpZ2hsaWdodH0iICE9ICJubyI7 IHRoZW4KICAgICAgIEFDX01TR19FUlJPUihbcGtnLWNvbmZpZyB3YXMgbm90IGZvdW5kIGluIHlv dXIgc3lzdGVtXSkKICAgICBmaQogICBlbHNlCi0gICAgY2FzZSAiJExERkxBR1MiIGluCi0gICAg ICAqc3RhdGljLWxpYnN0ZGMqKQotICAgICAgICBBQ19NU0dfRVJST1IoW3NvdXJjZSBoaWdobGln aHQgaXMgaW5jb21wYXRpYmxlIHdpdGggLXN0YXRpYy1saWJzdGRjKys7IGRubAorICAgIGlmICR7 cGtnX2NvbmZpZ19wcm9nX3BhdGh9IC0tZXhpc3RzIHNvdXJjZS1oaWdobGlnaHQ7IHRoZW4KKyAg ICAgIGNhc2UgIiRMREZMQUdTIiBpbgorICAgICAgICAqc3RhdGljLWxpYnN0ZGMqKQorICAgICAg ICAgIEFDX01TR19FUlJPUihbc291cmNlIGhpZ2hsaWdodCBpcyBpbmNvbXBhdGlibGUgd2l0aCAt c3RhdGljLWxpYnN0ZGMrKzsgZG5sCiBlaXRoZXIgdXNlIC0tZGlzYWJsZS1zb3VyY2UtaGlnaGxp Z2h0IG9yIGRubAogLS13aXRob3V0LXN0YXRpYy1zdGFuZGFyZC1saWJyYXJpZXNdKQotICAgICAg ICA7OwotICAgIGVzYWMKKyAgICAgICAgICA7OworICAgICAgZXNhYwogCi0gICAgaWYgJHtwa2df Y29uZmlnX3Byb2dfcGF0aH0gLS1leGlzdHMgc291cmNlLWhpZ2hsaWdodDsgdGhlbgogICAgICAg U1JDSElHSF9DRkxBR1M9YCR7cGtnX2NvbmZpZ19wcm9nX3BhdGh9IC0tY2ZsYWdzIHNvdXJjZS1o aWdobGlnaHRgCiAgICAgICBTUkNISUdIX0xJQlM9YCR7cGtnX2NvbmZpZ19wcm9nX3BhdGh9IC0t bGlicyBzb3VyY2UtaGlnaGxpZ2h0YAogICAgICAgQUNfREVGSU5FKFtIQVZFX1NPVVJDRV9ISUdI TElHSFRdLCAxLAotLSAKMS45LjEKCg== --------------56D680F6FDDC70C6D07D880A--