From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2035.outbound.protection.outlook.com [40.92.91.35]) by sourceware.org (Postfix) with ESMTPS id 26CC7385DC00 for ; Sun, 5 Apr 2020 00:12:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 26CC7385DC00 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bernd.edlinger@hotmail.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P9BBFj//5lvclJly55x2hune+ZE+li+3k9Gk33I0z4+nefNpWaKms6+LCARU8dfsGJHHQjKQid04FyLIQBdQKEfuU1xfTt4PXKVYyRKmM68vuEm1FEw9S/NS1OyC2Q4qUswnYJtPQVhRSjbkycHj4K2ZXgwlFR4X/ahf+jWxfce7VYeUbm7iulvMmSn33dhJRckW+rqC6V/MgymA2DnlmTfIzEpx5r/8jEHFyoA3+s/RN76B6cqLXPORQXx5G4l4J/ET9jONgYM5yOSGGoWANXnVgBxy+3/TUb4AXemHszA99fGS1Cz/oOU1xH+OpsK6ywAPYAlmF6ZbiQAzkvMVjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dgxhza95IQovhjodvG34EiJIdub+Hyqss3qg2EPP+ik=; b=et94aC3131g+5ZIbBqqD8F0S+OACDnZ28erw86K0WLUVUS7I9TDSn3MEPSGnJMz8dV0txRQt1nJJXq6E6OFS+kwJnO/FxyCjsXNlkX+aLWPdYd61yndiwB+i8DxVZY6YO1ANcvDACx7Tv+pG9DoBYzCyM2/MX7IiV8wmUNjf+Wd2zqis9XOO9v8w0SJCpx8xySb05FMa+aQXAvYx5hRu4JeyLL4DWLnCMEk85bmPOnAIN2Q37XPh+WwzfNDIR0Burh8csFJb28jSnqxcaFsHoAoLJbviZNm+TMCQX6x2ooJKYNgi0EPBA48fI7teHw4WvBpFdlUUSuZcj4MUZ162DQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hotmail.de; dmarc=pass action=none header.from=hotmail.de; dkim=pass header.d=hotmail.de; arc=none Received: from AM6EUR05FT023.eop-eur05.prod.protection.outlook.com (2a01:111:e400:fc11::42) by AM6EUR05HT050.eop-eur05.prod.protection.outlook.com (2a01:111:e400:fc11::70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.15; Sun, 5 Apr 2020 00:12:40 +0000 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com (2a01:111:e400:fc11::4a) by AM6EUR05FT023.mail.protection.outlook.com (2a01:111:e400:fc11::352) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.15 via Frontend Transport; Sun, 5 Apr 2020 00:12:40 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:A365066CEE5DB4C1786A4A15BAAF3C602E56076A7C19E5B21747DF0F7D7FC7FF; UpperCasedChecksum:732BF4EB71B6916DF0B79CA8BA1F9AA77DBEB2F01F8342923ED5E888C143D4C3; SizeAsReceived:8576; Count:50 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::d57:5853:a396:969d]) by AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::d57:5853:a396:969d%7]) with mapi id 15.20.2878.018; Sun, 5 Apr 2020 00:12:40 +0000 Subject: Re: [PATCH v3 2/2] Fix an undefined behavior in record_line To: Andrew Burgess Cc: Luis Machado , "gdb-patches@sourceware.org" References: <3a407c0c-e63b-4c3f-dec2-57ff7470164b@linaro.org> <37b43cd4-de96-7e5c-7c17-09e5887af5d0@linaro.org> <20200404225532.GC3917@embecosm.com> From: Bernd Edlinger Message-ID: Date: Sun, 5 Apr 2020 02:12:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 In-Reply-To: <20200404225532.GC3917@embecosm.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM4PR0202CA0020.eurprd02.prod.outlook.com (2603:10a6:200:89::30) To AM6PR03MB5170.eurprd03.prod.outlook.com (2603:10a6:20b:ca::23) X-Microsoft-Original-Message-ID: <60dc3e8f-6675-4abc-b30b-f8e373659b4e@hotmail.de> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.101] (92.77.140.102) by AM4PR0202CA0020.eurprd02.prod.outlook.com (2603:10a6:200:89::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.19 via Frontend Transport; Sun, 5 Apr 2020 00:12:39 +0000 X-Microsoft-Original-Message-ID: <60dc3e8f-6675-4abc-b30b-f8e373659b4e@hotmail.de> X-TMN: [yurte76yp00w4KVcP9UTRvCXcOZKtXsI] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 50 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 7edf1a9f-4c7a-4717-e5cb-08d7d8f60d80 X-MS-TrafficTypeDiagnostic: AM6EUR05HT050: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a084R1GRGyvIrxuY8UCFz0tnFyVJe52JF/0XywHDhSoqPY8TOM64WYjhBFEBV7PgweGPdwXTfqgi8XQg65cQv4i25GOMFs8NvBICkqgfyBJRbxyOeRl4WiwVK7RVnPkDK8QUIdnjA3OgXrfjAt2/2+to7zlAhpBaRQzKt22pHMAtfw92v0Z7izuN0c7BgNH2 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:0; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR03MB5170.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:; DIR:OUT; SFP:1901; X-MS-Exchange-AntiSpam-MessageData: stJLDsI6Og/s5GsV5pG0zDkSQLNLJ8lXQPdH78RRcqX5joQddloLaA030SOiBsPmDZ83Hzya/t/50PZV5paYTMpgySiYSAxRyejifvtBc+n/ogFoHr58/IFf2BikcEotmxjxsiA/CBwKgVAF7Lo9Ow== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7edf1a9f-4c7a-4717-e5cb-08d7d8f60d80 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2020 00:12:39.9458 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6EUR05HT050 X-Spam-Status: No, score=0.7 required=5.0 tests=BAYES_00, FORGED_MUA_MOZILLA, FREEMAIL_FROM, KAM_DMARC_STATUS, MSGID_FROM_MTA_HEADER, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Apr 2020 00:12:42 -0000 On 4/5/20 12:55 AM, Andrew Burgess wrote: > * Bernd Edlinger [2020-04-04 18:34:07 +0200]: > >> Okay, I think I see what is wrong. >> >> Line Number Statements: >> [0x000000b4] Extended opcode 2: set Address to 0x73c >> [0x000000bf] Advance Line by 75 to 76 >> [0x000000c2] Copy >> >> .... >> >> [0x00000129] Extended opcode 2: set Address to 0x73c >> [0x00000134] Advance Line by 1 to 73 >> [0x00000136] Copy >> [0x00000137] Extended opcode 1: End of Sequence >> >> so the second line was previously deleted, >> but now it is a non-is-stmt line. >> The address is the same, >> >> There was previously a discussion that two consecutive line-entries are a >> rogue method to notify the debugger of where the end of header is. >> I don't recall in the moment where this code is located. >> But if someone could point out the place to me, I could >> probably add code to ignore non-is-stmt lines, > > It's in symtab.c:skip_prologue_using_sal. > >> >> Andrew, are you already on that target, with one of your patches from >> yesterday? > > Not really. The other aarch64 issue only required me to get a target > started, so I was using the gdbsim. But this is known to be pretty > iffy, you'd probably have more luck building QEMU and running against > that. > Yeah, that is on my wish list since a while. I have no idea how much work it is, I would also be happy to have an aarch64 QEMU, for testing my openssl patches, I heard they emulate the full instruction set. Maybe not today, but what are the necessary steps? Thanks Bernd. > Thanks, > Andrew > >> >> >> Thanks >> Bernd.