From: Bernd Edlinger <bernd.edlinger@hotmail.de>
To: Luis Machado <luis.machado@linaro.org>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Andrew Burgess <andrew.burgess@embecosm.com>,
Tom Tromey <tom@tromey.com>
Subject: Re: [PATCHv5] Fix range end handling of inlined subroutines
Date: Sun, 5 Apr 2020 01:38:03 +0200 [thread overview]
Message-ID: <AM6PR03MB51704944A88F14366729AA30E4C40@AM6PR03MB5170.eurprd03.prod.outlook.com> (raw)
In-Reply-To: <cc111d95-376f-feea-c768-0d40c72452da@linaro.org>
On 4/5/20 12:27 AM, Luis Machado wrote:
> Hi,
>
> On 4/4/20 4:50 PM, Bernd Edlinger wrote:
>> Hi,
>>
>> this is an updated version of my patch that was originally only intended
>> to fix the issues with inline functions in the same file. That needed
>> re-basing anyway, because of a merge conflict.
>>
>> I removed the code that does the special handling of end sequence
>> markers in record_line now, since it seems to cause more problems than
>> it solves.
>>
>> I believe it will fix the regression that Louis pointed out, and
>> should fix the regression that Andrew wanted to fix with his
>> patch:
>
> I gave this a try and the FAIL's are still there unfortunately.
Yes, I already am aware, short after I wrote the mail,
I think I have now the right idea, I will probably post another
version of the patch....
For your test case we need to make sure that the line entries
at the end of a function are acutually deleted.
That is easy, writing the right thing in the comment will be
hard.
Bernd.
next prev parent reply other threads:[~2020-04-04 23:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-04 19:50 Bernd Edlinger
2020-04-04 22:07 ` Andrew Burgess
2020-04-04 23:59 ` Bernd Edlinger
2020-04-22 21:03 ` Tom Tromey
2020-04-25 7:29 ` Bernd Edlinger
2020-04-04 22:27 ` Luis Machado
2020-04-04 22:30 ` Luis Machado
2020-04-05 0:05 ` Bernd Edlinger
2020-04-04 23:38 ` Bernd Edlinger [this message]
2020-04-05 2:28 ` [PATCHv6] " Bernd Edlinger
2020-04-05 15:26 ` Luis Machado
2020-04-05 16:00 ` Bernd Edlinger
2020-04-05 17:27 ` Bernd Edlinger
2020-04-06 17:35 ` Andrew Burgess
2020-04-06 19:34 ` Bernd Edlinger
2020-04-06 21:17 ` Bernd Edlinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR03MB51704944A88F14366729AA30E4C40@AM6PR03MB5170.eurprd03.prod.outlook.com \
--to=bernd.edlinger@hotmail.de \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@linaro.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).