From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2036.outbound.protection.outlook.com [40.92.89.36]) by sourceware.org (Postfix) with ESMTPS id A6593385DC0A for ; Sat, 4 Apr 2020 23:38:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A6593385DC0A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bernd.edlinger@hotmail.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JYVvG7MPqalhsPARbCVhvVMzgHMa+TEG8xshwpQqUk//cShLzIo6SgO6sFr4bcNgpxsT1pXkmuzbWVIhsgQcAjKBTHKnWzBBVd6Sfmb31aanyDZ8urcCE63KVB3NyS3UbTDiC8pou3er2k4shg4wR4NhoWVjkAUNmLIkw+dwzx/S2kZ4L9e/o+fXB25SyHv3O7mzFZwdrdtTqMhXdQFL3YM4fopsgtZZwWuo88fFtcESQfMjzhPtIpiDX/45cZvSVNBOyAYrr2mHaHBZLiRNIizHiGYk1y46q/0WFPJLON+OgWedC6JvWUY30Pn4RPByrYfdaHZOsiLGqBzrsHliVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iDKKjO0QqD20slPRjBLb5MuGvztl1TuukPFFcyg8dXc=; b=KTVI8w1Jp8SI1XYKcliURBRCa3HSBmVO4gTpTh/Eyw1H7YRGQb0eG53J7Tes8faTHYs9hMEcCHUy+01zxfnctU3yjE9pQim0j7GufDUJ6ZdH6yUBM/ehNfLh67Lr2HTEbytbpKVoeVBukFHTtZ3MI+PQ5cpMyoB0Dn33CpndB94vGdOirhDqLS9irxpAIoDZhKW04H3VY3p7ja9oz5lOFL17UToqsn91VZVEvWYdwxzf6wEMi2BjNXwKNmgo3Ji3kD6709FI7edatAffn1FOgDEdxUOdufYlspHpRYpZCTGEvoIcT9jD5T6zGIG7dRHCku913YE2CuSkhCDqJOV+5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hotmail.de; dmarc=pass action=none header.from=hotmail.de; dkim=pass header.d=hotmail.de; arc=none Received: from AM6EUR05FT025.eop-eur05.prod.protection.outlook.com (2a01:111:e400:fc11::40) by AM6EUR05HT046.eop-eur05.prod.protection.outlook.com (2a01:111:e400:fc11::372) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.15; Sat, 4 Apr 2020 23:38:05 +0000 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com (2a01:111:e400:fc11::45) by AM6EUR05FT025.mail.protection.outlook.com (2a01:111:e400:fc11::185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.15 via Frontend Transport; Sat, 4 Apr 2020 23:38:05 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:84BA4BE73808D08119F17ADE3284D54E0D146843EE18124D451DAF1568D3F5C4; UpperCasedChecksum:E58D416CAAF4E3669CAC5091CC1481643C08038C30D30B5F7F2D347B4FB6E033; SizeAsReceived:8134; Count:49 Received: from AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::d57:5853:a396:969d]) by AM6PR03MB5170.eurprd03.prod.outlook.com ([fe80::d57:5853:a396:969d%7]) with mapi id 15.20.2878.018; Sat, 4 Apr 2020 23:38:05 +0000 Subject: Re: [PATCHv5] Fix range end handling of inlined subroutines To: Luis Machado , "gdb-patches@sourceware.org" , Andrew Burgess , Tom Tromey References: From: Bernd Edlinger Message-ID: Date: Sun, 5 Apr 2020 01:38:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM0PR02CA0085.eurprd02.prod.outlook.com (2603:10a6:208:154::26) To AM6PR03MB5170.eurprd03.prod.outlook.com (2603:10a6:20b:ca::23) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.101] (92.77.140.102) by AM0PR02CA0085.eurprd02.prod.outlook.com (2603:10a6:208:154::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.15 via Frontend Transport; Sat, 4 Apr 2020 23:38:04 +0000 X-Microsoft-Original-Message-ID: X-TMN: [FZBy7JePelktNrifKRQ7b/PIC7ktGWo9] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 49 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 6b75a8bd-1e3a-4431-ed1e-08d7d8f138cd X-MS-TrafficTypeDiagnostic: AM6EUR05HT046: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nZEcKprm90bEHKZpNQ9Yiz3kw/Ec5SXxbUSA7+8IvE6kTEOgeTIzfnQMGoSvZB9S/lz4LDJbJld0jT8V2WATKXLcgFxr04IV/J95C3vJ2AQ//zyRdyMwn+RpQqBwaUVK4RWdsoCAAuetUJQEP0hUKOV9SUo3aoXOpaIHNM4ucdPY0h0M1jUFU05gTYb+Jj5s X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:0; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR03MB5170.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:; DIR:OUT; SFP:1901; X-MS-Exchange-AntiSpam-MessageData: Uagj8ugB7qoMxNcCaxSbeB5dCEHD7dMj6BEqcGs3lVg5/JkcBkXoTeIeXamlV8yYaoxFeueLZfWySqwVsJ0cn/5TFFRRUO5IP27izNMGxRbP0UVaIc6raSRpHHL8+1QeI7tqqkiqAwvDLGaSBxkd9w== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b75a8bd-1e3a-4431-ed1e-08d7d8f138cd X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2020 23:38:05.5877 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6EUR05HT046 X-Spam-Status: No, score=0.9 required=5.0 tests=BAYES_00, FORGED_MUA_MOZILLA, FREEMAIL_FROM, KAM_DMARC_STATUS, MSGID_FROM_MTA_HEADER, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Apr 2020 23:38:08 -0000 On 4/5/20 12:27 AM, Luis Machado wrote: > Hi, > > On 4/4/20 4:50 PM, Bernd Edlinger wrote: >> Hi, >> >> this is an updated version of my patch that was originally only intended >> to fix the issues with inline functions in the same file.  That needed >> re-basing anyway, because of a merge conflict. >> >> I removed the code that does the special handling of end sequence >> markers in record_line now, since it seems to cause more problems than >> it solves. >> >> I believe it will fix the regression that Louis pointed out, and >> should fix the regression that Andrew wanted to fix with his >> patch: > > I gave this a try and the FAIL's are still there unfortunately. Yes, I already am aware, short after I wrote the mail, I think I have now the right idea, I will probably post another version of the patch.... For your test case we need to make sure that the line entries at the end of a function are acutually deleted. That is easy, writing the right thing in the comment will be hard. Bernd.