Re: [PATCH 2/2] gdb: Preserve is-stmt lines when switch between files

[Bernd Edlinger <bernd.edlinger@hotmail.de>]

CC Alexandre Oliva, who maintains this part of GCC.


On 4/22/20 11:13 PM, Tom Tromey wrote:
>>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
> 
> I read through the various threads on this topic, though I think maybe
> not very well.
> 
> IIUC, the issue at hand is that there are two proposed patches to fix
> various issues in this area.
> 
> 
> Andrew's patch takes us roughly to the status quo from before is-stmt
> landed.  This patch takes the view that GCC is currently buggy, so one
> test is partly disabled; and there's a new bug so we can fix GDB once
> GCC is fixed.
> 
> Bernd's patch takes the view that GCC won't be fixed and tries to work
> around the problem; it drops at least one "FILE:LINE" case that
> currently works.
> 
> 
> Is that a fair summary?  There were many messages and details, so I'm
> not sure I either understood it all or that it can be summarized like
> this.
> 

Yes, I agree with this summary.

> If that's fair, then my inclination is to move forward with Andrew's
> patch for the time being, with the primary justification being
> conservatism.  Bernd's patch can always land if/when we have some
> clarification from GCC about whether the bugs there will be fixed.
> 
> Let me know what you think.
> 

I think if we take Andrew's patch the only possible outcome
will be that gcc will disable that statement frontiers debug
option by default, because they do not understand what we
want from them.  (I am one of them, but I came here to understand
you better)


Bernd.

> Tom
>