From: Fredrik Hederstierna <fredrik.hederstierna@verisure.com>
To: Simon Marchi <simark@simark.ca>, Paul Mathieu <paulmathieu@google.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Luis Machado <luis.machado@linaro.org>,
Alan Hayward <Alan.Hayward@arm.com>
Subject: Re: [PATCH] gdb: add support for handling core dumps on arm-none-eabi
Date: Tue, 20 Oct 2020 22:05:57 +0000 [thread overview]
Message-ID: <AM6PR10MB2150EA65733C6C48B49B94B1EF1F0@AM6PR10MB2150.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <f3a6a63b-d1fc-b0cb-3f15-bcb9c95ebb7e@simark.ca>
> From: Simon Marchi <simark@simark.ca>
> Sent: Tuesday, October 20, 2020 5:04 PM
> To: Fredrik Hederstierna <fredrik.hederstierna@verisure.com>; Paul Mathieu <paulmathieu@google.com>
> Cc: gdb-patches@sourceware.org <gdb-patches@sourceware.org>; Luis Machado <luis.machado@linaro.org>; Alan Hayward > <Alan.Hayward@arm.com>
> Subject: Re: [PATCH] gdb: add support for handling core dumps on arm-none-eabi
> Ok, thanks for trying. Is Outlook's SMTP not really SMTP?
I think git-email now works with the SMTP server, but need to learn how to embed message etc. sorry for beginners mistakes..
> One warning to fix we get when applying:
>
> Applying: gdb: Support corefiles for arm-none-eabi
> .git/rebase-apply/patch:703: trailing whitespace.
I found one place with trailing whitespace that I missed, should be fixed.
> One thing that doesn't look right is this, in none_make_corefile_notes:
>
> int global_id = 1;
> struct thread_info *info = find_thread_global_id (global_id);
>
> As you might have noticed, GDB now supports being connected to multiple
> targets at the same time. So, inferior 1 could be a local GNU/Linux
> executable, while inferior 2 could be a remote bare-metal ARM program.
> If so, I guess GDB should just dump all the current inferior's threads
> in the core dump.
I've tried to modify code so it should dump all threads,
created a [PATCH v2] which includes this (sent with git-email).
> I see you have this commented out:
>
> /* make_cleanup (xfree, note_data); */
>
> The way to do it now would be to make note_data a
> gdb::unique_xmalloc_ptr<char>, and do "return note_data.release ();"
> when returning. This way, it gets automatically freed if something bad
> happens. And ideally, gdbarch_make_corefile_notes should be changed to
> return a gdb::unique_xmalloc_ptr<char>, but that's out of the scope of
> this patch (I'll give it a quick try).
I tried to copy linux-tdep.c, and I could not find where data is unallocated, but maybe its a later problem.
> You don't need an _initialize_none_tdep if you don't do anything in it.
Ok, I kept if for now, if something pops up that needs to be put there along the road..
> One last question: I see that you deal with AUXV stuff. Will bare-metal
> arm programs really have an auxiliary vector?
I'm not sure what Auxv contains, but seems to be eg some system info that is handy, I do not know what/if its filled with something by default on a bare-metal arm-none target/arch?
Thanks! BR Fredrik
next prev parent reply other threads:[~2020-10-20 22:06 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-17 0:02 Fredrik Hederstierna
2020-10-19 2:08 ` Simon Marchi
2020-10-19 13:13 ` Luis Machado
2020-10-19 13:15 ` Alan Hayward
2020-10-19 15:25 ` Paul Mathieu
2020-10-20 11:41 ` Fredrik Hederstierna
2020-10-20 12:39 ` Simon Marchi
2020-10-20 14:00 ` Fredrik Hederstierna
2020-10-20 15:04 ` Simon Marchi
2020-10-20 22:05 ` Fredrik Hederstierna [this message]
2020-10-20 23:06 ` Simon Marchi
2020-10-22 0:52 ` Fredrik Hederstierna
2020-10-22 1:24 ` Simon Marchi
2020-10-22 1:49 ` Simon Marchi
2020-10-22 22:32 ` Fredrik Hederstierna
2020-10-23 0:37 ` Simon Marchi
2020-10-25 21:06 ` Fredrik Hederstierna
2020-10-26 11:24 ` Luis Machado
2020-10-26 15:49 ` Fredrik Hederstierna
2020-10-27 16:53 ` Paul Mathieu
2021-01-14 12:36 ` Fredrik Hederstierna
2021-01-14 12:50 ` Luis Machado
2021-01-18 11:09 ` Andrew Burgess
2021-01-18 14:01 ` Luis Machado
2021-06-21 6:30 ` [PATCH] sim: arm: add support for handling core dumps Fredrik Hederstierna
2021-06-22 3:20 ` Mike Frysinger
2021-06-24 13:01 ` Alan Hayward
2021-06-29 9:11 ` Fredrik Hederstierna
2021-01-18 11:01 ` [PATCH] gdb: add support for handling core dumps on arm-none-eabi Andrew Burgess
2021-06-22 2:16 ` Mike Frysinger
2020-10-20 19:34 ` [PATCH] gdb: Support corefiles for arm-none-eabi Fredrik Hederstierna
2020-10-20 21:49 ` Fredrik Hederstierna
2020-10-20 21:58 ` [PATCH v2] Support for corefiles for arm-none-eabi target Fredrik Hederstierna
2020-10-21 2:51 ` Simon Marchi
2020-10-21 14:38 ` Luis Machado
2020-10-22 0:44 ` [PATCH v3][PR gdb/14383]: gdb: corefile support " Fredrik Hederstierna
2020-10-22 0:44 ` [PATCH v3][PR gdb/14383]: Support for corefiles " Fredrik Hederstierna
2020-10-25 20:46 ` [PATCH] " Fredrik Hederstierna
2020-10-25 20:50 ` [PATCH v4][PR gdb/14383] " Fredrik Hederstierna
-- strict thread matches above, loose matches on Subject: below --
2020-10-02 17:32 [PATCH] gdb: add support for handling core dumps on arm-none-eabi Paul Mathieu
2020-10-02 17:51 ` Luis Machado
2020-10-02 21:54 ` Paul Mathieu
2020-10-02 21:59 ` Simon Marchi
2020-10-03 3:57 ` Simon Marchi
2020-10-02 23:55 ` Simon Marchi
2020-10-03 0:35 ` Paul Mathieu
2020-10-03 2:24 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR10MB2150EA65733C6C48B49B94B1EF1F0@AM6PR10MB2150.EURPRD10.PROD.OUTLOOK.COM \
--to=fredrik.hederstierna@verisure.com \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@linaro.org \
--cc=paulmathieu@google.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).