From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-oln040092065027.outbound.protection.outlook.com [40.92.65.27]) by sourceware.org (Postfix) with ESMTPS id 7F5BE39BC07F for ; Sat, 5 Jun 2021 11:44:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7F5BE39BC07F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hotmail.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O3KIHiESUdc0sGRrMOt3uzBMVVGyO65HuwJ6JbpwLkIZobHRg5Iivt8ttPYIO7zuTw5m/oNxYEHMAAZKEIDsY7THmnnujsCbpoXfKxCYhoaFkR5HxrcIJeB97mARgcbFgqdeouOY4jHMz0v9UKY4A8eOmPslFsM9rbNAWXZ5SohKvrkw0H9874lJPk5dSGD7XyNzhn0+49QFb3CGwHm+GYjjHCdz/6uXHvQnle0mYDpACANioK9a/VDBpvspq7HJaXl3GCe/ZhyL9EjtGWq2h9hvNc1bsItHhdg9mK1dWp2TV/jWJ+XTwX5rX3zRPfjFN8OfKBWrDnvQ4fsmQsnnZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rxL/bgzIn6I4FIQn0Bnn7PP6T2nOaJPBGzzW3SHe4LA=; b=Dl6O+bjcJUL5ILAPKtKlEDhiKt2wA2dOgbpGGWbTQoh8qeNhqIsyns1LSKWJEiFiGbbqUohDYN39t97fjpRuJLraBUMDTHicaGORREEU2D/KV2cLi2l0RKhP1nCoxRAx+HoSZuYS4Sh7MTpodMGwbjESxoIqHe28ZGZTDpeKDr7eUU0uH2uH3AVjDZKu7yWbOHJ7FLNmCz1ldojR/HeDRHfUb1ZZ9UkQuuvl5GBoCSFiAvqbiLCTYi2TEPXlP408qEOx9ar05p7k0OeMpulAvUZ0aQpBVzYazB4oR5aGDavF3VWYcbrvuHC4+eegr1aBRHIViPJ6jQlEf7nONnRnnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from VE1EUR01FT057.eop-EUR01.prod.protection.outlook.com (2a01:111:e400:7e19::48) by VE1EUR01HT009.eop-EUR01.prod.protection.outlook.com (2a01:111:e400:7e19::211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.18; Sat, 5 Jun 2021 11:44:06 +0000 Received: from AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM (2a01:111:e400:7e19::51) by VE1EUR01FT057.mail.protection.outlook.com (2a01:111:e400:7e19::408) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.18 via Frontend Transport; Sat, 5 Jun 2021 11:44:06 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:DD4BB5F699DA0E3ECCAE20074446FF193EAE22C5E6654470E27776EF22B5D610; UpperCasedChecksum:754F581013C061D54A6FA5DD7566235451951E4242FCB1F1225B6AA31D6449F2; SizeAsReceived:8110; Count:47 Received: from AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM ([fe80::ad12:6a2c:b949:f65d]) by AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM ([fe80::ad12:6a2c:b949:f65d%5]) with mapi id 15.20.4195.025; Sat, 5 Jun 2021 11:44:06 +0000 Subject: Re: [PATCH] Fix gdb crash due to SIGPIPE when the compile command fails To: Tom Tromey Cc: Christian Biesinger , "gdb-patches@sourceware.org" References: <87tumgp1ob.fsf@tromey.com> <87zgw5oijf.fsf@tromey.com> From: Bernd Edlinger Message-ID: Date: Sat, 5 Jun 2021 13:44:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 In-Reply-To: <87zgw5oijf.fsf@tromey.com> Content-Type: multipart/mixed; boundary="------------07156173259A976D3D7E20F2" Content-Language: en-US X-TMN: [qs/EiD2aH7D3Z4ElXx5N1gfZZ14ARhfN] X-ClientProxiedBy: PR3P189CA0019.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:52::24) To AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:364::23) X-Microsoft-Original-Message-ID: <9342cd23-81ca-cbfb-6a85-e445ecbce68b@hotmail.de> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.101] (84.57.61.94) by PR3P189CA0019.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:52::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.15 via Frontend Transport; Sat, 5 Jun 2021 11:44:04 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 47 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 578c0545-9be4-4734-2a1b-08d9281738ca X-MS-TrafficTypeDiagnostic: VE1EUR01HT009: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: foCZ7+np8+XqwZ86XsmHgeL07233kF5hbxi76bcZdevjjhhXfWWjFjbTPCy8vg4mxX1opMdVikkV6gGCnPAM4qrSZKpu5VrOMKNpgb5dKeTKShlxCql/5vVW8Z6X9L7PW/Ho9lsWRETDLGhk5LAacPN9jDHEwOYXyJ1UtmMW+nmCDsNXnPIpjRqvrXNcaZxZZtXN/dAmE/zmUIJ/Xm85eavTAqVDfleujCWxyAphCb3rf3HEyuHD4RSLLx3VWFSQ4FehVcqkMCI4+D3T4EPS1ibhsZNGyOr/cBg5QstIGXxndDTCUmk+TIInPzR2aVjvATE3Kz/sCJHbYyCWFkWPgSpOlPUGVUgEbWTgBEshim/jPiUMIq5e8+WaoMXH0MXJVvDzlP+Hd7xsuJnxi0zJNw== X-MS-Exchange-AntiSpam-MessageData: uNyi3k0s52iQI9E76RwHJl1YhUlIE2EGEYJOZKibtsARePqmNyZhoU5od3SD5qjQ1TC7Va18hVvfv9QXfwUrMV2PASiX501EV58yvCB7cpxOKO4kyFx+csARQ1fcLwqBHWOEHLV8CNuUQIOBm5u23w== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 578c0545-9be4-4734-2a1b-08d9281738ca X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2021 11:44:05.9384 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: VE1EUR01FT057.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1EUR01HT009 X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, FORGED_MUA_MOZILLA, FREEMAIL_FROM, GIT_PATCH_0, KAM_DMARC_STATUS, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jun 2021 11:44:19 -0000 --------------07156173259A976D3D7E20F2 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 6/4/21 3:39 PM, Tom Tromey wrote: >>>>>> "Bernd" == Bernd Edlinger writes: > > Bernd> I believe it is right to avoid the SIGPIPE before calling the plugin, > Bernd> instead of doing that in gcc-trunk, since we don't know which version > Bernd> we will be calling, and all versions I tried have failed like this. > > That seems fine, but I think it would be better to install the handler > just when working with the plugin, and then uninstall it afterward, sort > of like what class scoped_ignore_sigttou does. > Okay, done, that works for me. Is this OK? Thanks Bernd. --------------07156173259A976D3D7E20F2 Content-Type: text/x-patch; name="0001-Fix-gdb-crash-due-to-SIGPIPE-when-the-compile-comman.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Fix-gdb-crash-due-to-SIGPIPE-when-the-compile-comman.pa"; filename*1="tch" RnJvbSAzYmIzOTY2NjAxYTg5YzE4ZWEyNzAwYzNlYWU0YWE0ZjRlMTk1MjY5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZXJuZCBFZGxpbmdlciA8YmVybmQuZWRsaW5nZXJAaG90bWFp bC5kZT4KRGF0ZTogV2VkLCAyIEp1biAyMDIxIDE5OjIxOjE1ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gRml4IGdkYiBjcmFzaCBkdWUgdG8gU0lHUElQRSB3aGVuIHRoZSBjb21waWxlIGNvbW1hbmQg ZmFpbHMKCkR1ZSB0byB0aGUgU0lHUElQRSB0aGUgZ2RiIHByb2Nlc3MgaXMga2lsbGVkIGhlcmUs IHdoaWNoIGlzCm5vdCBoZWxwZnVsLgoKMjAyMS0wNi0wMiAgQmVybmQgRWRsaW5nZXIgIDxiZXJu ZC5lZGxpbmdlckBob3RtYWlsLmRlPgoKCSogY29tcGlsZS9jb21waWxlLmMgKGNvbXBpbGVfdG9f b2JqZWN0KTogSWdub3JlIFNJR1BJUEUgYmVmb3JlIGNhbGxpbmcKCXRoZSBwbHVnaW4uCi0tLQog Z2RiL2NvbXBpbGUvY29tcGlsZS5jIHwgMzEgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KwogMSBmaWxlIGNoYW5nZWQsIDMxIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nZGIvY29t cGlsZS9jb21waWxlLmMgYi9nZGIvY29tcGlsZS9jb21waWxlLmMKaW5kZXggODQ4MWQxNC4uMzQz MWQ0YyAxMDA2NDQKLS0tIGEvZ2RiL2NvbXBpbGUvY29tcGlsZS5jCisrKyBiL2dkYi9jb21waWxl L2NvbXBpbGUuYwpAQCAtNjMzLDYgKzYzMywzMyBAQCBzdHJ1Y3QgY29tcGlsZV9vcHRpb25zCiAg IGZwdXRzX2ZpbHRlcmVkIChtZXNzYWdlLCBnZGJfc3RkZXJyKTsKIH0KIAorLyogUkFJSSBjbGFz cyB1c2VkIHRvIGlnbm9yZSBTSUdQSVBFIGluIGEgc2NvcGUuICAqLworCitjbGFzcyBzY29wZWRf aWdub3JlX3NpZ3BpcGUKK3sKK3B1YmxpYzoKKyAgc2NvcGVkX2lnbm9yZV9zaWdwaXBlICgpCisg IHsKKyNpZmRlZiBTSUdQSVBFCisgICAgbV9vc2lncGlwZSA9IHNpZ25hbCAoU0lHUElQRSwgU0lH X0lHTik7CisjZW5kaWYKKyAgfQorCisgIH5zY29wZWRfaWdub3JlX3NpZ3BpcGUgKCkKKyAgewor I2lmZGVmIFNJR1RUT1UKKyAgICBzaWduYWwgKFNJR1BJUEUsIG1fb3NpZ3BpcGUpOworI2VuZGlm CisgIH0KKworICBESVNBQkxFX0NPUFlfQU5EX0FTU0lHTiAoc2NvcGVkX2lnbm9yZV9zaWdwaXBl KTsKKworcHJpdmF0ZToKKyNpZmRlZiBTSUdQSVBFCisgIHNpZ2hhbmRsZXJfdCBtX29zaWdwaXBl ID0gTlVMTDsKKyNlbmRpZgorfTsKKwogLyogUHJvY2VzcyB0aGUgY29tcGlsYXRpb24gcmVxdWVz dC4gIE9uIHN1Y2Nlc3MgaXQgcmV0dXJucyB0aGUgb2JqZWN0CiAgICBhbmQgc291cmNlIGZpbGUg bmFtZXMuICBPbiBhbiBlcnJvciBjb25kaXRpb24sIGVycm9yICgpIGlzCiAgICBjYWxsZWQuICAq LwpAQCAtNzU1LDYgKzc4MiwxMCBAQCBzdHJ1Y3QgY29tcGlsZV9vcHRpb25zCiAgICAgZnByaW50 Zl91bmZpbHRlcmVkIChnZGJfc3RkbG9nLCAic291cmNlIGZpbGUgcHJvZHVjZWQ6ICVzXG5cbiIs CiAJCQlmbmFtZXMuc291cmNlX2ZpbGUgKCkpOwogCisgIC8qIElmIHdlIGRvbid0IGRvIHRoaXMs IHRoZW4gR0RCIHNpbXBseSBleGl0cworICAgICB3aGVuIHRoZSBjb21waWxlciBkaWVzLiAgKi8K KyAgc2NvcGVkX2lnbm9yZV9zaWdwaXBlIGlnbm9yZV9zaWdwaXBlOworCiAgIC8qIENhbGwgdGhl IGNvbXBpbGVyIGFuZCBzdGFydCB0aGUgY29tcGlsYXRpb24gcHJvY2Vzcy4gICovCiAgIGNvbXBp bGVyLT5zZXRfc291cmNlX2ZpbGUgKGZuYW1lcy5zb3VyY2VfZmlsZSAoKSk7CiAgIG9rID0gY29t cGlsZXItPmNvbXBpbGUgKGZuYW1lcy5vYmplY3RfZmlsZSAoKSwgY29tcGlsZV9kZWJ1Zyk7Ci0t IAoxLjkuMQoK --------------07156173259A976D3D7E20F2--